Page MenuHomePhabricator

Possible fix for invalid EOF detection on sockets
AbandonedPublic

Authored by BYK on Dec 30 2015, 9:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 12, 12:34 AM
Unknown Object (File)
Tue, Aug 9, 3:27 PM
Unknown Object (File)
Wed, Aug 3, 9:27 AM
Unknown Object (File)
Wed, Aug 3, 2:08 AM
Unknown Object (File)
Wed, Aug 3, 2:08 AM
Unknown Object (File)
Mon, Aug 1, 10:16 PM
Unknown Object (File)
Sat, Jul 30, 2:58 PM
Unknown Object (File)
Wed, Jul 27, 6:10 AM

Details

Reviewers
epriestley
avivey
Group Reviewers
Blessed Reviewers
Summary

Possible fix for T9724 based on @VitaminCpp's suggestion.

Test Plan

noidea

Diff Detail

Repository
rPHU libphutil
Branch
eof-fix
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 9867
Build 11889: arc lint + arc unit

Event Timeline

BYK retitled this revision from to Possible fix for invalid EOF detection on sockets.
BYK updated this object.
BYK edited the test plan for this revision. (Show Details)
BYK added reviewers: avivey, epriestley.
BYK added a subscriber: VitaminCpp.
epriestley edited edge metadata.

[unit tests disabled] because they take ages to run

Specifically, they hang indefinitely after applying this change because it completely breaks channels.

Please don't send untested changes like this upstream -- they aren't helpful.

This revision now requires changes to proceed.Dec 31 2015, 6:50 PM

Oh wow, sorry. I just thought my system was broken and was hoping CI would
run tests. Will see if I can fix this.