Possible fix for T9724 based on @VitaminCpp's suggestion.
Details
Details
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- eof-fix
- Lint
Lint Passed - Unit
Tests Skipped - Build Status
Buildable 9867 Build 11889: arc lint + arc unit
Event Timeline
Comment Actions
[unit tests disabled] because they take ages to run
Specifically, they hang indefinitely after applying this change because it completely breaks channels.
Please don't send untested changes like this upstream -- they aren't helpful.
Comment Actions
Oh wow, sorry. I just thought my system was broken and was hoping CI would
run tests. Will see if I can fix this.