Possible fix for invalid EOF detection on sockets
AbandonedPublic
Actions

Authored by BYK on Dec 30 2015, 9:59 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 3, 4:38 PM

	Unknown Object (File)
	Fri, Nov 1, 2:54 PM

	Unknown Object (File)
	Tue, Oct 29, 2:54 AM

	Unknown Object (File)
	Thu, Oct 24, 1:14 PM

	Unknown Object (File)
	Oct 16 2024, 3:30 AM

	Unknown Object (File)
	Oct 7 2024, 1:37 AM

	Unknown Object (File)
	Oct 1 2024, 10:13 AM

	Unknown Object (File)
	Sep 24 2024, 5:39 AM

View All Files

Subscribers

Korvin

• VitaminCpp

Details

Reviewers

epriestley
avivey

Group Reviewers

Blessed Reviewers

Summary

Possible fix for T9724 based on @VitaminCpp's suggestion.

Test Plan

noidea

Diff Detail

Repository

rPHU libphutil

Branch

eof-fix

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 9867
Build 11889: arc lint + arc unit

Event Timeline

BYK updated this revision to Diff 36044.Dec 30 2015, 9:59 PM

BYK retitled this revision from to Possible fix for invalid EOF detection on sockets.

BYK updated this object.

BYK edited the test plan for this revision. (Show Details)

BYK added reviewers: avivey, epriestley.

BYK added a subscriber: • VitaminCpp.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 30 2015, 9:59 PM

Herald added a subscriber: Korvin. · View Herald Transcript

[unit tests disabled] because they take ages to run

Specifically, they hang indefinitely after applying this change because it completely breaks channels.

Please don't send untested changes like this upstream -- they aren't helpful.

This revision now requires changes to proceed.Dec 31 2015, 6:50 PM

Oh wow, sorry. I just thought my system was broken and was hoping CI would
run tests. Will see if I can fix this.

Abandoning per T9724#151731

Revision Contents
Changeset List

Path

Size

src/

channel/

PhutilSocketChannel.php

3 lines

Diff 36044

View Options

src/channel/PhutilSocketChannel.php

Possible fix for invalid EOF detection on socketsAbandonedPublicActions