Page MenuHomePhabricator

Cast old duration values for unit tests to float in DifferentialController
ClosedPublic

Authored by BYK on Mar 9 2016, 11:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 14, 3:08 AM
Unknown Object (File)
Wed, Aug 3, 11:53 AM
Unknown Object (File)
Sun, Jul 31, 12:30 AM
Unknown Object (File)
Sun, Jul 31, 12:30 AM
Unknown Object (File)
Sun, Jul 31, 12:29 AM
Unknown Object (File)
Jul 14 2022, 5:35 AM
Unknown Object (File)
Jul 13 2022, 7:09 AM
Unknown Object (File)
Jun 25 2022, 11:24 AM
Subscribers

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

BYK retitled this revision from to Cast old duration values for unit tests to float in DifferentialController.
BYK updated this object.
BYK edited the test plan for this revision. (Show Details)
BYK added reviewers: avivey, epriestley.
epriestley edited edge metadata.

This should probably test that duration actually exists. Also not sure why it cropped up now, but whatever. I'll tweak it in the pull.

This revision is now accepted and ready to land.Mar 11 2016, 2:12 AM

I am also making a vaguely related fix I caught elsewhere because I am a loose cannon with no respect for the rules.

+    if (!$diff->getBuildable()) {
+      return null;
+    }
This revision was automatically updated to reflect the committed changes.
src/applications/differential/controller/DifferentialController.php
195

I swear I thought about this but then since it didn't break on our system, I thought it wasn't necessary. Anyways, thanks!