Page MenuHomePhabricator
Feed All Stories

Jan 17 2016

swisspol added a comment to T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster.

What's the format for setting? I tried ["http","https","mailto","hyper"] but it didn't work and actually breaks all links.

Jan 17 2016, 7:30 AM · Phacility
chad updated images of M1450: Projects v3.
Jan 17 2016, 6:41 AM · Projects
chad added a comment to T10163: Remarkup Autocomplete Errata.

haha no idea, this arose from a product discussion about how project tags will render when there are 16 levels.

Jan 17 2016, 3:12 AM · Remarkup, Typeahead
hach-que added a comment to T10163: Remarkup Autocomplete Errata.

wait how do I get @epriestley points

Jan 17 2016, 3:07 AM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

are you kidding me, I spent all my @epriestley points on this as is.

Jan 17 2016, 3:06 AM · Remarkup, Typeahead
hach-que added a comment to T10163: Remarkup Autocomplete Errata.

Is there any intention to add support for auto-complete when typing like "T1234" or "D1234"? That would help immensely with instances that have a large number of tasks or diffs. I know there's been a few times on this instance where I've wanted to refer to diffs in task comments, but I can't remember the number perfectly so I have to open a Maniphest search to try and guess what number it was. Having it in the typeahead with the task / revision title would mean I don't need to spend time doing that.

Jan 17 2016, 3:01 AM · Remarkup, Typeahead
joshuaspence added a comment to T10163: Remarkup Autocomplete Errata.

From D15029:

Jan 17 2016, 2:39 AM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

ǝɯ ɹoɟ sʞɹoʍ ʎǝlʇsǝᴉɹdǝ@

Jan 17 2016, 2:37 AM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

Is it expected that this doesn't work on mobile?

Jan 17 2016, 2:34 AM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

Is it expected that this doesn't work on mobile?

Jan 17 2016, 2:34 AM · Remarkup, Typeahead
joshuaspence added a comment to T10163: Remarkup Autocomplete Errata.

Is it expected that this doesn't work on mobile?

Jan 17 2016, 2:30 AM · Remarkup, Typeahead
cspeckmim added a comment to T10163: Remarkup Autocomplete Errata.

In the case of 1 match, we now hide if there's one match and it's exactly what you typed.

I think that's what I intended to describe - hadn't considered if there was a single match but wasn't exactly what was typed. Thanks.

Jan 17 2016, 2:09 AM · Remarkup, Typeahead

Jan 16 2016

epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 16 2016, 11:46 PM · Remarkup, Typeahead
epriestley added a revision to T10163: Remarkup Autocomplete Errata: Unknown Object (Differential Revision).
Jan 16 2016, 11:38 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

I like that idea. Should it also hide if there are 0-1 matches? When mentioning users with short usernames or project names it's often faster to just type, @chad, @cspeck, #enad, etc.

Jan 16 2016, 11:33 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

Okay, all that stuff is live now too.

Jan 16 2016, 11:21 PM · Remarkup, Typeahead
epriestley added a revision to T10163: Remarkup Autocomplete Errata: Unknown Object (Differential Revision).
Jan 16 2016, 11:08 PM · Remarkup, Typeahead
epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 16 2016, 11:07 PM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

Yeah I'm finding implementation mixed at various sites.

Jan 16 2016, 11:05 PM · Remarkup, Typeahead
epriestley added a revision to T10163: Remarkup Autocomplete Errata: Unknown Object (Differential Revision).
Jan 16 2016, 11:04 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

I didn't do that because I don't think a space is universal -- I've seen ":" and ",", particularly.

Jan 16 2016, 11:04 PM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

I sort of expect it to also place a space for me after selecting the correct object.

Jan 16 2016, 11:02 PM · Remarkup, Typeahead
epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 16 2016, 10:52 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

That word stuff still has some weird/buggy results, I'll see if I can improve the behavior.

Jan 16 2016, 10:51 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

Alright, all that stuff is hopefully fixed/improved now:

Jan 16 2016, 10:49 PM · Remarkup, Typeahead
epriestley added a comment to T10168: Provide a clearer pathway forward for old projects with invalid hashtags.

T10150 is probably describing the same issue, but this report is much more detailed.

Jan 16 2016, 10:41 PM · Projects, Bug Report
epriestley updated subscribers of T10168: Provide a clearer pathway forward for old projects with invalid hashtags.
Jan 16 2016, 10:41 PM · Projects, Bug Report
epriestley merged task T10150: Project Tag Links work Intermitently into T10168: Provide a clearer pathway forward for old projects with invalid hashtags.
Jan 16 2016, 10:41 PM · Projects, Bug Report
CodeMouse92 updated subscribers of T10168: Provide a clearer pathway forward for old projects with invalid hashtags.

Just a heads up. I hope those duplication instructions are sufficient - this is a very weird one.

Jan 16 2016, 10:39 PM · Projects, Bug Report
epriestley added a revision to T10163: Remarkup Autocomplete Errata: Unknown Object (Differential Revision).
Jan 16 2016, 10:37 PM · Remarkup, Typeahead
CodeMouse92 updated subscribers of Q282: Project Contains 'Objects That Don't Exist'.
Jan 16 2016, 10:37 PM · People, Projects, Arcanist
CodeMouse92 added a comment to Q282: Project Contains 'Objects That Don't Exist'.

After extensive testing, with help from @avivey on IRC, we discovered this actually wasn't caused by a deleted user - that had cleaned up just fine. It appears to be a new Projects related bug. See T10168: Provide a clearer pathway forward for old projects with invalid hashtags.

Jan 16 2016, 10:37 PM · People, Projects, Arcanist
CodeMouse92 closed Q282: Project Contains 'Objects That Don't Exist' as invalid.
Jan 16 2016, 10:36 PM · People, Projects, Arcanist
CodeMouse92 created T10168: Provide a clearer pathway forward for old projects with invalid hashtags.
Jan 16 2016, 10:36 PM · Projects, Bug Report
epriestley added a revision to T10163: Remarkup Autocomplete Errata: Unknown Object (Differential Revision).
Jan 16 2016, 10:02 PM · Remarkup, Typeahead
epriestley added a revision to T10163: Remarkup Autocomplete Errata: Unknown Object (Differential Revision).
Jan 16 2016, 9:45 PM · Remarkup, Typeahead
epriestley added a revision to T10163: Remarkup Autocomplete Errata: Unknown Object (Differential Revision).
Jan 16 2016, 9:40 PM · Remarkup, Typeahead
chad triaged T10167: Ponder Query does not search for projects as Wishlist priority.
Jan 16 2016, 9:34 PM · Ponder, Bug Report
chad closed Q281: Use of phurl as resolved.
Jan 16 2016, 9:34 PM · Phurl
chad added Q281: Use of phurl (Answer 313).
Jan 16 2016, 9:34 PM
chad added a comment to Q281: Use of phurl.

Phurl is a prototype.

Jan 16 2016, 9:31 PM · Phurl
epriestley added a revision to T10163: Remarkup Autocomplete Errata: Unknown Object (Differential Revision).
Jan 16 2016, 9:17 PM · Remarkup, Typeahead
epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 16 2016, 9:14 PM · Remarkup, Typeahead
Luke081515.2 updated the task description for T10167: Ponder Query does not search for projects.
Jan 16 2016, 9:00 PM · Ponder, Bug Report
Luke081515.2 added a project to T10167: Ponder Query does not search for projects: Ponder.
Jan 16 2016, 9:00 PM · Ponder, Bug Report
Luke081515.2 created T10167: Ponder Query does not search for projects.
Jan 16 2016, 8:59 PM · Ponder, Bug Report
CodeMouse92 updated Q282: Project Contains 'Objects That Don't Exist' from to Project Contains 'Objects That Don't Exist'.
Jan 16 2016, 8:58 PM · People, Projects, Arcanist
Luke081515.2 updated Q281: Use of phurl from to Use of phurl.
Jan 16 2016, 8:55 PM · Phurl
cspeckmim added a comment to T10163: Remarkup Autocomplete Errata.

That would change your case of @epriestley xvnoinoandsonaf having autosuggest stick around though.

Jan 16 2016, 8:39 PM · Remarkup, Typeahead
cspeckmim added a comment to T10163: Remarkup Autocomplete Errata.

I like that idea. Should it also hide if there are 0-1 matches? When mentioning users with short usernames or project names it's often faster to just type, @chad, @cspeck, #enad, etc.

Jan 16 2016, 8:27 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

Maybe we can do this:

Jan 16 2016, 8:20 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

That'll break @evan danger priestley and #differential mobile unbeta. I don't really see a clean way to resolve that based on spaces-typed, since both human and project names may contain an arbitrary number of internal words. We could put some artificial cutoff (three words? maybe four or five for projects?) but I don't immediately see a way to write a rule that always does what you users want.

Jan 16 2016, 8:18 PM · Remarkup, Typeahead
cspeckmim added a comment to T10163: Remarkup Autocomplete Errata.

@epriestley - Sorry, was just noting the different cases while testing -- most of the 'prefix' ones I gather made sense for the exact reasons you described. The only change I would prefer is if space also dismissed the typeahead - if completely ignoring typeahead it feels like it's in the way.

Jan 16 2016, 8:14 PM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

Another errata is when the typeahead appears off the page and you have to scroll. In Conpherence it, uh, scrolls the main header off the page.

Jan 16 2016, 8:14 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

Let's try the less-annoying way and see if it actually causes problems, it's definitely the behavior I would prefer personally.

Jan 16 2016, 8:14 PM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

But maybe it will feel weird, since I don't think most inline typeaheads work like that. On github as soon as I hit @, it pops a typeahead with you at the top (presumably, you're the commit author?)

Jan 16 2016, 8:05 PM · Remarkup, Typeahead
epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 16 2016, 8:04 PM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

From a design POV I see typeaheads as "Search", not "Browse". They should have some idea when they did @ or # what they were looking to link to.

Jan 16 2016, 8:03 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

Do you think that's preferable? I think it's probably much better for experienced users, but I'm a little worried some users will type a #, sit there, then tell us it's broken if we do that.

Jan 16 2016, 8:02 PM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

We could also decline to pop the typeahead until the user types the first (valid) character. Currently we pop it on @ or # immediately to show the user that it's available and aid discovery, but it might be better to wait until they type one valid character before we pop it, so there wouldn't be a flash on cases of ##, etc.

Jan 16 2016, 8:00 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

We could also decline to pop the typeahead until the user types the first (valid) character. Currently we pop it on @ or # immediately to show the user that it's available and aid discovery, but it might be better to wait until they type one valid character before we pop it, so there wouldn't be a flash on cases of ##, etc.

Jan 16 2016, 7:59 PM · Remarkup, Typeahead
chad added a comment to T10163: Remarkup Autocomplete Errata.

url.png (276×182 px, 2 KB)

Jan 16 2016, 7:59 PM · Remarkup, Typeahead
epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 16 2016, 7:58 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

Typeahead starts when preceded by ., -, (, |, #, @

Jan 16 2016, 7:57 PM · Remarkup, Typeahead
cspeckmim added a comment to T10163: Remarkup Autocomplete Errata.

Some nuances I've tested:

  1. Typeahead starts when preceded by ., -, (, |, #, @
  2. Typeahead does not start when preceded by most other characters including ', ", ?, ,, /, {, }, [, ], ), :, >, < +, _, ;, !
Jan 16 2016, 7:42 PM · Remarkup, Typeahead
Luke081515.2 awarded Blog Post: Development Notes (2016 Week 3) a Like token.
Jan 16 2016, 7:07 PM
Luke081515.2 edited the content of 2016 Week 3 (Mid January).
Jan 16 2016, 7:06 PM
cspeckmim added a comment to T10163: Remarkup Autocomplete Errata.

Not sure if rP2d495e97014d made it on this install, but typing two # in a row still tries to autocomplete. Should it be dismissed if prior text is # as well (for headings/sections)?

Jan 16 2016, 6:57 PM · Remarkup, Typeahead
chad awarded T10166: Build a permanent destruction workflow for Phacility instances a The World Burns token.
Jan 16 2016, 4:06 PM · Phacility
epriestley added a comment to T7163: Convert Phacility file storage to use S3.

The second biggest source of storage pressure appears to be test instances that, e.g., imported the Linux Kernel and were then suspended. I've filed T10166 to follow up.

Jan 16 2016, 3:06 PM · Files, Phacility
epriestley created T10166: Build a permanent destruction workflow for Phacility instances.
Jan 16 2016, 3:06 PM · Phacility
epriestley added a comment to T7163: Convert Phacility file storage to use S3.

This is now available in the cluster, but the storage engine currently never selects it for new writes because MySQL is still configured to allow 8MB chunks. I'm going to selectively migrate some data, but probably not turn default writes on for a week or so.

Jan 16 2016, 2:42 PM · Files, Phacility
efkan added Q280: `Command failed with error #255` at `set HGPLAIN=1 & hg diff` line (Answer 312).
Jan 16 2016, 1:01 PM
efkan updated the answer wiki for Q280: `Command failed with error #255` at `set HGPLAIN=1 & hg diff` line.
Jan 16 2016, 1:01 PM · Diffusion, Arcanist
efkan updated the answer wiki for Q280: `Command failed with error #255` at `set HGPLAIN=1 & hg diff` line.
Jan 16 2016, 1:00 PM · Diffusion, Arcanist
efkan closed Q280: `Command failed with error #255` at `set HGPLAIN=1 & hg diff` line as resolved.
Jan 16 2016, 12:19 PM · Diffusion, Arcanist
johnny-bit awarded M1450: Projects v3 a Love token.
Jan 16 2016, 11:51 AM · Projects
efkan updated Q280: `Command failed with error #255` at `set HGPLAIN=1 & hg diff` line from `(CommandException) Command failed with error #255` at `set HGPLAIN=1 & hg diff` line to `Command failed with error #255` at `set HGPLAIN=1 & hg diff` line.
Jan 16 2016, 11:09 AM · Diffusion, Arcanist
efkan updated the question details for Q280: `Command failed with error #255` at `set HGPLAIN=1 & hg diff` line.
Jan 16 2016, 10:22 AM · Diffusion, Arcanist
efkan updated the question details for Q280: `Command failed with error #255` at `set HGPLAIN=1 & hg diff` line.
Jan 16 2016, 10:14 AM · Diffusion, Arcanist
efkan closed Q277: My source code appears in /var/repo/M/.hg/store/data/ - Is it normal? as invalid.
Jan 16 2016, 7:16 AM · Diffusion
epriestley closed T10165: Differential syntax highlighting can't handle ES6 backtick strings as Resolved.

Pygments added support a couple of months ago but hasn't released a version with support yet. See:

Jan 16 2016, 2:44 AM · Bug Report
chad created P1924 ES6 Backtick.
Jan 16 2016, 2:35 AM
chad added a comment to T10165: Differential syntax highlighting can't handle ES6 backtick strings.

Do you have pygments enabled?

Jan 16 2016, 2:28 AM · Bug Report
ted created T10165: Differential syntax highlighting can't handle ES6 backtick strings.
Jan 16 2016, 2:25 AM · Bug Report
Luke081515.2 awarded T10054: Define product direction for Project/Profile UIs a Love token.
Jan 16 2016, 12:21 AM · Projects
Luke081515.2 awarded M1450: Projects v3 a Love token.
Jan 16 2016, 12:17 AM · Projects
Luke081515.2 added an inline comment to M1450: Projects v3.

This is very nice :), but I got three questions left:

Jan 16 2016, 12:17 AM · Projects

Jan 15 2016

chad added a comment to M1450: Projects v3.

We're actively working on it.

Jan 15 2016, 10:58 PM · Projects
avivey added a comment to Q265: Can repository hosting settings be changed after creation? If so, how? (Answer 305).

I think you can use ./bin/repository reparse to re-read old commits.

Jan 15 2016, 10:53 PM
Luke081515.2 added a comment to M1450: Projects v3.

I think this design is really great! Is this full live or just a part?

Jan 15 2016, 10:32 PM · Projects
chad added a comment to M1450: Projects v3.

I think Projects (Home) is in a reasonable place, will update milestones and subproject mocks.

Jan 15 2016, 9:57 PM · Projects
chad updated images of M1450: Projects v3.
Jan 15 2016, 9:53 PM · Projects
foven added a comment to Q265: Can repository hosting settings be changed after creation? If so, how? (Answer 305).

So Phabricator just won't check the commits for any changes at all then. For example, if the names of commit authors were changed or commit messages were edited, these changes will probably not be picked up? It makes sense that Phabricator doesn't check for these types of changes, although it might be nice to have a way to prompt it to. That is probably of limited use though, so it might not be worth the time to implement it, unless doing so would be simple.

Jan 15 2016, 9:47 PM
avivey added a comment to Q265: Can repository hosting settings be changed after creation? If so, how? (Answer 305).

Right; If you svnadmin the same commits over, the svn cat commands would work correctly, and everything should be ok.

Jan 15 2016, 8:45 PM
chad updated images of M1450: Projects v3.
Jan 15 2016, 8:34 PM · Projects
chad updated images of M1450: Projects v3.
Jan 15 2016, 8:31 PM · Projects
chad awarded Blog Post: Development Notes (2016 Week 3) a Like token.
Jan 15 2016, 8:29 PM
foven added a comment to Q265: Can repository hosting settings be changed after creation? If so, how? (Answer 305).

Thanks for the reply.

Jan 15 2016, 8:27 PM
epriestley published Blog Post: Development Notes (2016 Week 3).
Jan 15 2016, 8:11 PM