Page MenuHomePhabricator
Feed Advanced Search

Jul 27 2018

epriestley added a revision to T13164: Plans: 2018 Week 31 - 33 Bonus Content: Unknown Object (Differential Revision).
Jul 27 2018, 6:13 PM · Plans
epriestley closed T13151: Plans: 2018 Week 23 - Week 30 Bonus Content as Resolved.

I kicked a couple things out and moved the rest to T13164 to sort of force things back on some kind of normal-looking track with a plausible connection to realtime.

Jul 27 2018, 6:06 PM · Plans
epriestley renamed T13151: Plans: 2018 Week 23 - Week 30 Bonus Content from Plans: 2018 Week 23 - Week 26 Bonus Content to Plans: 2018 Week 23 - Week 30 Bonus Content.
Jul 27 2018, 6:05 PM · Plans
epriestley renamed T13164: Plans: 2018 Week 31 - 33 Bonus Content from Plans: 2018 Week (??? Next ???) to Plans: 2018 Week 31 Bonus Content.
Jul 27 2018, 6:05 PM · Plans
epriestley added a comment to T13156: Plans: Improve Phacility UI for managing instance managers and cards.

I'm descheduling this out of T13151 since none of this is too burning and it's grown kind of big. Probably makes more sense after T13076 as we move toward private clusters, since these UIs will need updates anyway.

Jul 27 2018, 6:04 PM · Plans, Phacility
epriestley updated the task description for T13151: Plans: 2018 Week 23 - Week 30 Bonus Content.
Jul 27 2018, 4:28 PM · Plans
epriestley added a comment to T8163: Show changes since last accepted version.

I've marked D19541 as resolving this. The change there isn't quite what was asked for here, but overlaps significantly.

Jul 27 2018, 12:10 AM · Restricted Project, Differential
epriestley added a revision to T8163: Show changes since last accepted version: Unknown Object (Differential Revision).
Jul 27 2018, 12:09 AM · Restricted Project, Differential
epriestley added a revision to T13151: Plans: 2018 Week 23 - Week 30 Bonus Content: Unknown Object (Differential Revision).
Jul 27 2018, 12:09 AM · Plans

Jul 26 2018

epriestley added a comment to T13156: Plans: Improve Phacility UI for managing instance managers and cards.

See also PHI786 for an example of a general issue: voiding invoices is currently inconvenient: there's no actual "void" state for invoices so you have to go hunt them down manually and DELETE them. There should be a formal "Void" state they can be kicked into.

Jul 26 2018, 7:42 PM · Plans, Phacility
epriestley added a comment to T12907: Unable to download large files through alternative file domain.

I can't get anything to break at all now. 💁

Jul 26 2018, 7:39 PM · Bug Report
epriestley closed T13174: Capitalization of "OPcache" during setup is inconsistent as Resolved by committing Restricted Diffusion Commit.
Jul 26 2018, 7:16 PM · Setup
epriestley closed T13172: Saved meme-maker results are case-insensitive as Resolved by committing Restricted Diffusion Commit.
Jul 26 2018, 7:15 PM · Macros
epriestley added a comment to T12907: Unable to download large files through alternative file domain.

I made a change like this to split responses into small blocks and give each a random chance of failing (I tried 4096 and 4027, a prime near 4KB, as miniblock sizes):

Jul 26 2018, 6:35 PM · Bug Report
epriestley added a comment to T12907: Unable to download large files through alternative file domain.

A recent, probably more concrete issue that I've seen is that wget of a large file can succeed (wget automatically resumes) but we can end up with a file that has different content than the original, which is disastrously bad.

Jul 26 2018, 5:58 PM · Bug Report
epriestley added a revision to T7148: Allow users to export their data from Phacility: Unknown Object (Differential Revision).
Jul 26 2018, 5:41 PM · Phacility
epriestley added a revision to T7148: Allow users to export their data from Phacility: Restricted Differential Revision.
Jul 26 2018, 5:39 PM · Phacility
epriestley added a revision to T13174: Capitalization of "OPcache" during setup is inconsistent: Unknown Object (Differential Revision).
Jul 26 2018, 4:53 PM · Setup
epriestley added a revision to T13172: Saved meme-maker results are case-insensitive: Unknown Object (Differential Revision).
Jul 26 2018, 4:46 PM · Macros
epriestley added a comment to T7148: Allow users to export their data from Phacility.

I cherry-picked D19536, deployed it to aux001, and restarted the file data copy, which worked this time. I'm going to restart the export step and hopefully we're off to the races this time.

Jul 26 2018, 1:25 PM · Phacility

Jul 25 2018

epriestley added a comment to T7148: Allow users to export their data from Phacility.

403 instead of a 404

Jul 25 2018, 8:06 PM · Phacility
ekubischta awarded T5411: Allow pasting images when creating Pholio mocks a Orange Medal token.
Jul 25 2018, 3:25 PM · Pholio
epriestley updated the task description for T13151: Plans: 2018 Week 23 - Week 30 Bonus Content.
Jul 25 2018, 12:19 AM · Plans

Jul 23 2018

epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Jul 23 2018, 9:38 PM · Plans
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Jul 23 2018, 9:03 PM · Plans
epriestley added a member for Community: kaendfinger2.
Jul 23 2018, 7:51 PM
epriestley added a member for Blessed Committers: kaendfinger2.
Jul 23 2018, 7:51 PM
epriestley closed T13171: Config has some kind of goofy looking face emoji as a Unicode glyph, which renders as particular nonsense in recent versions of macOS as Resolved by committing Restricted Diffusion Commit.
Jul 23 2018, 7:43 PM · Design
epriestley added a comment to T13169: In DarkConsole, Query profiling in "Analyze" mode helpfully includes stack traces to help identify where a query came from, but these aren't clearly labeled and look like error traces.

We could probably clean this up (it does look a lot like an error) but DarkConsole isn't exactly a shining example of perfect visual design anyway and I'll probably remember or catch this when it next gets a cleanup pass, some time in 3050.

Jul 23 2018, 7:42 PM · Infrastructure

Jul 21 2018

epriestley triaged T13175: Language for similar "pygments" and "convert" binary checks is not consistent as Wishlist priority.
Jul 21 2018, 11:20 AM · Setup
epriestley triaged T13174: Capitalization of "OPcache" during setup is inconsistent as Wishlist priority.
Jul 21 2018, 11:17 AM · Setup
epriestley triaged T13173: PHP configuration value suggester could be more clear about what it wants you to do as Wishlist priority.
Jul 21 2018, 11:15 AM · Setup
epriestley closed T13167: AWS is rebooting several production hosts (July 2018) as Resolved.

It seems like that went through cleanly. I just did Stop + Start + bin/remote deploy on the affected hosts. I then launched a test instance with placement allocations on two of the affected services; it came up cleanly.

Jul 21 2018, 10:50 AM · Phacility, Ops
epriestley added a comment to T13167: AWS is rebooting several production hosts (July 2018).

Beginning the stop/start stuff now.

Jul 21 2018, 10:24 AM · Phacility, Ops
epriestley added a comment to T13167: AWS is rebooting several production hosts (July 2018).

I'm planning to stop/start these instances during the maintenance window today since getting the rebalance into production in the next five days seems wildly optimistic.

Jul 21 2018, 9:27 AM · Phacility, Ops

Jul 20 2018

epriestley edited the content of Changelog.
Jul 20 2018, 11:35 PM
epriestley created 2018 Week 29 (Late July).
Jul 20 2018, 11:27 PM
epriestley created 2018 Week 28 (Mid July).
Jul 20 2018, 11:20 PM
epriestley created 2018 Week 27 (Early July).
Jul 20 2018, 11:19 PM
epriestley created 2018 Week 26 (End of June).
Jul 20 2018, 11:19 PM
epriestley created P2106 cache.json (bin/host release).
Jul 20 2018, 11:17 PM
epriestley closed T13168: epriestley new laptop / not reading documentation setup issues as Resolved.

I made it as far as locala.phacility.com working right so maybe I got everything?

Jul 20 2018, 10:48 PM · Phacility, Setup
epriestley added a revision to T13171: Config has some kind of goofy looking face emoji as a Unicode glyph, which renders as particular nonsense in recent versions of macOS: Unknown Object (Differential Revision).
Jul 20 2018, 10:42 PM · Design
epriestley added a comment to T13172: Saved meme-maker results are case-insensitive.

I think in D19196 the engine always generated uppercase text, but that got changed in D19200, perhaps?

Jul 20 2018, 10:26 PM · Macros
epriestley added a comment to T13172: Saved meme-maker results are case-insensitive.

how did this ever escape us

Jul 20 2018, 10:23 PM · Macros
epriestley awarded T13172: Saved meme-maker results are case-insensitive a The World Burns token.
Jul 20 2018, 10:23 PM · Macros
epriestley triaged T13171: Config has some kind of goofy looking face emoji as a Unicode glyph, which renders as particular nonsense in recent versions of macOS as High priority.
Jul 20 2018, 10:09 PM · Design
epriestley added a revision to T13167: AWS is rebooting several production hosts (July 2018): Unknown Object (Differential Revision).
Jul 20 2018, 10:00 PM · Phacility, Ops
epriestley added a comment to T13167: AWS is rebooting several production hosts (July 2018).

See email. An instance got an invite into an awkward state by cancelling the invite after the user had accepted it but before they registered an account.

Jul 20 2018, 9:52 PM · Phacility, Ops
epriestley added a revision to T13141: MySQL 8.0.4+ uses "caching_sha2_password", which is incompatible with older clients and raises error 2054 ("The server requested authentication method unknown to the client") with virtually no setup guidance: Unknown Object (Differential Revision).
Jul 20 2018, 9:44 PM · Setup
epriestley added a revision to T13168: epriestley new laptop / not reading documentation setup issues: Unknown Object (Differential Revision).
Jul 20 2018, 9:39 PM · Phacility, Setup
epriestley added a comment to T13141: MySQL 8.0.4+ uses "caching_sha2_password", which is incompatible with older clients and raises error 2054 ("The server requested authentication method unknown to the client") with virtually no setup guidance.

The GRANT syntax also appears to have changed. We currently do this (in Phacility-specific code):

Jul 20 2018, 8:59 PM · Setup
epriestley added a comment to T13098: Plans: Arcanist toolsets and extensions.

Also ignore the untamed-wilds branch, I'm just pulling it out of the wreckage of my explosion-prone laptop (see also T13168).

Jul 20 2018, 8:20 PM · Arcanist, Plans
epriestley added a comment to T13098: Plans: Arcanist toolsets and extensions.

ignore me

Jul 20 2018, 8:18 PM · Arcanist, Plans
epriestley added a revision to T13167: AWS is rebooting several production hosts (July 2018): Unknown Object (Differential Revision).
Jul 20 2018, 5:31 PM · Phacility, Ops
epriestley added a revision to T13167: AWS is rebooting several production hosts (July 2018): Unknown Object (Differential Revision).
Jul 20 2018, 5:30 PM · Phacility, Ops
epriestley added a revision to T13167: AWS is rebooting several production hosts (July 2018): Unknown Object (Differential Revision).
Jul 20 2018, 5:28 PM · Phacility, Ops
epriestley added a comment to T13169: In DarkConsole, Query profiling in "Analyze" mode helpfully includes stack traces to help identify where a query came from, but these aren't clearly labeled and look like error traces.

(Yell if I'm assuming too much here.)

Jul 20 2018, 5:16 PM · Infrastructure
epriestley renamed T13169: In DarkConsole, Query profiling in "Analyze" mode helpfully includes stack traces to help identify where a query came from, but these aren't clearly labeled and look like error traces from Query profiling errors out pretty often in darkconsole to In DarkConsole, Query profiling in "Analyze" mode helpfully includes stack traces to help identify where a query came from, but these aren't clearly labeled and look like error traces.
Jul 20 2018, 5:16 PM · Infrastructure
epriestley renamed T13170: Conduit "maniphest.search" method call allows ordering by "project" column on arbitrary queries, but this internal column is only meaningful when "Group By" is "Project" from task search by project errors out to Conduit "maniphest.search" method call allows ordering by "project" column on arbitrary queries, but this internal column is only meaningful when "Group By" is "Project".
Jul 20 2018, 5:14 PM · Conduit
epriestley added a comment to T13170: Conduit "maniphest.search" method call allows ordering by "project" column on arbitrary queries, but this internal column is only meaningful when "Group By" is "Project".

The fix I'd propose is:

Jul 20 2018, 5:13 PM · Conduit
epriestley added a comment to T13170: Conduit "maniphest.search" method call allows ordering by "project" column on arbitrary queries, but this internal column is only meaningful when "Group By" is "Project".

This isn't meaningful, but we can raise a more specific error.

Jul 20 2018, 5:09 PM · Conduit
epriestley added a comment to T13169: In DarkConsole, Query profiling in "Analyze" mode helpfully includes stack traces to help identify where a query came from, but these aren't clearly labeled and look like error traces.

When you "Analyze", we include a stack trace of where the query was issued from so you can hunt it down if you aren't sure. Does that explain the behavior?

Jul 20 2018, 5:05 PM · Infrastructure
epriestley renamed T13168: epriestley new laptop / not reading documentation setup issues from New laptop setup issues to epriestley new laptop / not reading documentation setup issues.
Jul 20 2018, 5:04 PM · Phacility, Setup
epriestley added a revision to T13167: AWS is rebooting several production hosts (July 2018): Unknown Object (Differential Revision).
Jul 20 2018, 5:03 PM · Phacility, Ops
epriestley added a revision to T13167: AWS is rebooting several production hosts (July 2018): Unknown Object (Differential Revision).
Jul 20 2018, 4:54 PM · Phacility, Ops
epriestley renamed T13167: AWS is rebooting several production hosts (July 2018) from AWS is rebooting every host (July 2018) to AWS is rebooting several production hosts (July 2018).
Jul 20 2018, 4:52 PM · Phacility, Ops

Jul 19 2018

epriestley added a comment to T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.

Via PHI773, filter_input_array(INPUT_ENV, FILTER_UNSAFE_RAW); does not appear to work if variables_order excludes E.

Jul 19 2018, 3:20 PM · Infrastructure

Jul 18 2018

jcox awarded T13168: epriestley new laptop / not reading documentation setup issues a The World Burns token.
Jul 18 2018, 8:34 PM · Phacility, Setup
epriestley added a comment to T7303: Provide OAuth access to Conduit.

Plans, yes. Timing is trickier. Currently, we only have one outstanding request for this feature (PHI760, which mostly wants project.search). So it's in queue somewhere, but currently beyond the forecasting horizon.

Jul 18 2018, 6:01 PM · Restricted Project, Conduit, Restricted Project
epriestley added a comment to T7303: Provide OAuth access to Conduit.

Conduit API methods define a getRequiredScope() method, which tells you the scope they require.

Jul 18 2018, 5:53 PM · Restricted Project, Conduit, Restricted Project
epriestley added a comment to T13168: epriestley new laptop / not reading documentation setup issues.

Build just the extension from source?

Jul 18 2018, 12:48 AM · Phacility, Setup

Jul 17 2018

epriestley updated the task description for T13168: epriestley new laptop / not reading documentation setup issues.
Jul 17 2018, 11:17 PM · Phacility, Setup
epriestley updated the task description for T13168: epriestley new laptop / not reading documentation setup issues.
Jul 17 2018, 11:11 PM · Phacility, Setup
epriestley added a revision to T13168: epriestley new laptop / not reading documentation setup issues: Unknown Object (Differential Revision).
Jul 17 2018, 11:06 PM · Phacility, Setup
epriestley added projects to T13168: epriestley new laptop / not reading documentation setup issues: Setup, Phacility.
Jul 17 2018, 11:04 PM · Phacility, Setup
epriestley triaged T13168: epriestley new laptop / not reading documentation setup issues as Low priority.
Jul 17 2018, 10:59 PM · Phacility, Setup
epriestley triaged T13167: AWS is rebooting several production hosts (July 2018) as Normal priority.
Jul 17 2018, 10:20 PM · Phacility, Ops
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Jul 17 2018, 8:41 PM · Plans
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Jul 17 2018, 5:16 PM · Plans
epriestley lowered the priority of T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive from Normal to Wishlist.

I'm going to look at improving the push logs a bit to show which rule blocked a push to address the actual use case in PHI765, which makes this more of a distance nice-to-have.

Jul 17 2018, 5:15 PM · Diffusion, Herald
epriestley triaged T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive as Normal priority.
Jul 17 2018, 4:56 PM · Diffusion, Herald

Jul 16 2018

epriestley added a comment to T13165: Copy detection in Git is very eager about empty files.

T1022 is possibly somewhat-vaguely-adjacent on symlink stuff.

Jul 16 2018, 11:22 PM · Differential, Arcanist, Git

Jul 13 2018

epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Jul 13 2018, 7:10 PM · Differential, Plans
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Jul 13 2018, 7:04 PM · Plans
epriestley updated the task description for T13161: Plans: Improve Differential diff display behaviors.
Jul 13 2018, 6:58 PM · Differential, Plans
epriestley added a comment to T13165: Copy detection in Git is very eager about empty files.

As a special case of this, if you commit an empty a.py file, then add content to it and also add a new empty b.py file in a commit on top of it, the new empty b.py will be detected as a copy of a.py based on the previous (empty) content of the file. I think Git is being pretty reasonable/consistent here, but this is potentially also expectation-defying:

Jul 13 2018, 6:29 PM · Differential, Arcanist, Git
epriestley added a revision to T13156: Plans: Improve Phacility UI for managing instance managers and cards: Unknown Object (Differential Revision).
Jul 13 2018, 6:14 PM · Plans, Phacility
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Jul 13 2018, 5:58 PM · Plans
epriestley added a parent task for T13165: Copy detection in Git is very eager about empty files: T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Jul 13 2018, 4:14 PM · Differential, Arcanist, Git
epriestley added a subtask for T13164: Plans: 2018 Week 31 - 33 Bonus Content: T13165: Copy detection in Git is very eager about empty files.
Jul 13 2018, 4:14 PM · Plans
epriestley triaged T13165: Copy detection in Git is very eager about empty files as Wishlist priority.
Jul 13 2018, 4:12 PM · Differential, Arcanist, Git
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Jul 13 2018, 4:01 PM · Plans
epriestley updated the task description for T13164: Plans: 2018 Week 31 - 33 Bonus Content.
Jul 13 2018, 3:59 PM · Plans
epriestley triaged T13164: Plans: 2018 Week 31 - 33 Bonus Content as Normal priority.
Jul 13 2018, 3:59 PM · Plans
epriestley added a comment to T13091: Ferret "Relevance" order does not always have all the columns it needs available.

Trying to reproduce this locally just hits the ft_doc.epochModified issue. I'm not immediately sure why the behavior differs between my local install and secure, but that issue probably needs to be fixed first.

Jul 13 2018, 3:57 PM · Search
epriestley added a comment to T13091: Ferret "Relevance" order does not always have all the columns it needs available.

Actually, I'm not entirely right in merging that task -- T13163 isn't quite the same as the other two issues here. I think they're similar, but the query text is relevant in the case of T13163. Notably:

Jul 13 2018, 3:50 PM · Search
epriestley merged T13163: Unhandled Exception: Query "ManiphestTaskQuery" failed to return a value from getPagingValueMap() for column "rank". into T13091: Ferret "Relevance" order does not always have all the columns it needs available.
Jul 13 2018, 3:44 PM · Search
epriestley merged task T13163: Unhandled Exception: Query "ManiphestTaskQuery" failed to return a value from getPagingValueMap() for column "rank". into T13091: Ferret "Relevance" order does not always have all the columns it needs available.
Jul 13 2018, 3:44 PM · Maniphest

Jul 9 2018

epriestley added a revision to T13151: Plans: 2018 Week 23 - Week 30 Bonus Content: Unknown Object (Differential Revision).
Jul 9 2018, 9:36 PM · Plans