Yeah, the upper-right action thing is a little weird since we don't use it in other applications, but it has felt OK to me once I kind of got used to it / continued being too lazy to change it.

Wouldn't miss it for the world!

This is probably the required test:

The policies work like you expect them to. This is just like a revision saying "All Users" but not being visible to users who can't see the corresponding repository.

It's just very
important to
thoroughly explore
the applications

(If we were better about figuring this out automatically -- which we may be soon -- would it be a problem at all?)

The distinction between "Earlier Revisions" and "Earlier Versions of This Revision" (e.g., earlier diffs) seems potentially confusing to me. That is, I could imagine a new user thinking "Earlier Revisions" meant "earlier versions of this change", not "prior changes which this change depends on".

Or, of course, we could do:

I think there was no web UI for this until T4788, which added both options. Prior to that, the only way to mark dependencies was by writing "Depends On" in text (which still works). So we didn't previously have anything else, unless I'm misremembering.

Our use of "parent" and "child" are consistent with Git's use of "parent" and "child", if that helps: for example, git help log discusses the ideas of "parent commits" and "child commits" in many places, and "parent revisions" and "child revisions" have the same relationship order as commits do in Git.

What specific, totally unambiguous labels would you prefer these actions to have?

Sounds good, thanks!

%s cannot be repeated as far as I know.

"aBmeIEk": {
    "one": "%s star",
    "other": "%s stars"
},

Here are the current internal data formats:

Variables such as $1 are not part of the spec, and it makes no difference to us if you use %s instead. So unless this conversion is required by your system, you can drop it.

Here's the XHProf link:

This self-healed (probably after another commit was pushed) so I don't expect to look at it for a while unless it happens again.

• • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • •
• Sorry, I've dropped my bag of Doritos™ brand perfect circles • • • • •
• • • • • • • • • • • • • • • • • • • • • • • • • •• • • •• • • • • • • •

The color should be fixed by D16819.

So far the pup is sleeping a lot and doing very little mischief.

At HEAD, I think the all-day issues with the French holidays above are fixed. You may need to reload the import for the change to take effect, but things seem OK for me locally now:

Ah, cool. I think that's a Zimbra issue, then.

@ivo, that's expected if you previously edited the Nov 8 instance. This is consistent with Calendar.app, although not with Google Calendar.

(mindrot.org is currently inaccessible for me so I wasn't able to read the details you linked, although I imagine they aren't too relevant to how we handle things.)

I was trying to import the french holidays from google ICS file...

The rTRANSLATEWIKI repository is now available. Here is an example of the en.json MediaWiki-style JSON string file we currently generate:

This isn't a bug. Here's an example of why the proposed behavior is dangerous:

I'd prefer not to produce any output until we've generated everything, so we don't end up in a situation where we output half of the file and then fail if we can help it. Additionally, this script changed in D16744, a few weeks ahead of your version.

I don't know what this means. $ in the string contents isn't anything special for translatewiki.net.

The technical definition of "Limited" is that it has fewer than 512 strings, including 0 strings.

You should file a new bug report, describing exactly what you did and how we can reproduce the problem.

To report a bug, please provide complete reproduction steps. We can't fix issues we can't reproduce. See Contributing Bug Reports for details.

I think D16810 should get this started, at least. Known technical issues:

@MZMcBride, couple of questions so we can improve this:

I've marked D16806 as resolving this. Once that lands, here's the state of the world in terms of how the product works:

I would expect that we could parse a 3MB .ics file in less than 30 seconds, but obviously there's nothing to prevent you from uploading a 30MB or 300MB or 3GB .ics file, and at some point we'll take longer than 30 seconds to process it.

T11399 has some discussion of "Location" for events -- we could possibly implement a little piece of that now to split out resources from normal attendees, but my initial inclination is to wait until we do a real implementation of locations.

I wasn't immediately able to reproduce the "OPT-PARTICIPANT" issue -- here's the file I used, trying to mimic your test case:

• D16804 should resolve the sha1() issue.
  • That may also resolve the timeout: the sha1() issue made us take a much slower code path. But I might also need to optimize the import and make it fall back to occurring in the background for large .ics files. Let me know if you're still seeing timeouts after the sha1() fix.
  • When a user is only an email address, we currently show "Private User 1" instead of the address. We could just show the address, or could show some "totally impossible to guess" address like me.......om@mycompany.com, but I wanted to err on the side of caution about disclosing email addresses, at least to start with. We're fairly conservative about this in other parts of the product and it's hard to put the cat back in the bag if we consider this information open. In Phabricator, it's easier to import an .ics file and expose the data to all users than it is in more private-by-default / personally-focused applications with defaults aimed more toward individual users, which also gives me some pause. But this may get in the way of usability too much, so I could see changing this behavior. If a user has a display name ("Meeting Room" <meetingroom@company.com>), we should show them as "Meeting Room", we just avoid showing meetingroom@company.com if that's the only name we have.
  • I'll look at the OPT-PARTICIPANT thing, I would expect them to import but just not have an "optional" marker right now. To clarify, they didn't import at all, right?
  • The "Ignored Node" stuff is likely fine, things like VALARM sections inside VEVENT sections. At some point I'll make the error message more helpful ("Ignored a VALARM section; Phabricator does not send reminders for imported events.") but probably OK to ignore those warnings for now.
  • URI stuff is because security.outbound-blacklist defaults to blacklisting all private/internal IP space, to prevent attackers from discovering and interacting with private services on your network by using features like image proxying, macros, calendar import, etc. If you want to fetch data from a host in private IP space, you'll need to remove its address from the blacklist (or expose an alternate interface for it in public IP space).

Cool. I'll merge this into T4124 and retitle that to be a little more specific.

We've only seen that one other time, so it hasn't been a priority to fix. I believe the other install which hit the issue was able to install GNU diff to resolve it.

Incidentally, this Phabricator installation is running on Solaris (Solaris 11.3) if that makes any difference.

(If you believe I'm mistaken, please show the full stack trace for the error so we can identify and remove the remaining reference to this column.)

@deric, the code event.dateTo no longer appears anywhere in Phabricator (it was removed prior to the column being removed) so I suspect you did not restart properly and were running cached code (or possibly have custom code you need to update). See Restarting Phabricator.