Page MenuHomePhabricator
Feed Advanced Search

Apr 20 2022

epriestley added a comment to T13640: Improve sequencing of Futures in "--trace" output.

See also T13646: some very early service calls during initialization currently occur before --trace becomes active. These calls should be visible, possibly by buffering them and then dumping the buffer once --trace comes online.

Apr 20 2022, 6:36 PM · Infrastructure
epriestley added a comment to T13667: Landing a mercurial revision which has no changes causes errors on the revision page as well as history viewing.

Browsing Revision

Apr 20 2022, 6:31 PM · Arcanist, Mercurial
epriestley added a comment to T13588: PHP 8 Compatibility.

PHP 8.1 disallows strlen(null).

Apr 20 2022, 6:01 PM · Infrastructure
epriestley added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Apr 20 2022, 5:45 PM · Infrastructure
epriestley added a revision to T13667: Landing a mercurial revision which has no changes causes errors on the revision page as well as history viewing: Unknown Object (Differential Revision).
Apr 20 2022, 4:53 PM · Arcanist, Mercurial
epriestley added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Apr 20 2022, 4:53 PM · Infrastructure
epriestley added a revision to T13667: Landing a mercurial revision which has no changes causes errors on the revision page as well as history viewing: Unknown Object (Differential Revision).
Apr 20 2022, 4:37 PM · Arcanist, Mercurial
epriestley added a revision to T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation: Unknown Object (Differential Revision).
Apr 20 2022, 4:31 PM · Git, Security

Apr 19 2022

epriestley added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Apr 19 2022, 9:55 PM · Infrastructure
epriestley added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Apr 19 2022, 9:48 PM · Infrastructure
epriestley closed T13579: Overseer may fatal when trying to write to "pid" property in "annihilateProcessGroup()" as Resolved.

This was resolved by D21452. PHI1880 has some unrelated additional plans.

Apr 19 2022, 9:31 PM · Daemons
epriestley closed T13661: Give Phame configurable interact policies as Resolved.

I deployed this and it seems to be working properly.

Apr 19 2022, 9:07 PM · Phacility, Phame
epriestley closed T13674: Ubuntu20 systemd restart script does not reliably execute on Ubuntu20/m4 chassis hosts as Resolved.

Hey, it worked once. Good enough for me!

Apr 19 2022, 5:55 PM · Phacility
epriestley added a comment to T13674: Ubuntu20 systemd restart script does not reliably execute on Ubuntu20/m4 chassis hosts.

No dice. We need bin/upgrade to run before mysql because it has to mount the data volume. So now I'm trying this:

Apr 19 2022, 5:48 PM · Phacility
epriestley added a comment to T13674: Ubuntu20 systemd restart script does not reliably execute on Ubuntu20/m4 chassis hosts.

... service ... start rather than service ... restart ...

Apr 19 2022, 5:27 PM · Phacility
epriestley added a comment to T13674: Ubuntu20 systemd restart script does not reliably execute on Ubuntu20/m4 chassis hosts.

...probably tested...

Apr 19 2022, 5:22 PM · Phacility
epriestley triaged T13674: Ubuntu20 systemd restart script does not reliably execute on Ubuntu20/m4 chassis hosts as Low priority.
Apr 19 2022, 4:30 PM · Phacility

Apr 14 2022

epriestley closed T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation as Resolved.

I deployed this everywhere in the Phacility cluster yesterday and things have been quiet, so I'm assuming it worked until evidence arises to the contrary.

Apr 14 2022, 1:49 PM · Git, Security
epriestley updated the task description for T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation.
Apr 14 2022, 1:47 PM · Git, Security

Apr 13 2022

epriestley added a comment to T11908: Support an "overlay" database connection mode where multiple applications share a single connection.

With max_connections at 1024, the server above still looks fine after ~14 days:

Apr 13 2022, 7:43 PM · Infrastructure
epriestley edited the content of 2022 Week 15 (Mid April).
Apr 13 2022, 7:09 PM
epriestley edited the content of 2022 Week 15 (Mid April).
Apr 13 2022, 7:08 PM
epriestley edited the content of Changelog.
Apr 13 2022, 7:04 PM
epriestley created an object: 2022 Week 15 (Mid April).
Apr 13 2022, 7:03 PM
epriestley added a comment to T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation.

D21756 effectively makes all Git pathways call setSudoAsDaemon(true).

Apr 13 2022, 6:31 PM · Git, Security
epriestley added a comment to T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation.

Just for visibility, the error messages you'll see if you're affected by this issue look something like this:

Apr 13 2022, 6:06 PM · Git, Security
epriestley added a comment to T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation.

...maybe this is an actual bug in Phabricator where some pathways are just missing the "sudo" wrapper?

Apr 13 2022, 6:06 PM · Git, Security
epriestley triaged T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation as Normal priority.
Apr 13 2022, 5:48 PM · Git, Security

Apr 1 2022

epriestley added a comment to T11908: Support an "overlay" database connection mode where multiple applications share a single connection.

Elsewhere, I compacted Phacility free instances onto a small number of database servers. I attempted to "fill up" these servers, and succeeded, sort of, but maybe too much -- they eventually fall over and need to be rebooted.

Apr 1 2022, 8:35 PM · Infrastructure
epriestley added a comment to T13661: Give Phame configurable interact policies.

This has some rough edges that I'm not going to deal with for now:

Apr 1 2022, 7:52 PM · Phacility, Phame
epriestley added a revision to T13661: Give Phame configurable interact policies: Unknown Object (Differential Revision).
Apr 1 2022, 7:49 PM · Phacility, Phame
epriestley added a revision to T13661: Give Phame configurable interact policies: Unknown Object (Differential Revision).
Apr 1 2022, 7:41 PM · Phacility, Phame
epriestley added a revision to T13661: Give Phame configurable interact policies: Unknown Object (Differential Revision).
Apr 1 2022, 7:16 PM · Phacility, Phame
epriestley added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Apr 1 2022, 7:08 PM · Infrastructure
epriestley added a revision to T13661: Give Phame configurable interact policies: Unknown Object (Differential Revision).
Apr 1 2022, 7:05 PM · Phacility, Phame
epriestley added a revision to T13661: Give Phame configurable interact policies: Unknown Object (Differential Revision).
Apr 1 2022, 6:48 PM · Phacility, Phame
epriestley added a revision to T13661: Give Phame configurable interact policies: Unknown Object (Differential Revision).
Apr 1 2022, 6:46 PM · Phacility, Phame
epriestley added a revision to T6203: Adjust nullability of various questionable columns: Unknown Object (Differential Revision).
Apr 1 2022, 6:43 PM · Infrastructure
epriestley added a revision to T13661: Give Phame configurable interact policies: Unknown Object (Differential Revision).
Apr 1 2022, 6:43 PM · Phacility, Phame

Mar 24 2022

epriestley added a comment to T13658: How to rebrand Phabricator.

Will this work will with Phabricator?

Mar 24 2022, 6:06 PM

Mar 15 2022

epriestley added a comment to T13672: Arcanist: Exceptions when using Mercurial ~6.0/6.1.

GitHub was refusing mirror pushes with a credential issue (see also T12896, vaguely). I'm not entirely sure which side of things changed, but the config was set up in a previous-generation way anyway (through a "bot" account instead of a "Deploy Key") so I updated things. Looks like mirroring is back online now and this change has propagated.

Mar 15 2022, 5:01 PM

Dec 19 2021

epriestley closed T11230: Phacility: Private Clusters as Wontfix.

See T12847. All the technical parts of this are now solved except for billing, but since Phacility is winding down I no longer plan to pursue it.

Dec 19 2021, 8:45 PM · Phacility
epriestley closed T8688: Attach and initialize backup volumes during `remote deploy` workflow as Resolved.

I resolved this in rCORE320b2854.

Dec 19 2021, 8:43 PM · Phacility
epriestley closed T12847: A Pathway Towards Private Clusters as Wontfix.

After T13630:

Dec 19 2021, 8:39 PM · Plans, Ops, Phacility
epriestley closed T12847: A Pathway Towards Private Clusters, a subtask of T11230: Phacility: Private Clusters, as Wontfix.
Dec 19 2021, 8:39 PM · Phacility
epriestley closed T13601: Support "SCA" / "3D Secure 2" in billing workflows as Wontfix.

Only one instance was impacted by this and I just credited them until 2099. I don't currently expect to pursue this.

Dec 19 2021, 8:26 PM · Phacility, Phortune
epriestley closed T13610: Support per-node billing for hosted Phacility instances as Wontfix.

I no longer expect to pursue this.

Dec 19 2021, 8:25 PM · Phortune, Phacility
epriestley closed T13618: When a Phacility "rbak" device does not exist, backups can run twice and converge to a "successful" but inconsistent state as Wontfix.
  • Hosts in the repo class are now build by Piledriver (see T13630), which automatically creates the rbak device entries, so this error isn't likely to occur again.
  • I also don't expect to launch any more hosts.
Dec 19 2021, 8:25 PM · Phacility
epriestley closed T13654: Wind Down Phacility Operations as Resolved.

I compacted secure onto new hardware (T13671) and shut down saux001 ("Land Revision") and sbuild001 (Harbormaster remote builds). I think all the remaining work is covered under T13630 (largely, just a handful of large database migrations remain).

Dec 19 2021, 8:23 PM · Phacility
epriestley closed T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware as Resolved.

I just swapped configs over without merging the LBs, since it wasn't immediately obvious to me what the Application vs Classic state of the world is and swapping was good enough.

Dec 19 2021, 7:35 PM · Phacility
epriestley added a comment to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware.

The aphlict/notify stuff still needs to be tweaked. I think the snlb + slb setup can be merged into a single slb with "TCP (Secure)" forwarding now.

Dec 19 2021, 4:19 AM · Phacility
epriestley added a comment to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware.

Databases are moved and secure is out of read-only mode. I'm going to adjust repository configuration, then I should be able to tear down secure001.

Dec 19 2021, 4:11 AM · Phacility
epriestley added a comment to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware.

I'm going to put secure back into read-only mode now and move the databases to the new host.

Dec 19 2021, 12:08 AM · Phacility
epriestley added a comment to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware.

I brought up the new host and pointed the slb001 load balancer at it. The database is still on the old host, and the new host doesn't have repositories yet, but the basics seem to be working.

Dec 19 2021, 12:07 AM · Phacility

Dec 18 2021

epriestley added a comment to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware.

Merging 003 into 001 worked fine with a few expected tricks (e.g., when secure is in read-only mode, you can't push a change to take it out of read-only mode, since pushing is a write). Next up is launching a modern m4.large secure-pool host and then migrating the data.

Dec 18 2021, 7:57 PM · Phacility
epriestley added a comment to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware.

I'm putting secure into read-only mode now, with the intent of completing steps 1-5 above.

Dec 18 2021, 7:13 PM · Phacility
epriestley added a revision to T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware: Unknown Object (Differential Revision).
Dec 18 2021, 7:06 PM · Phacility

Dec 17 2021

epriestley triaged T13671: Merge "secure003.phacility.net" into "secure001.phacility.net", then migrate to "m4.large" hardware as Low priority.
Dec 17 2021, 7:32 PM · Phacility

Dec 16 2021

epriestley added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Dec 16 2021, 11:07 PM · Infrastructure
epriestley added a comment to T13588: PHP 8 Compatibility.

PHP 8.1 changed semantics of static variables in methods. See:

Dec 16 2021, 10:42 PM · Infrastructure
epriestley added a comment to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5.

See also T13588. Using static::class to work around changes to the scope of static in PHP 8.1 is also possible now that PHP 5.5 is the minimum version, and some uses of get_class($this) might be replaceable. There's no strong motivator for this, it's just a little cleaner.

Dec 16 2021, 10:40 PM · Infrastructure
epriestley added a comment to T13637: PHP Static Method Variable Scope.

See also T13588.

Dec 16 2021, 10:37 PM · Lint, Guides
epriestley lowered the priority of T13655: Provide a formal "destroyed" status for Phacility instances from Normal to Wishlist.

It would still be nice to have this from a completeness/correctness perspective, but other changes have made it less valuable:

Dec 16 2021, 2:58 PM · Phacility

Dec 14 2021

epriestley added a comment to T13670: When a repository remote URI has a username in the URI and a different credential username, fail in an obvious way.

...possibly, but not conclusively, a result of an SSH version upgrade...

Dec 14 2021, 8:02 PM · Passphrase, Diffusion
epriestley triaged T13670: When a repository remote URI has a username in the URI and a different credential username, fail in an obvious way as Wishlist priority.
Dec 14 2021, 5:58 PM · Passphrase, Diffusion

Dec 11 2021

epriestley added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Dec 11 2021, 7:17 PM · Infrastructure
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

I put all the database migration stuff everywhere and it appears stable. I'm hooking up Postmark as an outbound pathway now. If I get that working, I'll let it sit for a while and start migrating databases.

Dec 11 2021, 5:43 PM · Almanac, Infrastructure, Phacility
epriestley edited the content of Changelog.
Dec 11 2021, 3:48 PM
epriestley created an object: 2021 Week 50 (Mid December).
Dec 11 2021, 3:47 PM

Dec 10 2021

epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

Finally, there are other some MySQL version issues which can be avoided with:

Dec 10 2021, 6:22 PM · Almanac, Infrastructure, Phacility
epriestley added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Dec 10 2021, 12:21 AM · Infrastructure

Dec 9 2021

epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

The new core/ support for the API is partially deployed; the new services/ support isn't anywhere yet.

Dec 9 2021, 11:13 PM · Almanac, Infrastructure, Phacility
epriestley added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Dec 9 2021, 9:55 PM · Infrastructure
epriestley added a comment to T13588: PHP 8 Compatibility.

See also T13232. Here's a possible build strategy for PHP 8.1 under macOS Mojave. Anyone reasonable should probably give up and use brew instead.

Dec 9 2021, 8:46 PM · Infrastructure
epriestley added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Dec 9 2021, 8:46 PM · Infrastructure

Dec 8 2021

epriestley edited the content of Migrating Repository Shards.
Dec 8 2021, 9:39 PM · Phacility

Dec 4 2021

epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

The latest version of Phabricator itself is everywhere.

Dec 4 2021, 11:46 PM · Almanac, Infrastructure, Phacility
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

I'm going to hold it until the weekend and try deploying then if things look calm on my end.

Dec 4 2021, 9:23 PM · Almanac, Infrastructure, Phacility

Dec 2 2021

epriestley added a revision to T13669: Discourage use of Mailgun as a mail provider: Unknown Object (Differential Revision).
Dec 2 2021, 10:48 PM · Guides, Mail
epriestley updated the task description for T13669: Discourage use of Mailgun as a mail provider.
Dec 2 2021, 10:42 PM · Guides, Mail
epriestley updated the task description for T13669: Discourage use of Mailgun as a mail provider.
Dec 2 2021, 10:39 PM · Guides, Mail
epriestley added a comment to T13037: An attacker gained staff access to Mailgun and was able to read customer API keys.

I'm satisfied that we aren't violating our commitment to our customers by continuing to use Mailgun as a service provider...

Dec 2 2021, 10:39 PM · Phacility, Security, Mail
epriestley created U49 Mailgun Discouraged.
Dec 2 2021, 10:34 PM
epriestley added a comment to T13669: Discourage use of Mailgun as a mail provider.

Purely venting, but the advanced version of "click here to schedule a mysterious meeting" is to outright lie -- pretending that you deeply respect the recipient's achievements -- before asking them to schedule a mysterious meeting.

Dec 2 2021, 10:30 PM · Guides, Mail
epriestley triaged T13669: Discourage use of Mailgun as a mail provider as Normal priority.
Dec 2 2021, 10:12 PM · Guides, Mail

Dec 1 2021

epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

While waiting to deploy db stuff, I was planning to look at pruning dead data out of S3 -- but, on closer examination, the total S3 bill is something like $1/day, so no priority on that whatsoever.

Dec 1 2021, 11:57 PM · Almanac, Infrastructure, Phacility
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

Piledriver also needs to be able to provision database hosts, but these are more-or-less a trivial subset of repository hosts.

Dec 1 2021, 11:47 PM · Almanac, Infrastructure, Phacility
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.
  • Make InstancesStateQuery use a dictionary when building the database ref information internally.
Dec 1 2021, 11:06 PM · Almanac, Infrastructure, Phacility
epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: Unknown Object (Differential Revision).
Dec 1 2021, 11:03 PM · Almanac, Infrastructure, Phacility
epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: Unknown Object (Differential Revision).
Dec 1 2021, 10:44 PM · Almanac, Infrastructure, Phacility
epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: Unknown Object (Differential Revision).
Dec 1 2021, 9:34 PM · Almanac, Infrastructure, Phacility
epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: Unknown Object (Differential Revision).
Dec 1 2021, 9:25 PM · Almanac, Infrastructure, Phacility
epriestley edited the content of Changelog.
Dec 1 2021, 9:23 PM
epriestley created an object: 2021 Week 49 (Early December).
Dec 1 2021, 9:21 PM
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

Piledriver also needs to be able to provision database hosts, but these are more-or-less a trivial subset of repository hosts.

Dec 1 2021, 8:44 PM · Almanac, Infrastructure, Phacility
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

I completed all the repository migrations over the weekend and seemingly haven't run into any issues.

Dec 1 2021, 8:41 PM · Almanac, Infrastructure, Phacility

Nov 22 2021

epriestley closed T13653: After an AWS event, Phacility hosts may come up with swap only partially configured as Resolved.

This appears resolved: the workflow now tests that /proc/meminfo reports an appropriate value for TotalSwap.

Nov 22 2021, 2:02 PM · Phacility
epriestley added a revision to T13653: After an AWS event, Phacility hosts may come up with swap only partially configured: Restricted Differential Revision.
Nov 22 2021, 1:30 PM · Phacility

Nov 21 2021

epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

Just for completeness, vault used to be an HAProxy host serving as an SSH load balancer, but this responsibility moved to lb001 once ELBs became able to listen on inbound port 22 and TCP forward, so there is no longer a vault class of machines.

Nov 21 2021, 3:55 PM · Almanac, Infrastructure, Phacility

Nov 20 2021

epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

The new provisioning process for repository shards is:

Nov 20 2021, 9:02 PM · Almanac, Infrastructure, Phacility