Page MenuHomePhabricator
Feed Advanced Search

Sep 7 2016

chad closed T11605: Add possibility to snooze tasks as Invalid.

Problem: Overwhelming lists of (assigned) tasks steal focus.

Sep 7 2016, 8:00 PM · Feature Request
bizrad6 added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

Confirmed by updating to the latest, thanks again!

Sep 7 2016, 7:30 PM · Restricted Project, Bug Report
bizrad6 added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

Awesome, thanks for the quick fix!

Sep 7 2016, 7:00 PM · Restricted Project, Bug Report
epriestley added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

I believe this is now fixed in HEAD of master. Let us know if you're still seeing issues.

Sep 7 2016, 6:35 PM · Restricted Project, Bug Report
epriestley closed T11604: Error adding URL to a JIRA issue the first time to Differential comment as Resolved by committing Restricted Diffusion Commit.
Sep 7 2016, 6:16 PM · Restricted Project, Bug Report
ftdysa added a comment to T11605: Add possibility to snooze tasks.

Also, if you just want to look at a subset of tasks you can always create a query panel using flags on your dashboard and flag the tasks you care about. I've been doing that lately and it feels pretty good to me.

Sep 7 2016, 6:01 PM · Feature Request
epriestley added a revision to T11604: Error adding URL to a JIRA issue the first time to Differential comment : Restricted Differential Revision.
Sep 7 2016, 5:51 PM · Restricted Project, Bug Report
avivey added a comment to T11605: Add possibility to snooze tasks.

Why are you trying to snooze a task? Why don't you just, you know, do the thing?

Sep 7 2016, 5:36 PM · Feature Request
caov297 added a comment to Q485: PhabricatorFileDataController class handRequest doesn't have valid viewer/user for CDN file request.

I was thinking of adding some code to phabricator to set the phusr cookie for alternate-file-domain (aws cloudfront) when a user login as well in order for me to track user download of software packages in the file application. What is the security risk involve in doing this? Is there a better way of capturing a userid when they download a file being served from a CDN?

Sep 7 2016, 5:32 PM
mna created T11605: Add possibility to snooze tasks.
Sep 7 2016, 5:22 PM · Feature Request
epriestley added a comment to T10961: JIRA instructions are a bit out of date with modern JIRA.

We also say "Only supports JIRA 6" but that means "JIRA 6 or newer", since JIRA 7 works fine.

Sep 7 2016, 5:07 PM · Auth, Documentation
bizrad6 added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

Sounds good, thanks!

Sep 7 2016, 4:45 PM · Restricted Project, Bug Report
epriestley added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

Let me take a shot at it locally first, I don't immediately see a real way that D16494 could have fixed this given your repro steps.

Sep 7 2016, 4:43 PM · Restricted Project, Bug Report
bizrad6 added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

Happy to bring those changes in and test it out. Also happy to test any patches if testing JIRA related stuff is a pain.

Sep 7 2016, 4:36 PM · Restricted Project, Bug Report
epriestley added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

(I'd be a little surprised if it was and it still merits a real fix even if it doesn't happen in practice anymore.)

Sep 7 2016, 4:34 PM · Restricted Project, Bug Report
epriestley added a comment to T11604: Error adding URL to a JIRA issue the first time to Differential comment .

There is a small possibility that this was "fixed" by D16494 on Sep 5.

Sep 7 2016, 4:34 PM · Restricted Project, Bug Report
bizrad6 created T11604: Error adding URL to a JIRA issue the first time to Differential comment .
Sep 7 2016, 4:23 PM · Restricted Project, Bug Report
epriestley closed T11583: When initializing a new database, just apply adjustments without prompting as Resolved by committing Restricted Diffusion Commit.
Sep 7 2016, 4:09 PM · NUX, Setup
epriestley added a comment to T11593: *.search Conduit API methods with invalid constraints silently ignore the constraints.

I believe all that stuff is fixed in HEAD of master, let us know if you're still seeing issues (other than text not being searchable: it isn't currently supported). Thanks for the report!

Sep 7 2016, 4:08 PM · Bug Report
epriestley closed T11593: *.search Conduit API methods with invalid constraints silently ignore the constraints as Resolved by committing Restricted Diffusion Commit.
Sep 7 2016, 4:08 PM · Bug Report
epriestley added a revision to T11583: When initializing a new database, just apply adjustments without prompting: Unknown Object (Differential Revision).
Sep 7 2016, 2:54 PM · NUX, Setup
MattSeen added a comment to T11566: Provide more complete guidance on using regular expressions in Herald.

Sorry for the late reply. What an incredibly well written and thoughtful response! Thanks!

Sep 7 2016, 2:47 PM · Herald, Documentation
epriestley added a comment to T11593: *.search Conduit API methods with invalid constraints silently ignore the constraints.
  • text does not support searching, and does not claim to support searching (e.g., is not listed on "Constraints"). The intent is to eventually expose fulltext/content search here rather than exact-match search.
  • We did not validate constraint keys, so it would appear that we might support searching on invalid constraints. D16507 fixes this: we now throw an explicit exception pointing at the error.
  • link does support searching, but did not handle query constraints correctly. D16508 fixes this, and it now should apply these constraints properly.
Sep 7 2016, 2:40 PM · Bug Report
epriestley added a revision to T11593: *.search Conduit API methods with invalid constraints silently ignore the constraints: Unknown Object (Differential Revision).
Sep 7 2016, 2:38 PM · Bug Report
epriestley added a revision to T11593: *.search Conduit API methods with invalid constraints silently ignore the constraints: Unknown Object (Differential Revision).
Sep 7 2016, 2:25 PM · Bug Report
akgood added a comment to T11601: Prevent users from editing their username / real name during self-service registration.

Thanks for the pointer!

Sep 7 2016, 2:22 PM · Feature Request
cxzzero added a comment to T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows.

Yes it is solved!

Sep 7 2016, 2:22 PM · Bug Report (Needs Information)
epriestley closed T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows as Resolved.

Presuming this is resolved, but let us know if you're still having troulbe.

Sep 7 2016, 2:14 PM · Bug Report (Needs Information)
epriestley closed T11601: Prevent users from editing their username / real name during self-service registration as Resolved.

Presuming this is resolved, let us know if that isn't the case.

Sep 7 2016, 2:14 PM · Feature Request
epriestley renamed T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows from arc diff crashes with exception to libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows.
Sep 7 2016, 2:07 PM · Bug Report (Needs Information)
epriestley added a comment to T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows.

I believe this is fixed in HEAD of master. Update libphutil (by running git pull in libphutil/) and let us know if you're still seeing issues?

Sep 7 2016, 2:07 PM · Bug Report (Needs Information)
epriestley closed T11592: `repository update` may be killed after timing out without annihilating `git fetch` subprocesses as Resolved by committing Restricted Diffusion Commit.
Sep 7 2016, 2:06 PM · Diffusion, Daemons
epriestley closed T11592: `repository update` may be killed after timing out without annihilating `git fetch` subprocesses, a subtask of T4551: consider allowing SIGTERM for ExecFuture timeout, as Resolved.
Sep 7 2016, 2:06 PM · libphutil
epriestley added a revision to T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows: Unknown Object (Differential Revision).
Sep 7 2016, 2:04 PM · Bug Report (Needs Information)
cxzzero added a comment to T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows.

Yes my client system is Windows, while server hosting Phabricator is CentOS

Sep 7 2016, 2:01 PM · Bug Report (Needs Information)
cxzzero added a comment to T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows.

No, I downloaded the non thread safe php version from official site.

Sep 7 2016, 2:00 PM · Bug Report (Needs Information)
epriestley merged task T11602: arc patch D1234 crashes with exception when D1234 does not exist into T8937: Unclear exception when patching non-existant revision.
Sep 7 2016, 1:59 PM · Bug Report
epriestley merged T11602: arc patch D1234 crashes with exception when D1234 does not exist into T8937: Unclear exception when patching non-existant revision.
Sep 7 2016, 1:59 PM · Arcanist
epriestley added a comment to T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows.

I think I broke this in D16504, I'll fix it shortly.

Sep 7 2016, 1:57 PM · Bug Report (Needs Information)
chad added a comment to T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows.

Is your system Windows?

Sep 7 2016, 1:53 PM · Bug Report (Needs Information)
chad added a comment to T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows.

Honestly never seen these functions not included with any PHP distribution.

Sep 7 2016, 1:52 PM · Bug Report (Needs Information)
chad added a comment to T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows.

Did you compile or build PHP yourself manually?

Sep 7 2016, 1:48 PM · Bug Report (Needs Information)
cxzzero added a comment to T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows.

PHP 5.6.13 (cli) (built: Sep 3 2015 15:14:39)

Sep 7 2016, 1:44 PM · Bug Report (Needs Information)
chad edited projects for T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows, added: Bug Report (Needs Information); removed Bug Report.
Sep 7 2016, 1:41 PM · Bug Report (Needs Information)
chad added a comment to T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows.

What version of PHP are you running?

Sep 7 2016, 1:41 PM · Bug Report (Needs Information)
cxzzero created T11603: libphutil briefly made unconditional calls to pcntl_signal(), fataling on Windows.
Sep 7 2016, 1:37 PM · Bug Report (Needs Information)
mna renamed T11602: arc patch D1234 crashes with exception when D1234 does not exist from arc patch D1234 crashes with exception to arc patch D1234 crashes with exception when D1234 does not exist.
Sep 7 2016, 1:14 PM · Bug Report
mna added a comment to T11602: arc patch D1234 crashes with exception when D1234 does not exist.

I just noticed that D229 is not actually a valid Differential Id.
It is the number of the associated Diff.

Sep 7 2016, 1:14 PM · Bug Report
mna created T11602: arc patch D1234 crashes with exception when D1234 does not exist.
Sep 7 2016, 12:23 PM · Bug Report
pouyana awarded T4558: Make Diviner useful for third-parties a Mountain of Wealth token.
Sep 7 2016, 10:25 AM · Diviner
epriestley closed T4551: consider allowing SIGTERM for ExecFuture timeout as Resolved.

Changes associated with T11592 probably fix this in practice. The new behavior is transparent: subprocesses get SIGTERM at the timeout, and SIGKILL a little while later if they fail to exit.

Sep 7 2016, 1:24 AM · libphutil
epriestley added a revision to T11592: `repository update` may be killed after timing out without annihilating `git fetch` subprocesses: Unknown Object (Differential Revision).
Sep 7 2016, 1:18 AM · Diffusion, Daemons
epriestley added a revision to T11592: `repository update` may be killed after timing out without annihilating `git fetch` subprocesses: Unknown Object (Differential Revision).
Sep 7 2016, 1:01 AM · Diffusion, Daemons

Sep 6 2016

epriestley added a comment to T11571: Consider benchmarking hardware during setup.

We can just query that as a setup check, although I don't recall too many issues with it recently.

Sep 6 2016, 11:28 PM · Setup
epriestley renamed T11593: *.search Conduit API methods with invalid constraints silently ignore the constraints from maniphest.search with link/text constraints return all tasks, instead of the ones that match to *.search Conduit API methods with invalid constraints silently ignore the constraints.
Sep 6 2016, 11:26 PM · Bug Report
epriestley added a comment to T11593: *.search Conduit API methods with invalid constraints silently ignore the constraints.

Oh, this isn't expected to work. These don't currently expose a constraint. You can find an exhaustive list of constraints in the "Custom Query Constraints" table on the API page, and no constraint will be listed for these fields.

Sep 6 2016, 11:25 PM · Bug Report
avivey added a comment to T11571: Consider benchmarking hardware during setup.

maybe also DB's max_connections?

Sep 6 2016, 11:24 PM · Setup
ReynoldsCahoon closed Q474: Can chatrooms be configured to send message upon RETURN press? as resolved.
Sep 6 2016, 10:24 PM · Conpherence
epriestley added a comment to T11601: Prevent users from editing their username / real name during self-service registration.

(The $profile object is a PhabricatorRegistrationProfile and has a few other methods available.)

Sep 6 2016, 10:07 PM · Feature Request
epriestley added a comment to T11601: Prevent users from editing their username / real name during self-service registration.

This is possible today, although only via the older events API:

Sep 6 2016, 10:05 PM · Feature Request
akgood created T11601: Prevent users from editing their username / real name during self-service registration.
Sep 6 2016, 9:34 PM · Feature Request
epriestley added a comment to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

I believe this is fixed in HEAD of master now. Let me know if things look good on your end and I'll cherry-pick the fixes to stable?

Sep 6 2016, 9:21 PM · Setup
epriestley closed T11596: Phacility export process removes data from S3 which may still be referenced as Resolved.

I cherry-picked those fixes to stable, created a test instance (test-on6dfrmgkt7t), uploaded a 100KB file which went to S3, exported the instance, and got a clean export with the file data retained on the instance.

Sep 6 2016, 8:59 PM · Files, Phacility
epriestley closed T11596: Phacility export process removes data from S3 which may still be referenced, a subtask of T7148: Allow users to export their data from Phacility, as Resolved.
Sep 6 2016, 8:59 PM · Phacility
epriestley added a revision to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages: Unknown Object (Differential Revision).
Sep 6 2016, 8:53 PM · Setup
epriestley added a revision to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages: Unknown Object (Differential Revision).
Sep 6 2016, 8:25 PM · Setup
epriestley added a revision to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages: Unknown Object (Differential Revision).
Sep 6 2016, 7:59 PM · Setup
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

To this use case more broadly, Spaces is the best tool we have today but may not be a perfect solution. From elsewhere, here's general thinking on this today (this was originally a response to a request about T8442):

Sep 6 2016, 7:39 PM · Feature Request
jsimon added a comment to T11597: Adding a user to multiple groups would save a lot of time.

We've iterated through a few versions of instruction lengths without much luck, and an older version of the form had a bit more text upfront but didn't seem to have any impact.

The most extreme version of this is documented in T11095, where a short-lived form only said "it costs $1,500 to submit this form" and the very first person to submit it didn't read that. See T11095#178732 for what that user saw and the task as a whole for what came of it. It's hard to imagine we could make the "root problems" documentation more concise than "Support requests are billed at $1,500/hr."

Sep 6 2016, 7:29 PM · Feature Request
epriestley added a revision to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages: Unknown Object (Differential Revision).
Sep 6 2016, 7:29 PM · Setup
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

We've iterated through a few versions of instruction lengths without much luck, and an older version of the form had a bit more text upfront but didn't seem to have any impact.

Sep 6 2016, 7:17 PM · Feature Request
chad added a comment to T11597: Adding a user to multiple groups would save a lot of time.

Thank you for the input, I think we still have room to improve things on our side, like you say - wall of text.

Sep 6 2016, 7:17 PM · Feature Request
jsimon added a comment to T11597: Adding a user to multiple groups would save a lot of time.

My goal is to fix this process so that we don't have to go through it over and over and over again.

The repeated callouts, giant text, etc., are because many, many users do not follow these instructions and we receive many feature requests like this: approximately one line of text asking for a very specific feature, which wastes our time (and the reporter's time!) and suggests that the author did not read any of the documents. This is worse for everyone than if we could get users to just read the documents -- we'd spend way less time on requests and users would get answers faster. Users who file reports like this are hurting the project and hurting themselves.

When we ask how we could fix things, no one claims they had a hard time finding the instructions. Everyone claims they read them and understood them, and everyone says they are clear after the fact. But I still waste a ton of time asking questions to figure out the root problem, essentially following the techniques and discussion already laid out in the documents, and no one has any feedback to improve the process.

One possible explanation is that a significant number of our users are basically lazy jerks who don't respect our time and are possibly even willing to lie about reading documentation to get a worse answer more slowly than if they'd followed the instructions. I don't like this explanation and I'd like to believe we just did a bad job with some of the documentation, but this scenario has played out so many times now without anyone being able to point at what we should improve that I'm having trouble coming up with other explanations.

The current state of affairs is also extremely negative for everyone. It's really frustrating for us, since it wastes a tremendous amount of our time. It's frustrating for users -- when I pointed you at the documentation, it seems like you felt like I'd just dismissed your problem. But we also can't spend two hours doing this kind of question-and-answer walkthrough with every user. We don't have the resources, and "free help with any question no matter how vague and time consuming" isn't a sustainable model.

Sep 6 2016, 7:12 PM · Feature Request
kristo.mario added a comment to T11597: Adding a user to multiple groups would save a lot of time.

My company uses Spaces for external companies and it's painless to manage permissions in that manner.

Sep 6 2016, 7:04 PM · Feature Request
epriestley closed T11405: Need to watch the project programmatically as Invalid.

We haven't received more information about this in more than a month.

Sep 6 2016, 6:50 PM · Feature Request (Needs Information), Conduit
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

My goal is to fix this process so that we don't have to go through it over and over and over again.

Sep 6 2016, 6:45 PM · Feature Request
jsimon added a comment to T11597: Adding a user to multiple groups would save a lot of time.

I suppose I could have read it more carefully but at this point I feel like your goal is to make sure I feel bad about it. Again, I'm sorry for wasting your time.

Sep 6 2016, 6:28 PM · Feature Request
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

Even if you don't make it to Describing Root Problems and miss the huge red header in Contributing Feature Requests, that document has a large amount of text with the same message:

Sep 6 2016, 6:24 PM · Feature Request
jsimon added a comment to T11597: Adding a user to multiple groups would save a lot of time.

Frankly, my biggest issue when people submit feature requests is all the chaff. But I see how you could want what you're after as far as requests go. I will admit that while I did read the first document and totally missed the second document on root problem description. Given its location in a giant red box, I'm not sure how that happened. I'm sorry for wasting your time.

Sep 6 2016, 6:12 PM · Feature Request
epriestley added a revision to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages: Unknown Object (Differential Revision).
Sep 6 2016, 6:11 PM · Setup
epriestley added a comment to T11589: Phabricator configuration with invalid MySQL credentials isn't getting to the help messages.

Here's my general plan of attack here:

Sep 6 2016, 6:06 PM · Setup
epriestley merged task T11598: "Plan changes" doesn't clear comments into T11114: Move Differential to EditEngine.
Sep 6 2016, 5:36 PM · Bug Report
epriestley merged T11598: "Plan changes" doesn't clear comments into T11114: Move Differential to EditEngine.
Sep 6 2016, 5:36 PM · Prioritized, Restricted Project, Infrastructure, EditEngine, Differential
epriestley added a comment to T11598: "Plan changes" doesn't clear comments.

This will be fixed when Differential moves to EditEngine, covered by T11114. I'm going to merge this there.

Sep 6 2016, 5:36 PM · Bug Report
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

Here's roughly the request we would have liked to see instead of the request you actually filed:

Sep 6 2016, 5:33 PM · Feature Request
• andypoorman added a comment to T8492: Add a lint wrapper for PHPMD.

I solved this for my purposes here. It might be a decent starting point for you: https://github.com/andypoorman/arcanist/commit/f1eb928c462029397fff9a1f1c42122a6d54bc9f

Sep 6 2016, 5:32 PM · Lint
jsimon added a comment to T11597: Adding a user to multiple groups would save a lot of time.

How common is it that a developer is only allowed to see company A, and not see company B? Is this common, or can most employees see all or almost all of the information about companies and you mostly want to prevent employees of company A from seeing information about company B and vice versa?

Sep 6 2016, 5:18 PM · Feature Request
jmharvey created T11598: "Plan changes" doesn't clear comments.
Sep 6 2016, 5:13 PM · Bug Report
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

How common is it that a developer is only allowed to see company A, and not see company B? Is this common, or can most employees see all or almost all of the information about companies and you mostly want to prevent employees of company A from seeing information about company B and vice versa?

Sep 6 2016, 4:54 PM · Feature Request
jsimon added a comment to T11597: Adding a user to multiple groups would save a lot of time.

Well, it sounds like what you're getting at is that we're using Phabricator incorrectly.

Sep 6 2016, 4:50 PM · Feature Request
epriestley added a comment to T11586: Display errors/nonprintable characters more clearly when warning users about invalid data inputs.

The goal is to provide an easy way for us to print messages like this:

Sep 6 2016, 4:39 PM · Contributor Onboarding
epriestley edited projects for T11586: Display errors/nonprintable characters more clearly when warning users about invalid data inputs, added: Contributor Onboarding; removed Bug Report.
Sep 6 2016, 4:30 PM · Contributor Onboarding
jonah214 added a comment to T7477: Handle inbound email with phabricator address in the CC.

Thanks; that does help (and also disappoint).

Sep 6 2016, 4:28 PM · llvm, Restricted Project, Restricted Project, Mail
chad added a comment to T7477: Handle inbound email with phabricator address in the CC.

@jonah214 If it helps, unlikely to happen in the next 6 months given current prioritization queue. We are actively looking to hire though to widen our engineering throughput.

Sep 6 2016, 4:27 PM · llvm, Restricted Project, Restricted Project, Mail
epriestley added a comment to T7477: Handle inbound email with phabricator address in the CC.

Sorry, we never have any idea. See Planning for discussion.

Sep 6 2016, 4:05 PM · llvm, Restricted Project, Restricted Project, Mail
jonah214 added a comment to T7477: Handle inbound email with phabricator address in the CC.

Is there any sense of when this might be worked on? We end up getting "Error Processing Mail (No Receivers)" due to Phabricator being in the CC a few times a week, and it's really annoying.

Sep 6 2016, 4:05 PM · llvm, Restricted Project, Restricted Project, Mail
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

Why shouldn't a developer be a member of a project they are working on?

Sep 6 2016, 4:02 PM · Feature Request
jsimon added a comment to T11597: Adding a user to multiple groups would save a lot of time.

Why shouldn't a developer be a member of a project they are working on? Even if a project is used as a security group for use in the Visible To or Editable By fields in a task or project there might be multiple security groups they need membership to.

Sep 6 2016, 3:59 PM · Feature Request
epriestley added a comment to T11597: Adding a user to multiple groups would save a lot of time.

They will be working on multiple projects.

Sep 6 2016, 3:54 PM · Feature Request
jsimon added a comment to T11597: Adding a user to multiple groups would save a lot of time.

They will be working on multiple projects.

Sep 6 2016, 3:53 PM · Feature Request