Page MenuHomePhabricator

Fixes T13026, Makes recurring event stubs inherit host's RSVP status
Needs RevisionPublic

Authored by lpriestley on Nov 28 2017, 9:01 PM.

Details

Summary

When an event is made recurring, the host's RSVP status should persist to future events

Test Plan

Create an event, make event recurring, navigate to future instance, observe that the RSVP status of the host is still "attending"

Diff Detail

Repository
rP Phabricator
Branch
calendarrecurringhoststatus
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 18887
Build 25464: Run Core Tests
Build 25463: arc lint + arc unit

Event Timeline

lpriestley created this revision.Nov 28 2017, 9:01 PM
lpriestley requested review of this revision.Nov 28 2017, 9:02 PM
epriestley requested changes to this revision.Dec 14 2017, 9:53 PM

I don't think this change is a net positive change without a more comprehensive fix for "Mark Me As Attending Only This Event" vs "Mark Me As Attending This And All Future Events".

Notably, this will cause any status -- including "Not Attending" -- to be inherited by stubs (which seems wrong), but only for the host (which seems arbitrary). It basically turns the host RSVP'ign into a sort of "This And All Future Events", but without notifying them. To the degree that other calendar software has similar behavior, I imagine it is "default the host to attending all events", which this mimics but differs significantly from.

Also, consider the case where the event host changes; it's surprising that their invite behavior is now different.

This revision now requires changes to proceed.Dec 14 2017, 9:53 PM