Paths

Table of Contentst

Differential D15699

Links on badge card should be accessible
ClosedPublic
Actions

Authored by lpriestley on Apr 13 2016, 4:32 PM.

Tags

None

Referenced Files

	F18780761: D15699.id37830.diff
	Sun, Oct 12, 7:38 PM

	F18762800: D15699.id37824.diff
	Mon, Oct 6, 8:41 PM

	F18729915: D15699.diff
	Tue, Sep 30, 11:59 AM

	F18682667: D15699.diff
	Fri, Sep 26, 6:18 AM

	F18648691: D15699.diff
	Sep 20 2025, 4:47 PM

	F18648662: D15699.diff
	Sep 20 2025, 4:39 PM

	F18648658: D15699.diff
	Sep 20 2025, 4:38 PM

	F18648629: D15699.diff
	Sep 20 2025, 4:33 PM

Subscribers

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T10710: Badge cards that use `PHUIBadgeView` should not flip the card if a link on the card is clicked

Commits

rP899856a1d41b: Links on badge card should be accessible

Summary

Test Plan

Open user profile with badge, flip badge card, open awarder link.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 37824.Apr 13 2016, 4:32 PM

lpriestley retitled this revision from to Links on badge card should be accessible.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T10710: Badge cards that use `PHUIBadgeView` should not flip the card if a link on the card is clicked.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 13 2016, 4:32 PM

Herald added a subscriber: Korvin. · View Herald Transcript

Can you update the color of the link as well in CSS? it should be {$darkbluetext}.

Correct way to specify the link color for badge view?

Herald added a reviewer: chad. · View Herald TranscriptApr 13 2016, 6:31 PM

epriestley accepted this revision.Apr 13 2016, 6:40 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/view/page/PhabricatorStandardPageView.php
251 ↗	(On Diff #37828)	This should still be `toggle-class` -- otherwise, you'll break existing `toggle-class` use sites, by never initializing that behavior.
src/view/phui/PHUIBadgeView.php
72	There needs to be an `initBehavior('badge-view')` in here somewhere.

This revision is now accepted and ready to land.Apr 13 2016, 6:40 PM

Fixing where new behavior is initialized

Herald edited edge metadata. · View Herald TranscriptApr 13 2016, 6:48 PM

Closed by commit rP899856a1d41b: Links on badge card should be accessible (authored by lpriestley, committed by lpriestley). · Explain WhyApr 15 2016, 2:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

27 lines

src/

view/

phui/

PHUIBadgeView.php

4 lines

webroot/

rsrc/

css/

phui/

4 lines

js/

core/

behavior-badge-view.js

41 lines

behavior-toggle-class.js

4 lines

Diff 37882

resources/celerity/map.php

Loading...

src/view/phui/PHUIBadgeView.php

Loading...

webroot/rsrc/css/phui/phui-badge.css

Loading...

webroot/rsrc/js/core/behavior-badge-view.js

Loading...

webroot/rsrc/js/core/behavior-toggle-class.js

Loading...