Page MenuHomePhabricator

Links on badge card should be accessible
ClosedPublic

Authored by lpriestley on Apr 13 2016, 4:32 PM.

Details

Summary

Ref T10710

Test Plan

Open user profile with badge, flip badge card, open awarder link.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Links on badge card should be accessible.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.

Can you update the color of the link as well in CSS? it should be {$darkbluetext}.

lpriestley edited edge metadata.

Correct way to specify the link color for badge view?

epriestley edited edge metadata.
epriestley added inline comments.
src/view/page/PhabricatorStandardPageView.php
251 ↗(On Diff #37828)

This should still be toggle-class -- otherwise, you'll break existing toggle-class use sites, by never initializing that behavior.

src/view/phui/PHUIBadgeView.php
72

There needs to be an initBehavior('badge-view') in here somewhere.

This revision is now accepted and ready to land.Apr 13 2016, 6:40 PM
lpriestley marked 2 inline comments as done.
lpriestley edited edge metadata.

Fixing where new behavior is initialized

This revision was automatically updated to reflect the committed changes.