Page MenuHomePhabricator
Differential D15725

Time controls should format end date value correctly (not 5:0 PM)
ClosedPublic
Actions

Authored by lpriestley on Apr 15 2016, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 22, 11:14 PM
Unknown Object (File)
Tue, Jan 21, 12:55 PM
Unknown Object (File)
Tue, Jan 21, 10:20 AM
Unknown Object (File)
Thu, Jan 16, 11:27 PM
Unknown Object (File)
Thu, Jan 16, 4:50 AM
Unknown Object (File)
Wed, Jan 15, 12:23 PM
Unknown Object (File)
Sat, Jan 11, 4:38 PM
Unknown Object (File)
Sun, Jan 5, 4:55 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9296: Default "one hour jump" logic not formatted correctly
Commits
rP42a877622859: Time controls should format end date value correctly (not 5:0 PM)
Summary

Fixes T9296

Test Plan

Create an event, change start time to 3PM, end value should update to 4:00 PM, not 4:0 PM

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 37892.Apr 15 2016, 7:11 PM
lpriestley retitled this revision from to Time controls should format end date value correctly (not 5:0 PM).
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added reviewers: epriestley, chad.
lpriestley added a task: T9296: Default "one hour jump" logic not formatted correctly.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 15 2016, 7:11 PM
Herald added a subscriber: Korvin. · View Herald Transcript
lpriestley updated this revision to Diff 37893.Apr 15 2016, 7:12 PM
lpriestley edited edge metadata.

oops, wrong direction

epriestley accepted this revision.Apr 15 2016, 7:15 PM
epriestley edited edge metadata.

Run bin/celerity map to clear that test issue.

webroot/rsrc/js/core/behavior-time-typeahead.js
139–142

You shouldn't need the end_minutes === 0 part I think since 0 < 9?

This revision is now accepted and ready to land.Apr 15 2016, 7:15 PM
lpriestley added inline comments.Apr 15 2016, 7:17 PM
webroot/rsrc/js/core/behavior-time-typeahead.js
139–142

Haha yeah I got a little too excited about finding the problem

lpriestley updated this revision to Diff 37894.Apr 15 2016, 7:17 PM
lpriestley edited edge metadata.

celery sticks

Closed by commit rP42a877622859: Time controls should format end date value correctly (not 5:0 PM) (authored by lpriestley, committed by lpriestley). · Explain WhyApr 15 2016, 7:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
20 lines
webroot/
rsrc/
js/
core/
5 lines

Diff 37895

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/core/behavior-time-typeahead.js

Loading...
Phabricator · Built by Phacility