Page MenuHomePhabricator
Feed Advanced Search

Nov 13 2019

epriestley closed T13456: Surface changes to the text in "Text" dashboard panels as a Remarkup edit (so files link, etc) as Resolved by committing rPe86aae99de0b: Surface edits to "Text" panels on dashboards as remarkup edits.
Nov 13 2019, 6:35 PM · Dashboards, Remarkup
epriestley added a revision to T13456: Surface changes to the text in "Text" dashboard panels as a Remarkup edit (so files link, etc): D20906: Surface edits to "Text" panels on dashboards as remarkup edits.
Nov 13 2019, 6:32 PM · Dashboards, Remarkup
epriestley triaged T13456: Surface changes to the text in "Text" dashboard panels as a Remarkup edit (so files link, etc) as Low priority.
Nov 13 2019, 6:31 PM · Dashboards, Remarkup

Nov 9 2019

epriestley closed T13443: Creating a dashboard query panel with the type "Differential Changesets" breaks the dashboard editor as Resolved by committing rP72f82abe0723: Improve recovery from panel action rendering exceptions, and mark "Changeset"….
Nov 9 2019, 1:15 AM · Dashboards
epriestley added a revision to T13443: Creating a dashboard query panel with the type "Differential Changesets" breaks the dashboard editor: D20902: Improve recovery from panel action rendering exceptions, and mark "Changeset" queries as not suitable for panel generation.
Nov 9 2019, 1:12 AM · Dashboards
epriestley claimed T13443: Creating a dashboard query panel with the type "Differential Changesets" breaks the dashboard editor.
Nov 9 2019, 1:09 AM · Dashboards

Aug 15 2019

epriestley closed T13379: Query panels executing bucketed queries with limits have unclear behavior as Wontfix.

Actually, since the modern behavior is reasonable by default (the "Limit" field is not required, and defaults to empty, and the panel works properly if "Limit" is left blank), users have to explicitly set a limit to get any unintuitive behavior here. If they do, they still get a "View All Results" hint.

Aug 15 2019, 7:47 PM · Dashboards
epriestley added a comment to T13379: Query panels executing bucketed queries with limits have unclear behavior.

The bucket limit is currently implemented like this:

Aug 15 2019, 7:43 PM · Dashboards
epriestley triaged T13379: Query panels executing bucketed queries with limits have unclear behavior as Low priority.
Aug 15 2019, 7:21 PM · Dashboards

May 17 2019

epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
May 17 2019, 2:43 PM · Dashboards
epriestley added a revision to T8033: Inform editor when panels have more restrictive policy than dashboard: D20376: On Dashboards, distinguish between invalid panels and restricted panels.
May 17 2019, 2:36 PM · Dashboards

May 1 2019

epriestley closed T7216: Make it easier to update the ApplicationSearch saved query used by a dashboard panel as Resolved by committing rP9d716379a3f1: Add a "Customize Query" action to query panels to make it easier to make minor….
May 1 2019, 6:01 PM · Dashboards

Apr 30 2019

epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20484: Remove obsolete Dashboard panel methods with no callsites.
Apr 30 2019, 3:34 PM · Dashboards

Apr 25 2019

epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20476: Really fix movable panels inside tab panels by changing the JX.Request serializer.
Apr 25 2019, 7:04 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20475: Add "Move Left" and "Move Right" to dashboard tab panels.
Apr 25 2019, 6:39 PM · Dashboards
epriestley added a revision to T7216: Make it easier to update the ApplicationSearch saved query used by a dashboard panel: D20474: Add a "Customize Query" action to query panels to make it easier to make minor query adjustments.
Apr 25 2019, 6:05 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20474: Add a "Customize Query" action to query panels to make it easier to make minor query adjustments.
Apr 25 2019, 6:05 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20473: Fix an issue where editing a dashboard panel from a dashboard could duplicate the panel.
Apr 25 2019, 5:38 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20472: Restore "Limit" to dashboard Query panels.
Apr 25 2019, 5:34 PM · Dashboards

Apr 15 2019

epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 15 2019, 6:37 PM · Dashboards

Apr 13 2019

epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20415: Reduce drag-and-drop jank on dashboards.
Apr 13 2019, 12:20 AM · Dashboards

Apr 12 2019

epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20414: Fix the "Add Query to Dashboard..." flow from "Use Results" on search result pages.
Apr 12 2019, 11:48 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 12 2019, 11:48 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20412: Reindex dashboards and panels (allow migrations to queue a job to queue other indexing jobs).
Apr 12 2019, 9:27 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 12 2019, 8:17 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 12 2019, 8:16 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 12 2019, 8:13 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20411: Update search indexes for Dashboards and Panels to Ferret, plus various minor fixes.
Apr 12 2019, 8:06 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20410: Remove legacy "DashboardInstall" table.
Apr 12 2019, 7:24 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20409: Make "Move Panel" on dashboards use the new storage and transactions.
Apr 12 2019, 7:09 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20408: Update "add panel" and "remove panel" Dashboard flows to the new panel storage format.
Apr 12 2019, 6:29 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 12 2019, 5:45 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20407: Convert dashboard read/display pathways to the new panel storage format.
Apr 12 2019, 4:08 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 12 2019, 4:01 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20406: Modularize dashboard layout modes (one column, two columns, etc).
Apr 12 2019, 3:43 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20405: Convert dashboard panel storage to a format which can handle duplicates.
Apr 12 2019, 3:10 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 12 2019, 1:26 PM · Dashboards
epriestley closed T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards." as Resolved by committing rP51f2ed498dbf: On panel pages, show where panels are used.
Apr 12 2019, 1:14 PM · Dashboards
epriestley closed T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.", a subtask of T13272: Remove the hard-coded homepage, and other Dashboards improvements, as Resolved.
Apr 12 2019, 1:14 PM · Dashboards

Apr 11 2019

epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20403: Move Dashboards main edit flow to EditEngine.
Apr 11 2019, 10:46 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 11 2019, 10:44 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20402: Modularize Dashboard transactions.
Apr 11 2019, 9:01 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 11 2019, 7:25 PM · Dashboards
epriestley added a revision to T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.": D20399: On panel pages, show where panels are used.
Apr 11 2019, 7:02 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20399: On panel pages, show where panels are used.
Apr 11 2019, 7:02 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 11 2019, 6:44 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20398: Index and surface usage sites for Dashboards.
Apr 11 2019, 6:10 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 11 2019, 4:33 PM · Dashboards
epriestley closed T9903: Header buttons on dashboard panels are lost when panels are embedded in a tab panel as Wontfix.

I'm just going to mark this as "Wontfix", since:

Apr 11 2019, 4:31 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20397: When editing a tab panel from a dashboard, redirect back to the dashboard.
Apr 11 2019, 4:27 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20396: On Dashboard tab panels in edit mode, make the "Tab Name" and the "Dropdown Edit Caret" into different links.
Apr 11 2019, 3:06 PM · Dashboards
epriestley closed T13275: Build Portals: a standalone menu page / dashboard of dashboards, a subtask of T13083: Plans: Portals and Facts, as Resolved.
Apr 11 2019, 3:00 PM · Plans, Facts, Dashboards
epriestley closed T13275: Build Portals: a standalone menu page / dashboard of dashboards as Resolved.

These work now. If they see use, we can build them out in greater detail.

Apr 11 2019, 3:00 PM · Dashboards

Apr 10 2019

epriestley added a revision to T13275: Build Portals: a standalone menu page / dashboard of dashboards: D20389: Make Portals indexable with Ferret.
Apr 10 2019, 6:09 PM · Dashboards
epriestley closed T8033: Inform editor when panels have more restrictive policy than dashboard as Wontfix.

D20377 initially added the warning this task originally suggests, but we weren't really thrilled about it so it eventually landed as some minor cleanup with no actual new warning.

Apr 10 2019, 4:52 PM · Dashboards
epriestley closed T8033: Inform editor when panels have more restrictive policy than dashboard, a subtask of T13272: Remove the hard-coded homepage, and other Dashboards improvements, as Wontfix.
Apr 10 2019, 4:52 PM · Dashboards
epriestley added a comment to T12363: Configuration of "Tab Panel" is lost when 1st tab has no panel assigned.

I marked this as resolved in D20384, since that rewrites this interface and solves this particular issue. The new UI is still fairly rough (thus "v1 Major Jank Edition") and has some new replacement problems, but see T13272 for followups.

Apr 10 2019, 4:45 PM · Dashboards, Bug Report
epriestley closed T12363: Configuration of "Tab Panel" is lost when 1st tab has no panel assigned as Resolved by committing rPa35fda2019bb: Rebuild Dashboards on EditEngine: v1 Major Jank Edition.
Apr 10 2019, 3:59 PM · Dashboards, Bug Report

Apr 9 2019

epriestley added a revision to T13275: Build Portals: a standalone menu page / dashboard of dashboards: D20385: Fix some overlooked profile menu construction callsites.
Apr 9 2019, 9:24 PM · Dashboards
epriestley added a revision to T12363: Configuration of "Tab Panel" is lost when 1st tab has no panel assigned: D20384: Rebuild Dashboards on EditEngine: v1 Major Jank Edition.
Apr 9 2019, 8:02 PM · Dashboards, Bug Report
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20384: Rebuild Dashboards on EditEngine: v1 Major Jank Edition.
Apr 9 2019, 8:02 PM · Dashboards

Apr 8 2019

epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20383: When a dropdown menu would render in a way that hides it offscreen, try a different alignment.
Apr 8 2019, 5:31 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20382: Rebuild query panels on top of EditEngine.
Apr 8 2019, 5:12 PM · Dashboards
epriestley closed T6444: When laying out dashboards, provide more options and a better (visual) selection control as Wontfix.

This might be nice to have some day, but we don't really have open requests for it and I don't have any particular plans to pursue it. The existing set of options seem reasonably sufficient and clear as-is.

Apr 8 2019, 5:09 PM · Dashboards
epriestley updated the task description for T13275: Build Portals: a standalone menu page / dashboard of dashboards.
Apr 8 2019, 5:08 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 8 2019, 5:07 PM · Dashboards

Apr 3 2019

epriestley added a revision to T8033: Inform editor when panels have more restrictive policy than dashboard: D20377: When a dashboard has inconsistent panel policies: keep doing nothing.
Apr 3 2019, 4:26 PM · Dashboards
epriestley added a parent task for T8033: Inform editor when panels have more restrictive policy than dashboard: T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 3 2019, 2:09 PM · Dashboards
epriestley added a parent task for T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.": T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 3 2019, 2:09 PM · Dashboards
epriestley added subtasks for T13272: Remove the hard-coded homepage, and other Dashboards improvements: T8033: Inform editor when panels have more restrictive policy than dashboard, T6018: Panels used by Tab panels appear as "This panel does not appear on any dashboards.".
Apr 3 2019, 2:09 PM · Dashboards

Apr 2 2019

epriestley closed T12098: Create Revision from FavoritesMenuItem doesn't work as Resolved by committing rPc9d3fb2ac5b6: Fix the incorrect link target for "Create Revision" as a Menu Item.
Apr 2 2019, 10:22 PM · Dashboards, Differential
epriestley closed T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out as Resolved by committing rPdfe47157d322: When picking a default menu item to render, don't pick disabled items.
Apr 2 2019, 10:21 PM · Policy, Dashboards, Bug Report
epriestley closed T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one as Resolved by committing rP36a8b4ea1796: When a ProfileMenu has a link item that adds URI parameters, highlight it when….
Apr 2 2019, 9:45 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20374: Make "Favorites" work more like other customizable menus.
Apr 2 2019, 8:55 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 2 2019, 8:22 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20373: Make the Dashboard dropshadow a little lighter and turn panel management into a menu.
Apr 2 2019, 7:41 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20372: Use EditEngine, not CustomFields, to define Dashboard Panel edit behavior.
Apr 2 2019, 6:59 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20371: Mostly replace the old panel "Edit" controller with the new "Editpro" controller.
Apr 2 2019, 6:00 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20370: Modularize Dashboard Panel transactionns.
Apr 2 2019, 5:00 PM · Dashboards
epriestley added a comment to T13272: Remove the hard-coded homepage, and other Dashboards improvements.

Panel type selection should be a modern "clickable" menu.

Apr 2 2019, 4:49 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20369: Move Dashboard panel controllers into a "panel/" subdirectory.
Apr 2 2019, 4:17 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20368: Put "workflow" on Dashboard edit links when they're disabled.
Apr 2 2019, 4:12 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 2 2019, 4:09 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20367: Remove the dashboard "template" workflow.
Apr 2 2019, 4:06 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 2 2019, 2:42 PM · Dashboards
epriestley updated the task description for T13272: Remove the hard-coded homepage, and other Dashboards improvements.
Apr 2 2019, 12:52 PM · Dashboards

Apr 1 2019

epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20364: Make the "Install Dashboard" flow smoother.
Apr 1 2019, 8:10 PM · Dashboards
epriestley added a revision to T13272: Remove the hard-coded homepage, and other Dashboards improvements: D20362: Combine the "View", "Arrange", and "Manage" modes of Dashboards into a single mode.
Apr 1 2019, 4:25 PM · Dashboards
epriestley added a comment to T13272: Remove the hard-coded homepage, and other Dashboards improvements.

Currently, Dashboards have a "View" mode, an "Arrange" mode, and a "Manage" mode.

Apr 1 2019, 3:23 PM · Dashboards
epriestley added a comment to T13272: Remove the hard-coded homepage, and other Dashboards improvements.

T8033 - I'm not really sure what's left here...

Apr 1 2019, 3:15 PM · Dashboards
epriestley added a comment to T13272: Remove the hard-coded homepage, and other Dashboards improvements.

The remaining bugs I want to fix here are:

Apr 1 2019, 3:07 PM · Dashboards

Mar 31 2019

epriestley moved T6444: When laying out dashboards, provide more options and a better (visual) selection control from Backlog to Next on the Dashboards board.
Mar 31 2019, 10:05 PM · Dashboards
epriestley closed T9501: Need a dashboard that can used by members of differing Space/Projects as Resolved.

I'm going to claim this is possibly "resolved" by fixes in T13275/T12871, especially D20359. Once those land, you can put a list of dashboards in the menu and users will default to the first one they can see. The others will be marked as "Restricted Dashboard".

Mar 31 2019, 10:05 PM · Dashboards
epriestley moved T12363: Configuration of "Tab Panel" is lost when 1st tab has no panel assigned from Backlog to Next on the Dashboards board.
Mar 31 2019, 10:00 PM · Dashboards, Bug Report
epriestley moved T7216: Make it easier to update the ApplicationSearch saved query used by a dashboard panel from Backlog to Next on the Dashboards board.
Mar 31 2019, 10:00 PM · Dashboards
epriestley moved T12871: Setting a restricted dashboard as the topmost item in the global menu can lock some users out from Backlog to Next on the Dashboards board.
Mar 31 2019, 10:00 PM · Policy, Dashboards, Bug Report
epriestley moved T13083: Plans: Portals and Facts from Backlog to Next on the Dashboards board.
Mar 31 2019, 10:00 PM · Plans, Facts, Dashboards
epriestley moved T12098: Create Revision from FavoritesMenuItem doesn't work from Backlog to Next on the Dashboards board.
Mar 31 2019, 10:00 PM · Dashboards, Differential
epriestley closed T12423: Bring MenuItem customization options to User Profiles as Wontfix.

I think this currently lacks compelling motivations and isn't particularly actionable, so I don't plan to pursue it until new use cases arise. (It's also fully modular already.)

Mar 31 2019, 10:00 PM · Dashboards, Restricted Project, Profile
epriestley moved T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one from Backlog to Next on the Dashboards board.
Mar 31 2019, 9:56 PM · Dashboards