See also T6445 (SVG files) and T5258 (additional legacy cruft).

Resolved enough.

The system described in this task became "ModularTransactions", which feel like they're in a good place.

This is an opportunity to earn valuable contributor points and explore the dark corners of the codebase. Spooky!

This will "help" you "become more familiar with Phabricator's codebase".

I think most of these have been converted now, and the remaining stragglers are getting fixed up alongside other changes (EditEngine, third-generation APIs, etc).

I'm just going to close this since we've converted most of the Query classes by now and are fixing the remaining ones as adjacent work happens. These changes were just minor improvements to code clarity and there's no particular urgency to fully modernizing things, nor do we get to delete a bunch of code once we're done or reduce maintenance costs in a global way or anything like that.

When we make a hire we can make them do this "to become more familiar with Phabricator's codebase".

I think we broke plain-text emails here:

(Just bookkeeping; there's no external priority on this.)

I spent a couple hours on this last night and a couple hours this morning and I think I have Paste pretty much converted, so things look promising. I'm going to hold this until after the release cut, but expect to put Calendar on top of it and whatever else converts in the future.

I'm leaning toward exploring this in the near term. We have four applications which may convert soon:

Oh, I was thinking this needed a whole pile of work (like, all of T9372) but I don't think it actually does. I'll take a look.

@epriestley not sure if you saw this, but all apps installed by default on the sidenav have a reasonable blank state except for Differential. Not sure how much work there is to modernize RevisionQuery there.

But it's the last "application blank state" on a Phacility instance.

DifferentialRevisionQuery looks scary to modernize.

Tech changes out of T9132 (see also T9905) put this on a relatively short timetable and this stuff is no longer active on the major edit workflows so I'm going to land T9860. We probably won't cut a stable this week, and will continue issuing guidance on upgrading smoothly through these changes.

Cool, let us know if you run into trouble. I think it should be pretty easy to port any existing code which does generally transaction-like things, but might have missed something.

Makes sense. Thank you for clarification.

I think we can do this gradually by: