Page MenuHomePhabricator
Feed Advanced Search

Feb 8 2018

epriestley closed T12689: Mail is still received after resigning from a revision as Resolved by committing Restricted Diffusion Commit.
Feb 8 2018, 2:29 PM · Mail, Differential, Bug Report
epriestley closed T4776: Notify users when someone takes an action that takes them off an object's recipient list as Resolved by committing Restricted Diffusion Commit.
Feb 8 2018, 2:28 PM · Mail, Restricted Project, Transactions
epriestley closed T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place as Resolved by committing Restricted Diffusion Commit.
Feb 8 2018, 2:26 PM · Mail, Bug Report
epriestley updated the task description for T13053: Plans: Mail Tags and Failover.
Feb 8 2018, 2:01 PM · Plans, Must Encrypt Mail, Mail
epriestley updated the task description for T13053: Plans: Mail Tags and Failover.
Feb 8 2018, 1:48 PM · Plans, Must Encrypt Mail, Mail

Feb 7 2018

epriestley added a revision to T13063: Maybe render all text with IMPRESSIVE illuminated drop caps: Restricted Differential Revision.
Feb 7 2018, 6:53 PM · Remarkup
epriestley added a revision to T12644: Emoji autocomplete ordering doesn't follow unicode standards: Restricted Differential Revision.
Feb 7 2018, 6:53 PM · Remarkup, Bug Report
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 7 2018, 5:42 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13063: Maybe render all text with IMPRESSIVE illuminated drop caps.

As it turns out, I wrote a bit of {icon ... size=72} yesterday but ran into a related issue: it's hard for us to tell if the X in {icon X} is a single character or not.

Feb 7 2018, 5:37 PM · Remarkup
epriestley added a revision to T12689: Mail is still received after resigning from a revision: Unknown Object (Differential Revision).
Feb 7 2018, 4:08 PM · Mail, Differential, Bug Report
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 7 2018, 4:08 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

See PHI178 and PHI126. See T12689. When users resign from a revision, they should not receive mail about it even if they're a member of a non-resigned package or project. This requires propagating mail recipients deeper into the stack, and retaining richer recipient information. Subscriptions should be upgraded to support a stronger "unsubscribe" which can get you out of indirect subscriptions via projects/packages/etc. These probably mostly go down the same pathway.

Feb 7 2018, 2:31 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T4776: Notify users when someone takes an action that takes them off an object's recipient list: Unknown Object (Differential Revision).
Feb 7 2018, 2:11 PM · Mail, Restricted Project, Transactions
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 7 2018, 2:11 PM · Plans, Must Encrypt Mail, Mail
epriestley triaged T13066: Refine inbound mail error behaviors, distinguishing between actual mail sender and acting-as sender as Wishlist priority.
Feb 7 2018, 1:35 PM · Mail
epriestley added a revision to T12491: Error reply emails which are generated before identifying the sender should no longer be sent, now that the "always require verification" rule is in place: Unknown Object (Differential Revision).
Feb 7 2018, 1:18 PM · Mail, Bug Report
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 7 2018, 1:18 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Restricted Differential Revision.
Feb 7 2018, 1:02 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 7 2018, 12:09 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 7 2018, 12:00 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 7 2018, 11:52 AM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13065: Move storage for `mailKey` to the Mail application.

If D19012/D19013 turn out badly this table should be <objectPHID, mailKey, firstSubjectWeSentMailWith> so there's some vague argument for waiting until those are in the wild for a little bit or naming the table in a more generic way (MailObjectMetadata instead of MailObjectKey).

Feb 7 2018, 11:47 AM · Mail
epriestley triaged T13065: Move storage for `mailKey` to the Mail application as Low priority.
Feb 7 2018, 11:42 AM · Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 7 2018, 11:35 AM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 7 2018, 11:17 AM · Plans, Must Encrypt Mail, Mail
epriestley updated the task description for T13053: Plans: Mail Tags and Failover.
Feb 7 2018, 11:00 AM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T12907: Unable to download large files through alternative file domain: Unknown Object (Differential Revision).
Feb 7 2018, 12:14 AM · Bug Report

Feb 6 2018

epriestley closed T13058: Indicate that the "upload file" modal dialog is doing something when uploading large files as Resolved.

Presuming this is a version issue or evil spirits or something until some contrary evidence surfaces.

Feb 6 2018, 9:08 PM
epriestley triaged T13064: `arc patch` can fail when a non-UTF8 file is detected as binary and moved (?) as Normal priority.
Feb 6 2018, 7:36 PM · Arcanist, Differential
epriestley added a comment to T13063: Maybe render all text with IMPRESSIVE illuminated drop caps.

Some other possibilities:

Feb 6 2018, 7:00 PM · Remarkup
epriestley added a comment to T13063: Maybe render all text with IMPRESSIVE illuminated drop caps.

It's a real tragedy. The biggest header is definitely unacceptable for huge emoji.

Feb 6 2018, 6:52 PM · Remarkup
epriestley added a comment to T13063: Maybe render all text with IMPRESSIVE illuminated drop caps.

Yeah, the only reason I pursued this was for giant emoji. I was just going to do {huge 🐱} or something first, but then I figured {drop-cap 🐱} was a little more defensible as a general feature while still solving the huge emoji problem.

Feb 6 2018, 6:48 PM · Remarkup
epriestley added a member for Community: reed.
Feb 6 2018, 6:26 PM
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 6 2018, 5:44 PM · Phacility, Mail
epriestley updated the task description for T12677: Support multiple mail delivery services for automatic failover.
Feb 6 2018, 5:21 PM · Phacility, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 6 2018, 5:17 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 6 2018, 4:43 PM · Phacility, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 6 2018, 4:43 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 6 2018, 4:16 PM · Phacility, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 6 2018, 4:16 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 6 2018, 2:52 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 6 2018, 2:52 PM · Phacility, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 6 2018, 2:23 PM · Phacility, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 6 2018, 2:23 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 6 2018, 2:06 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 6 2018, 2:06 PM · Phacility, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 6 2018, 1:09 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 6 2018, 1:09 PM · Phacility, Mail
epriestley added a revision to T12101: Phabricator PHP 7 Compatibility: Unknown Object (Differential Revision).
Feb 6 2018, 1:00 PM · Infrastructure, Guides
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 6 2018, 12:34 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 6 2018, 12:19 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13062: Trying to manage anything in Gsuite is kind of not great?.

I'd either want to pay some service to deal with this or run an open source server that I was confident it was possible to fix, but one option is definitely to run Postfix/Dovecot/Exim/whatever the kids use these days.

Feb 6 2018, 11:58 AM · Phacility, Ops
avivey awarded T13063: Maybe render all text with IMPRESSIVE illuminated drop caps a Manufacturing Defect? token.
Feb 6 2018, 1:49 AM · Remarkup

Feb 5 2018

epriestley added a comment to T13053: Plans: Mail Tags and Failover.

The "From" address should also probably be anonymized for flagged mail.

Feb 5 2018, 11:59 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

Who knows what the Bad People would have one if they'd intercepted it!

Feb 5 2018, 11:39 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

When an object is updated via an "inverse edge" change (normally: when it is mentioned, or when another object is linked to it) we currently do not fire Herald rules. The corresponding block in the code has this comment:

Feb 5 2018, 11:38 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

Hrrrm...

Feb 5 2018, 11:33 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T12677: Support multiple mail delivery services for automatic failover: Unknown Object (Differential Revision).
Feb 5 2018, 10:44 PM · Phacility, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 5 2018, 10:44 PM · Plans, Must Encrypt Mail, Mail
epriestley closed T13061: Explain more clearly that "arc lint --everything" only lints stuff tracked by the VCS as Resolved by committing Restricted Diffusion Commit.
Feb 5 2018, 8:26 PM · Documentation, Arcanist
epriestley closed T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails as Resolved by committing Restricted Diffusion Commit.
Feb 5 2018, 8:23 PM · Diffusion
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 5 2018, 8:06 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 5 2018, 7:23 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 5 2018, 7:03 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 5 2018, 6:40 PM · Plans, Must Encrypt Mail, Mail
epriestley renamed T13063: Maybe render all text with IMPRESSIVE illuminated drop caps from Maybe render all text with illuminated drop caps to Maybe render all text with IMPRESSIVE illuminated drop caps.
Feb 5 2018, 6:23 PM · Remarkup
epriestley triaged T13063: Maybe render all text with IMPRESSIVE illuminated drop caps as Wishlist priority.
Feb 5 2018, 6:23 PM · Remarkup
epriestley added a comment to T13062: Trying to manage anything in Gsuite is kind of not great?.

🎉🎉🎉 I RECEIVED AN EMAIL AND CLICKED A LINK CONTAINED INSIDE IT 🎉🎉🎉

Feb 5 2018, 4:21 PM · Phacility, Ops
epriestley added a comment to T13062: Trying to manage anything in Gsuite is kind of not great?.

Ah, it looks like Google Groups spam filtered some of the Twitter verification mail!

Feb 5 2018, 4:18 PM · Phacility, Ops
epriestley added a comment to T13062: Trying to manage anything in Gsuite is kind of not great?.

Some of this seems to be that messages sent from my @phacility.com address are sometimes eaten entirely (?) or just not delivered to me (?), presumably because I'm a recipient. I still haven't been able to get the confirmation link from Twitter, but it's possible that's on Twitter's end.

Feb 5 2018, 4:15 PM · Phacility, Ops
epriestley added a comment to T13062: Trying to manage anything in Gsuite is kind of not great?.

I figured some of this might be Safari vs Chrome, even though there's no obvious indication that Safari is having issues (e.g., I didn't catch any JS errors in the console).

Feb 5 2018, 3:59 PM · Phacility, Ops
epriestley added a comment to T13062: Trying to manage anything in Gsuite is kind of not great?.

There's an hourglass icon in the header menu. I don't know what this is for. When I click this, I get a "Loading..." menu which never loads. I reloaded the page, too. There's nothing pertinent in the console error log.

Feb 5 2018, 3:53 PM · Phacility, Ops
epriestley triaged T13062: Trying to manage anything in Gsuite is kind of not great? as Wishlist priority.
Feb 5 2018, 3:51 PM · Phacility, Ops
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

We received our first credit card dispute on January 31st.

Feb 5 2018, 2:51 PM · Phacility
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: Unknown Object (Differential Revision).
Feb 5 2018, 2:05 PM · Herald

Feb 4 2018

epriestley added a revision to T10448: Modularize mail tags: Unknown Object (Differential Revision).
Feb 4 2018, 5:40 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley added a revision to T5554: arc fails with svn/git/hg non english locales: Unknown Object (Differential Revision).
Feb 4 2018, 3:53 PM · Arcanist
epriestley added a revision to T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable: Unknown Object (Differential Revision).
Feb 4 2018, 3:53 PM · Diffusion (v3)
epriestley added a revision to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails: Unknown Object (Differential Revision).
Feb 4 2018, 3:53 PM · Diffusion
epriestley added a comment to T5554: arc fails with svn/git/hg non english locales.

See some additional discussion in T13060 and T7339. Pretty much everything here remains unchanged, but those tasks discover an additional constrain: a parent process has LANG=POSIX (or similar, some non-UTF8 locale), it can not pass UTF8 to subprocesses in argument lists.

Feb 4 2018, 3:11 PM · Arcanist
epriestley added a comment to T12807: Diffusion's "Grep File Content" doesn't work with UTF characters.

See T13060 and T7339 for followups and additional discussion.

Feb 4 2018, 3:01 PM · Diffusion, Bug Report
epriestley added a comment to T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.

D18988 addresses the issue from D18105 (git grep 🐑 fails) more directly by calling @setlocale(LC_ALL, 'en_US.UTF-8') unconditionally during startup. The motivating case in T13060 is:

Feb 4 2018, 2:59 PM · Diffusion (v3)
epriestley added a revision to T13061: Explain more clearly that "arc lint --everything" only lints stuff tracked by the VCS: Unknown Object (Differential Revision).
Feb 4 2018, 2:24 PM · Documentation, Arcanist
epriestley added a revision to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails: Unknown Object (Differential Revision).
Feb 4 2018, 2:09 PM · Diffusion
epriestley added a revision to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails: Unknown Object (Differential Revision).
Feb 4 2018, 2:01 PM · Diffusion
epriestley triaged T13061: Explain more clearly that "arc lint --everything" only lints stuff tracked by the VCS as Low priority.
Feb 4 2018, 1:45 PM · Documentation, Arcanist

Feb 3 2018

epriestley added a comment to T10817: Allow more characters for built-in `filename` linter.

(Future me, see also PHI343.)

Feb 3 2018, 8:09 PM · Lint, Feature Request
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

I think I didn't kick Apache hard enough since I eventually rammed this through with setlocale().

Feb 3 2018, 4:20 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

setlocale(...) doesn't (?) appear to work from within Apache (?).

Feb 3 2018, 4:15 PM · Diffusion
epriestley renamed T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails from Commits may partially fail to import when affecting files with UTF8 characters to When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.
Feb 3 2018, 4:07 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

Thankfully, it seems that setlocale(LC_ALL, 'en_US.UTF-8'); from within PHP does work, so we don't need to figure out what PAM initialization cache file Ubuntu is actually reading LANG settings from.

Feb 3 2018, 4:02 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

sudo update-locale LC_ALL=en_US.UTF-8 LANG=en_US.UTF-8 also does not work, although this is apparently just a Perl script that rewrites /etc/default/locale for you.

Feb 3 2018, 3:54 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

Setting LANG in /etc/environment had no effect on anything.

Feb 3 2018, 3:50 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

I now strongly believe this is some kind of terminal environment problem. This script has different behavior in production and on my laptop:

Feb 3 2018, 3:39 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

No luck, I don't even see any bugs in Differential locally with that change (the en-dash decodes and renders properly). So this might be in the realm of T7339.

Feb 3 2018, 2:04 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

Same result.

Feb 3 2018, 1:57 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

Same results for spaces.

Feb 3 2018, 1:54 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

To try to reproduce this, I did this:

Feb 3 2018, 1:53 PM · Diffusion
epriestley triaged T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails as Normal priority.
Feb 3 2018, 1:47 PM · Diffusion

Feb 2 2018

epriestley added a comment to T13053: Plans: Mail Tags and Failover.

Vaguely related, the subject line for this mail is currently something like:

Feb 2 2018, 11:07 PM · Plans, Must Encrypt Mail, Mail