Page MenuHomePhabricator
Feed Advanced Search

Feb 6 2017

epriestley created T12214: Navigation menus in applications have no maximum width.
Feb 6 2017, 12:07 PM · PHUI

Feb 5 2017

chad closed T12210: Subscribe button is white as Resolved by committing Restricted Diffusion Commit.
Feb 5 2017, 8:45 PM · PHUI, Bug Report
chad added a revision to T12210: Subscribe button is white: Restricted Differential Revision.
Feb 5 2017, 7:53 PM · PHUI, Bug Report
chad created T12210: Subscribe button is white.
Feb 5 2017, 6:04 AM · PHUI, Bug Report

Feb 3 2017

epriestley added a comment to T10687: jx-tooltip does whatever it feels like.

I think we currently don't really try to handle these cases:

Feb 3 2017, 7:31 PM · PHUI, Bug Report
epriestley added a comment to T10687: jx-tooltip does whatever it feels like.

That tip probably does not fit on screen in any of the orientations: it obviously won't fit to the north or east. If we try to put it to the south, part of it will be offscreen to the right. If we try to put it to the west, part of it will be off the top of the screen (the rectangle we use to detect the size of the tip box is slightly larger than the actual pixel size of the tip because we get weird scrollbar interactions if we use the size of the tip exactly).

Feb 3 2017, 7:28 PM · PHUI, Bug Report
epriestley added a comment to T10687: jx-tooltip does whatever it feels like.

My trick is:

Feb 3 2017, 7:25 PM · PHUI, Bug Report
chad added a comment to T10687: jx-tooltip does whatever it feels like.

Yeah I couldn't quite grab a screen

Feb 3 2017, 7:24 PM · PHUI, Bug Report
epriestley added a comment to T10687: jx-tooltip does whatever it feels like.

Here's what I see:

Feb 3 2017, 7:24 PM · PHUI, Bug Report
chad added a comment to T10687: jx-tooltip does whatever it feels like.

Chrome:

  • Go to Workboard
  • Click Fullscreen
  • Hover over Fullscreen - tooltip is elsewhere?
Feb 3 2017, 7:22 PM · PHUI, Bug Report
chad closed T11971: Build an Icon Typeahead as Resolved by committing Restricted Diffusion Commit.
Feb 3 2017, 5:19 PM · PHUI

Feb 2 2017

chad closed T12163: Long lines overflow in Diffusion browser as Resolved by committing Restricted Diffusion Commit.
Feb 2 2017, 10:11 PM · Bug Report, Diffusion (v3), PHUI
chad edited projects for T12163: Long lines overflow in Diffusion browser, added: Bug Report; removed Bug Report (Needs Information).
Feb 2 2017, 10:10 PM · Bug Report, Diffusion (v3), PHUI
chad added a revision to T12163: Long lines overflow in Diffusion browser: Restricted Differential Revision.
Feb 2 2017, 10:09 PM · Bug Report, Diffusion (v3), PHUI
chad added a comment to T12163: Long lines overflow in Diffusion browser.

I see, it must be a text file.

Feb 2 2017, 10:05 PM · Bug Report, Diffusion (v3), PHUI
epriestley added a comment to T12163: Long lines overflow in Diffusion browser.

Safari / OSX:

Feb 2 2017, 10:05 PM · Bug Report, Diffusion (v3), PHUI
chad edited projects for T12163: Long lines overflow in Diffusion browser, added: Bug Report (Needs Information); removed Bug Report.
Feb 2 2017, 10:03 PM · Bug Report, Diffusion (v3), PHUI
chad added a comment to T12163: Long lines overflow in Diffusion browser.

word-break: break-all; seems to be working fine.

pasted_file (1×2 px, 388 KB)

Feb 2 2017, 10:01 PM · Bug Report, Diffusion (v3), PHUI
chad added a comment to T12163: Long lines overflow in Diffusion browser.

I can't reproduce this, is there a specific browser/OS I should test? Also, feel free to upload a test file to rGITTEST

Feb 2 2017, 10:00 PM · Bug Report, Diffusion (v3), PHUI
chad removed a project from T11972: Single selection typeahead should render selected token better: Contributor Onboarding.
Feb 2 2017, 9:56 PM · PHUI
chad removed a project from T12099: Implement caret as part of PHUIIconView: Contributor Onboarding.
Feb 2 2017, 9:56 PM · PHUI, Design
chad removed a project from T11971: Build an Icon Typeahead: Contributor Onboarding.
Feb 2 2017, 9:56 PM · PHUI
chad added a revision to T12180: Cropped text in Property List: Restricted Differential Revision.
Feb 2 2017, 9:28 PM · PHUI
chad added a comment to T11971: Build an Icon Typeahead.

Probably will implement in Badges and see how it goes. I'd mildly agree with your (only) mild concern about mild confusion if admins do a poor job labeling stuff.

Feb 2 2017, 7:16 PM · PHUI
chad added a revision to T11971: Build an Icon Typeahead: Restricted Differential Revision.
Feb 2 2017, 6:48 PM · PHUI
epriestley updated the task description for T12191: Remarkup autocomplete can remain open after keyboard form submission.
Feb 2 2017, 4:24 PM · Remarkup, PHUI
epriestley created T12191: Remarkup autocomplete can remain open after keyboard form submission.
Feb 2 2017, 4:22 PM · Remarkup, PHUI
cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Also I very probably meant "inline comment" and not "inline diff"

Feb 2 2017, 4:21 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Oh, I missed "inline". That reproduces for me. I'll file a separate issue.

Feb 2 2017, 4:20 PM · Remarkup, PHUI
cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I do not have persistent chat open.

Feb 2 2017, 4:19 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Do you have persistent chat open?

Feb 2 2017, 4:18 PM · Remarkup, PHUI
cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I came across a small bug with the "auto-suggest" feature. In differential I was writing an inline diff, and ended with :/ to show my face in plain ascii, and hit ⌘+⏎ immediately after to complete my inline diff. After typing :/ the auto-complete popped up and when I saved the draft with ⌘+⏎ it forever immortalized the auto-complete popup on screen with no seeming way to get rid of it (refreshing probably fixes~). I can reproduce on this install.

Feb 2 2017, 4:16 PM · Remarkup, PHUI
epriestley moved T12163: Long lines overflow in Diffusion browser from Backlog to Probably Actual Bugs on the Diffusion (v3) board.
Feb 2 2017, 3:53 PM · Bug Report, Diffusion (v3), PHUI
epriestley moved T12163: Long lines overflow in Diffusion browser from Backlog to v3 on the Diffusion board.
Feb 2 2017, 3:20 PM · Bug Report, Diffusion (v3), PHUI
chad added a project to T12180: Cropped text in Property List: PHUI.
Feb 2 2017, 2:07 AM · PHUI
chad added a project to T12163: Long lines overflow in Diffusion browser: PHUI.
Feb 2 2017, 2:07 AM · Bug Report, Diffusion (v3), PHUI

Jan 27 2017

mavit added a comment to T12139: Add a proper emoji picker to Remarkup bar.
In T12139#208563, @chad wrote:

If you're on linux, I think emojione extension likely only choice. What OS/Browser?

Jan 27 2017, 9:28 PM · Remarkup, PHUI

Jan 25 2017

cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

hmm everything seems in order

Jan 25 2017, 4:34 AM · Remarkup, PHUI
cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Click here for 🐱

Jan 25 2017, 4:30 AM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

He's so little. :)

Jan 25 2017, 4:28 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

image.png (218×604 px, 34 KB)

Jan 25 2017, 4:27 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

These are still so painful on non-Safari

Jan 25 2017, 4:27 AM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Poor 🐈.

Jan 25 2017, 4:25 AM · Remarkup, PHUI
cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

yup it works

Jan 25 2017, 4:24 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

💯

Jan 25 2017, 4:23 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I rolled the server for the bug testers.

Jan 25 2017, 4:23 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

🐱

🐱
🐱

🐱

🐱

🐱

Jan 25 2017, 4:22 AM · Remarkup, PHUI
cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

🐈

🐈
🐈

🐈

🐈

🐈

Jan 25 2017, 4:21 AM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I guess I don't even have a glyph for :lion_face: anyway.

Jan 25 2017, 4:17 AM · Remarkup, PHUI
chad added a revision to T12139: Add a proper emoji picker to Remarkup bar: Restricted Differential Revision.
Jan 25 2017, 4:16 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I've already started the 2 minute arc diff process

Jan 25 2017, 4:16 AM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Also while you're in there maybe replace _ with (space) in the strings? I can't find :lion_face: by typing :fac... right now, but I think if you swap the underscores for spaces it will work. Then :cat should be able to find crying_cat_face and stuff, too.

Jan 25 2017, 4:15 AM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

not memorizing emoji collation order in 2017 pfft

Jan 25 2017, 4:14 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

FINE IT IS MY FAULT

Jan 25 2017, 4:13 AM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

The list is sorted by emoji. 🐈 is "alphabetically" earlier than 🐱 in the list of emoji.

Jan 25 2017, 4:12 AM · Remarkup, PHUI
cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

cats are naturally dubious so i'm not surprised

Jan 25 2017, 4:05 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

image.png (548×712 px, 60 KB)

Jan 25 2017, 4:05 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I can't figure out the sort thing, don't think it's an emoji issue.

Jan 25 2017, 4:02 AM · Remarkup, PHUI
cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

sort by awesome, descending

Jan 25 2017, 12:57 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Cat2 is twice as good as Cat

Jan 25 2017, 12:56 AM · Remarkup, PHUI
cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Typing :cat will list the cat2 emoji before cat
🐱

Screen Shot 2017-01-24 at 7.54.31 PM.png (434×768 px, 47 KB)

Jan 25 2017, 12:55 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Found the Chrome issue / Mac: https://bugs.chromium.org/p/chromium/issues/detail?id=551420

Jan 25 2017, 12:26 AM · Remarkup, PHUI

Jan 24 2017

chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

@johnny-bit I had good luck using https://chrome.google.com/webstore/detail/chromoji-emojis-for-googl/negakbijaemdgbhklopmghphgaeadmpo on Ubuntu/Chrome.

Jan 24 2017, 6:05 PM · Remarkup, PHUI
chad added a revision to T12139: Add a proper emoji picker to Remarkup bar: Restricted Differential Revision.
Jan 24 2017, 6:05 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

If you're on linux, I think emojione extension likely only choice. What OS/Browser?

Jan 24 2017, 4:45 PM · Remarkup, PHUI
johnny-bit added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Oh, woe is me, for there are no colours in my emoji. One thing to notice though - where can I find that beautiful emoji example in ui examples? Would be cool place to check for emoji support on different browsers/platforms :)

Jan 24 2017, 10:00 AM · Remarkup, PHUI
avivey added a comment to T12139: Add a proper emoji picker to Remarkup bar.

wow! the beautiful colors!

Jan 24 2017, 8:58 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

pasted_file (1×1 px, 430 KB)

Jan 24 2017, 4:11 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

@avivey let me know how this looks now

Jan 24 2017, 2:03 AM · Remarkup, PHUI
chad added a revision to T12139: Add a proper emoji picker to Remarkup bar: Restricted Differential Revision.
Jan 24 2017, 12:41 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

https://www.tjvantoll.com/2016/06/15/emoji-on-windows/

Jan 24 2017, 12:00 AM · Remarkup, PHUI

Jan 23 2017

chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Well, not non-existent, just black and white line art.

Jan 23 2017, 11:37 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Yeah emoji on Windows is non-existent still. At least, on Windows 10 Chrome / Firefox / Edge it's just what @avivey posted above.

Jan 23 2017, 11:37 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Crazy

Jan 23 2017, 7:37 PM · Remarkup, PHUI
avivey added a comment to T12139: Add a proper emoji picker to Remarkup bar.

pasted_file (309×603 px, 46 KB)

(Chrome on Windows 10)

Jan 23 2017, 7:29 PM · Remarkup, PHUI
johnny-bit added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Pros

  • Users on old versions of Windows or who compiled their own Gentoo don't have occasional missing/fallback emoji.
  • Users see the same picture of a smiling cat instead of different pictures of smiling cats.
Jan 23 2017, 6:27 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

If I can get most places to appear like Safari shows them, this will probably be good for a v1. The reason I like EmojiOne is mostly aesthetic, they are less busy visually (flatter) and are easier to determine what they are individually. I can also control the size. Let me futz with our emoji remarkup rule and see if I can normalize the display better. Though, not sure that's really possible still given Google search results.

Jan 23 2017, 6:05 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Chrome/Firefox seems to be shrinking them smaller. I think we can maybe cheat that with font-size and the emoji remarkup rule...

Jan 23 2017, 5:59 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

pasted_file (552×1 px, 195 KB)

Jan 23 2017, 5:57 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

This is what I see on my Macbook in Safari:

Jan 23 2017, 5:57 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

oh man, at least in Safari they look way better.

Jan 23 2017, 5:57 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I believe Firefox is adopting EmojiOne. If I could CSS style the emojis, it would help. I find them small and hard to identify in text. Basic ones like ❤️ are easy, but all the different emotions are somewhat harder. 😁 vis. 😂 really are hard for me to visually focus on (and on my laptop, which is smaller dpi, is even harder).

Jan 23 2017, 5:52 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Emoji look terrible on nearly every platform / browser

Jan 23 2017, 5:41 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

phurl autocomplete might be nice too

Jan 23 2017, 5:00 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

All I've learned is:

Jan 23 2017, 4:55 PM · Remarkup, PHUI

Jan 21 2017

chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Maybe someday this will be easier; https://lists.w3.org/Archives/Public/www-style/2016Mar/0370.html

Jan 21 2017, 10:13 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I'll get back to you

Jan 21 2017, 7:50 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Well

Jan 21 2017, 7:50 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I think the pros and cons are something like:

Jan 21 2017, 7:29 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

oh man these crack me up.

Jan 21 2017, 7:23 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

pasted_file (110×2 px, 68 KB)

Jan 21 2017, 7:20 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Haha, sorry I think this might be a good JS learning side project for me on the weekends if I have free time.

Jan 21 2017, 7:19 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I think we should just use actual emoji for this, not sprite sheets?

Jan 21 2017, 7:07 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

tarnation

Jan 21 2017, 7:05 PM · Remarkup, PHUI
chad updated subscribers of T12139: Add a proper emoji picker to Remarkup bar.
In D17238#205025, @epriestley wrote:

Yep, go for it.

Jan 21 2017, 7:00 PM · Remarkup, PHUI
chad updated the task description for T12139: Add a proper emoji picker to Remarkup bar.
Jan 21 2017, 3:14 AM · Remarkup, PHUI
chad created T12139: Add a proper emoji picker to Remarkup bar.
Jan 21 2017, 3:13 AM · Remarkup, PHUI

Jan 19 2017

chad created T12126: Probably remove cat facts.
Jan 19 2017, 7:04 PM · Profile Menu Item

Jan 18 2017

chad created T12120: Move PhabricatorActionView to AphrontTagView or merge with PHUIListItemView.
Jan 18 2017, 7:15 PM · PHUI

Jan 12 2017

chad created T12099: Implement caret as part of PHUIIconView.
Jan 12 2017, 6:45 PM · PHUI, Design