Page MenuHomePhabricator
Feed Advanced Search

Jun 22 2015

epriestley closed T6787: Clarify UI for Objects with a non-default Policy as Resolved by committing Restricted Diffusion Commit.
Jun 22 2015, 6:47 PM · Design, Policy, Wikimedia
epriestley closed T5135: Allow to change defaults for Passphrase "Visible To" and "Editable By" policies, a subtask of T6787: Clarify UI for Objects with a non-default Policy, as Resolved.
Jun 22 2015, 6:28 PM · Design, Policy, Wikimedia
epriestley added a revision to T6787: Clarify UI for Objects with a non-default Policy: Restricted Differential Revision.
Jun 22 2015, 3:28 AM · Design, Policy, Wikimedia

Jun 21 2015

ed.galligan added a comment to T8549: Feedback on 2015 Redesign.

After using the new UI daily for a little bit now, I'd have to agree with many of the comments here on brightness, low-contrast, etc. It seems less of an accessibility issue (which would be more about readability/legibility - the text contrast is fine) and more of a usability issue (more about scanability of UI elements and identifying UI elements quickly in peripheral vision, differentiating comment-blocks quickly while scrolling, etc.)

Jun 21 2015, 10:20 PM · Design
joshuaspence added a comment to T8549: Feedback on 2015 Redesign.

The background on the "Needs Revision" state in Differential looks odd to me. I feel that this would actually look better without a background color.

Jun 21 2015, 9:45 PM · Design
epriestley added a comment to T6787: Clarify UI for Objects with a non-default Policy.

Feeling pretty confident that T6860 was a really bad idea, so I threw it away; my current plan is to do T5135 instead, as described above.

Jun 21 2015, 2:42 PM · Design, Policy, Wikimedia
epriestley edited subtasks for T6787: Clarify UI for Objects with a non-default Policy, added: T5135: Allow to change defaults for Passphrase "Visible To" and "Editable By" policies; removed: T6860: Allow creation of parameterized application policies.
Jun 21 2015, 2:41 PM · Design, Policy, Wikimedia
epriestley added a comment to T6787: Clarify UI for Objects with a non-default Policy.

I think this is a change we should probably pursue, and start with a color treatment as in T6787#88172. There are several technical challenges:

Jun 21 2015, 2:20 PM · Design, Policy, Wikimedia
epriestley added a subtask for T6787: Clarify UI for Objects with a non-default Policy: T6860: Allow creation of parameterized application policies.
Jun 21 2015, 2:05 PM · Design, Policy, Wikimedia
epriestley added a comment to T8549: Feedback on 2015 Redesign.

I don't think applications can ever show as feed actors today, although I'm not 100% sure about that.

Jun 21 2015, 11:46 AM · Design
chad added a comment to T8549: Feedback on 2015 Redesign.

Herald obviously should be an outline of Exploud.

Jun 21 2015, 11:46 AM · Design
chad added a comment to T8549: Feedback on 2015 Redesign.

I fixed this in timeline. Does herald show as an actor in feed? I don't feel timeline needs the image for herald, but feed actor images could be nice. I'd probably generate them by application needs (herald, harbor master, diffusion)

Jun 21 2015, 11:44 AM · Design
epriestley added a comment to T8549: Feedback on 2015 Redesign.

For application actors, like Herald, we don't have a profile icon when they create feed stories:

Jun 21 2015, 11:38 AM · Design
chad added a revision to T8099: Mid-2015 Phabricator Redesign: Restricted Differential Revision.
Jun 21 2015, 9:23 AM · Design

Jun 20 2015

chad added a revision to T8099: Mid-2015 Phabricator Redesign: Restricted Differential Revision.
Jun 20 2015, 9:13 PM · Design
chad added a revision to T8099: Mid-2015 Phabricator Redesign: Restricted Differential Revision.
Jun 20 2015, 7:56 PM · Design
chad added a revision to T8099: Mid-2015 Phabricator Redesign: Restricted Differential Revision.
Jun 20 2015, 7:32 PM · Design
CodeMouse92 added a comment to T8549: Feedback on 2015 Redesign.

Ahhhhhh, after D13363 I can track more easily again. Thanks @chad and @epriestley!

Jun 20 2015, 4:59 PM · Design
chad added a comment to T8549: Feedback on 2015 Redesign.

It'll be fixed before final, I have the full font, just not as a woff.

Jun 20 2015, 4:57 PM · Design
johnny-bit added a comment to T8549: Feedback on 2015 Redesign.

I have one major problem for me & team with redesign: font choice. It seems that choosen font misses all of polish diacritic characters. Let me try here before sending screenshots:

Jun 20 2015, 4:55 PM · Design
marceldegraaf added a comment to T8549: Feedback on 2015 Redesign.

That's an awesome feature, @epriestley. I'm don't even need it myself, but I really love how Phabricator tries to be a tool for anyone to use, without getting in their way. We're about to move our entire company off of Github and onto Phabricator and it's things like this that reassure me we've made the right choice :-).

Jun 20 2015, 4:21 PM · Design
epriestley added a comment to T8549: Feedback on 2015 Redesign.

After D13363, you can now select "Use High Contrast Colors" in Settings → Display Preferences → Accessibility. It currently looks like this:

Jun 20 2015, 1:26 PM · Design
chad added a revision to T8099: Mid-2015 Phabricator Redesign: Restricted Differential Revision.
Jun 20 2015, 10:58 AM · Design
chad added a revision to T8099: Mid-2015 Phabricator Redesign: Restricted Differential Revision.
Jun 20 2015, 10:50 AM · Design
chad added a comment to T8549: Feedback on 2015 Redesign.

One is a link, and gets the consistent color of darkbluetext, the other is not. This isn't new to the redesign (though I think it did not previously render consistently). I don't expect Timeline to be redesigned in this branch, it's too big a project.

Jun 20 2015, 8:46 AM · Design
joshuaspence added a comment to T8549: Feedback on 2015 Redesign.

I don't like the different colours here:

Jun 20 2015, 8:24 AM · Design

Jun 19 2015

tycho.tatitscheff added a comment to T8549: Feedback on 2015 Redesign.

I would +1 :

  • a more contrasted UI (bordure) aand find @epriestley solutions good
  • a try with fixed centred width or more margin (lets say contents over 8/12 of the screen)
Jun 19 2015, 9:49 PM · Design
CodeMouse92 added a comment to T8549: Feedback on 2015 Redesign.

@chad The dark header solution would be very helpful. Given that features generally take months to roll out (just due to the nature of software, it's the same at my place), you can understand why I'm concerned about the promise of T8614 post-redesign.

Jun 19 2015, 9:35 PM · Design
chad added a comment to T8549: Feedback on 2015 Redesign.

D13361 is one potential solution, T8614 is another. Redesign is still weeks away at best. July was always the target.

Jun 19 2015, 9:31 PM · Design
CodeMouse92 added a comment to T8549: Feedback on 2015 Redesign.

@epriestley I understand prioritization. However, if that's the case, is there a way that I can NOT get the UI update on my end? I spend a lot of time on my Phabricator server, since I'm the lead developer, and my eyes are already tired from being here.

Jun 19 2015, 9:20 PM · Design
epriestley added a comment to T8549: Feedback on 2015 Redesign.

Alright. I think that probably falls under T8614 more than being a core design constraint. We can do resource post-processors + more variables with relative ease for users with substantially different visual constraints, at some point in the future, but given that huge swaths of the internet are problematic for your particular constraint I don't think we should design around it for the majority of the userbase, for whom black text on a white background is easy to read.

Jun 19 2015, 9:14 PM · Design
chad added a revision to T8099: Mid-2015 Phabricator Redesign: Restricted Differential Revision.
Jun 19 2015, 9:13 PM · Design
CodeMouse92 added a comment to T8549: Feedback on 2015 Redesign.

@epriestley Yes, I do have difficulty. I prefer interfaces that don't use that color scheme. Even with textbooks, I have to use a colored plastic sheet to deal with the glaring white and black, otherwise I can't process what I read. For example, my code editor...

Jun 19 2015, 9:07 PM · Design
CodeMouse92 added a comment to T8549: Feedback on 2015 Redesign.

@epriestley, @chad
EDIT: Yes, Chad, exactly.

Jun 19 2015, 9:03 PM · Design
epriestley added a comment to T8549: Feedback on 2015 Redesign.

Do you have difficulty reading Wikipedia, NYTimes, etc? Other major web properties which primarily present large blocks of text in black on white backgrounds?

Jun 19 2015, 9:03 PM · Design
chad added a comment to T8549: Feedback on 2015 Redesign.

I think he is more concerned with the added whitespace of the boxes, and lowered contrast between boxes and background. That the more individual boxes popped off the page, the easier they were to consume.

Jun 19 2015, 9:02 PM · Design
epriestley added a comment to T8549: Feedback on 2015 Redesign.

@CodeMouse92, I'm really confused about your feedback. Almost all of the text was on pure white in the old design, too. Here's a screenshot of the old design: all the text is black on white:

Jun 19 2015, 9:00 PM · Design
CodeMouse92 added a comment to T8549: Feedback on 2015 Redesign.

@chad, Comparing the new UI to the old one, I see quite the opposite. I'm just asking for the white to be toned down to a subtle off-white so as to make it usable to users like myself. I am having a VERY hard time on here right now.

Jun 19 2015, 8:56 PM · Design
chad added a comment to T8549: Feedback on 2015 Redesign.

@CodeMouse92 this would reduce white, not increase.

Jun 19 2015, 8:54 PM · Design
CodeMouse92 added a comment to T8549: Feedback on 2015 Redesign.

@chad, SIGNIFICANTLY opposed only to the massive use of pure white. See my large above comment.

Jun 19 2015, 8:52 PM · Design
marceldegraaf added a comment to T8549: Feedback on 2015 Redesign.

Would it be possible to support both fixed and fluid layouts? Or is that
going to be a pain to support for all the different apps?

Jun 19 2015, 8:50 PM · Design
avivey added a comment to T8549: Feedback on 2015 Redesign.

It means you don't need to make it look good at 1000px, 1200px, 700px...

Jun 19 2015, 8:49 PM · Design
chad added a comment to T8549: Feedback on 2015 Redesign.

The only reason to move to fixed width is that it's easier to read (lots of UX studies on the matter). It doesn't change anything for me, as everything is already responsively designed anyways

Jun 19 2015, 8:47 PM · Design
avivey added a comment to T8549: Feedback on 2015 Redesign.

I wouldn't say i'm "significantly opposed" to width-limited/centered content, but I don't like the notion. I want to be able to set the width of the content to whatever I want, and the browser window lets me do that on the fly.
Philosophically, deciding that I only get 800 pixels or whatever makes your (The designer's) life easier, at the expense of limiting the user's choices, and that something I dislike.

Jun 19 2015, 8:26 PM · Design
chad added a comment to T8549: Feedback on 2015 Redesign.

The best way to think about this is that it is a new 'base' for the next few years with Phabricator. Based on what products are coming soon (Spaces, Harbormaster, Calendar) and what will come down the road, it was becoming clear to me that shoehorning stuff in endlessly would end up being quite a mess. Time to refresh. It was intentional to break everything down to a minimal site and from that move forward. I just want the "tools" themselves to seem invisible, and out of the way. All that should matter is your content and that it's clearly accessible.

Jun 19 2015, 8:02 PM · Design
chad added a revision to T8099: Mid-2015 Phabricator Redesign: Restricted Differential Revision.
Jun 19 2015, 7:42 PM · Design
CodeMouse92 added a comment to T8549: Feedback on 2015 Redesign.

@epriestley @chad

Nothing is hard to read and the text contrast is great.

Jun 19 2015, 6:50 PM · Design
johnny-bit added a comment to T8549: Feedback on 2015 Redesign.

"Muted" is be perfect word for what I feel: everything is good and decent, but it's not as fun as it used to be.

Jun 19 2015, 6:42 PM · Design
avivey added a comment to T8549: Feedback on 2015 Redesign.
In T8549#121389, @egig wrote:

Hi, all. It'll be better if the main content has comfortable maximum width on wide screen and set it to center.

Why don't you just set the width of the browser to the width you like?

Jun 19 2015, 5:24 PM · Design
epriestley added a comment to T8549: Feedback on 2015 Redesign.

I merged/updated and now new 100x100 profile pictures look like background-size isn't being applied correctly:

Jun 19 2015, 3:42 PM · Design
epriestley added a comment to T8549: Feedback on 2015 Redesign.

After using this for a while, I also find the UI very "bright", or I'd specifically say "unsaturated", or "washed-out" or "muted". Nothing is hard to read and the text contrast is great, the overall feeling of the UI for me is that all of the backgrounds and borders have the minimum level of saturation and contrast to be clear.

Jun 19 2015, 3:27 PM · Design
chad added a revision to T8099: Mid-2015 Phabricator Redesign: Restricted Differential Revision.
Jun 19 2015, 11:56 AM · Design
chad added a comment to T8549: Feedback on 2015 Redesign.

@aklapper thanks! I filed T8614 actually to track this better. I think the Accessible side is more easily solved than the entire task of T4213. So basically, T8614 is "I need my software to be Accessible" and T4213 is "I don't like how Phabricator looks.".

Jun 19 2015, 10:16 AM · Design
marceldegraaf added a comment to T8549: Feedback on 2015 Redesign.
In T8549#121390, @chad wrote:

I had hoped to explore that this pass, but don't know if we'll fit that in. (I prefer centered, fixed-width content myself).

Jun 19 2015, 10:04 AM · Design
aklapper added a comment to T8549: Feedback on 2015 Redesign.

Re accessibility/contrast: Alright, so I'd forward users with limited eyesight and their statements to T4213. Thanks! (Side note: You probably meant the Wikimedia community when you wrote "WMF".)

Jun 19 2015, 9:44 AM · Design
chad added a comment to T8549: Feedback on 2015 Redesign.

90% of the UI is exactly the same color. The bar colors are gone, and the header gradients are gone. The main header can still be set to dark/black and none of the actual "workspace" is any brighter (it was always white).

Jun 19 2015, 9:44 AM · Design
• aHa added a comment to T8549: Feedback on 2015 Redesign.

agree, a little bit too bright for me.

Jun 19 2015, 9:23 AM · Design
joshuaspence added a comment to T8549: Feedback on 2015 Redesign.

I also find the new design to be very bright.

Jun 19 2015, 7:13 AM · Design
Mnkras added a comment to T8549: Feedback on 2015 Redesign.

This is my personal opinion, but its really bright.

Jun 19 2015, 5:30 AM · Design

Jun 18 2015

epriestley added a comment to T4213: Provide custom themes, skinning, or custom CSS.

@paladox, please read the description carefully. The images are helping support the main point of the section, which is that Phabricator changes very quickly. Having old images which are very different from the modern UI helps reinforce this point.

Jun 18 2015, 8:25 PM · Design
• paladox added a comment to T4213: Provide custom themes, skinning, or custom CSS.

Could the images be updated to reflect the recent changes to phabricator. since it looks much modern then that.

Jun 18 2015, 8:24 PM · Design
epriestley updated the task description for T4213: Provide custom themes, skinning, or custom CSS.
Jun 18 2015, 8:23 PM · Design
• paladox updated the task description for T4213: Provide custom themes, skinning, or custom CSS.
Jun 18 2015, 8:22 PM · Design
epriestley merged T8606: Support customised skins and logo into T4213: Provide custom themes, skinning, or custom CSS.
Jun 18 2015, 8:18 PM · Design
epriestley merged task T8606: Support customised skins and logo into T4213: Provide custom themes, skinning, or custom CSS.
Jun 18 2015, 8:18 PM · Design
• paladox created T8606: Support customised skins and logo.
Jun 18 2015, 8:17 PM · Design
chad closed T8342: Design a new PHUIPagerView, allow setting to objects as Resolved.

Resolved-ish.

Jun 18 2015, 7:22 PM · Design
chad closed T8342: Design a new PHUIPagerView, allow setting to objects, a subtask of T8099: Mid-2015 Phabricator Redesign, as Resolved.
Jun 18 2015, 7:22 PM · Design
epriestley added a comment to T8549: Feedback on 2015 Redesign.

To echo @chad's comments, we really want to drive accessibility changes by understanding problems and then solving them, just like we drive all other product changes.

Jun 18 2015, 7:05 PM · Design
chad added a comment to T8549: Feedback on 2015 Redesign.

Potential accessibility issue:

  • .phui-timeline-title text has color: #6B748C.
  • body has background: #F7F7F7.

According to http://webaim.org/resources/contrastchecker/ that's a contrast ratio of 4.35:1.
WCAG 2.0 level AA requires a contrast ratio of 4.5:1 for normal text.

Jun 18 2015, 6:41 PM · Design
aklapper added a comment to T8549: Feedback on 2015 Redesign.

Potential accessibility issue:

  • .phui-timeline-title text has color: #6B748C.
  • body has background: #F7F7F7.
Jun 18 2015, 5:17 PM · Design

Jun 17 2015

chad added a revision to T8099: Mid-2015 Phabricator Redesign: Restricted Differential Revision.
Jun 17 2015, 7:50 PM · Design
20after4 added a comment to T8549: Feedback on 2015 Redesign.

When I scale the text size up a bit, I get a weird left margin of blank space next to the page content:

Jun 17 2015, 7:39 AM · Design
chad added a comment to T8549: Feedback on 2015 Redesign.
In T8549#121389, @egig wrote:

Hi, all. It'll be better if the main content has comfortable maximum width on wide screen and set it to center. Overall, I like the new design, thanks for this. I wish i can contribute more.

Jun 17 2015, 7:19 AM · Design
• egig added a comment to T8549: Feedback on 2015 Redesign.

Hi, all. It'll be better if the main content has comfortable maximum width on wide screen and set it to center. Overall, I like the new design, thanks for this. I wish i can contribute more.

Jun 17 2015, 7:17 AM · Design
joshuaspence added a comment to T8549: Feedback on 2015 Redesign.

Yeah, I find the exclamation icons to be too harsh (especially for the "accepted" state).

Jun 17 2015, 2:18 AM · Design
staticshock added a comment to T8549: Feedback on 2015 Redesign.

At certain resolutions:

Jun 17 2015, 1:14 AM · Design
avivey added a comment to T8549: Feedback on 2015 Redesign.

I think the hovercards titles are too big:

pasted_file (162×418 px, 17 KB)

Jun 17 2015, 12:01 AM · Design

Jun 16 2015

jhgg added a comment to T8549: Feedback on 2015 Redesign.

Have you considered adjusting the padding on the panels and such?

Jun 16 2015, 9:11 PM · Design
chad added a revision to T8099: Mid-2015 Phabricator Redesign: Restricted Differential Revision.
Jun 16 2015, 8:42 PM · Design
avivey added a comment to T8549: Feedback on 2015 Redesign.

The notification markers look much better today :)

Jun 16 2015, 8:23 PM · Design
epriestley added a comment to T8549: Feedback on 2015 Redesign.

Odd button alignment on "Notifications":

Jun 16 2015, 8:15 PM · Design
chad added a revision to T8099: Mid-2015 Phabricator Redesign: Restricted Differential Revision.
Jun 16 2015, 7:25 PM · Design
johnny-bit added a comment to T8549: Feedback on 2015 Redesign.

Header serifs are nice. Make it consistent everywhere and it'll be good. at first glance it does feel weird, but I believe in @chad

Jun 16 2015, 6:03 PM · Design
chad added a revision to T8099: Mid-2015 Phabricator Redesign: Restricted Differential Revision.
Jun 16 2015, 5:38 PM · Design
tycho.tatitscheff added a comment to T8549: Feedback on 2015 Redesign.
  • Personally i fill sheriff font quite disturbing. Is it not possible to get a not that much heavier font that Oswald was but still sans sherif. This one make quite typewriting font ?
  • I +1 hach-que consideration about task indicator les readable than before
Jun 16 2015, 2:32 AM · Design
Mnkras added a comment to T8549: Feedback on 2015 Redesign.

When I mouse over the [Triangle !] icon they get a bit flashy:

Jun 16 2015, 2:07 AM · Design

Jun 15 2015

hach-que added a comment to T8549: Feedback on 2015 Redesign.

Also this doesn't line up:

Jun 15 2015, 11:42 PM · Design
hach-que added a comment to T8549: Feedback on 2015 Redesign.

This looks weird to me because my brain continues the straight line downward and doesn't like the fact that the circular icons rest right against that invisible line. Maybe it's me, but I feel like there should be some left padding on those circular icons...

Jun 15 2015, 11:40 PM · Design
CodeMouse92 added a comment to T8549: Feedback on 2015 Redesign.

I'm dyslexic, and I have to admit that the new layout can be a bit hard to use for me - it uses far more whitespace, much lighter grey, and less separators, so it is harder for me to track (read). Color settings would be nice, honestly, or at least make it a little less...white?

Jun 15 2015, 10:35 PM · Design
eadler added a comment to T8549: Feedback on 2015 Redesign.

Just some additional feedback here: I find the exclamation marks confusing. I like them on "commits need audits" but dislike them for tasks.

Jun 15 2015, 9:52 PM · Design
chad added a comment to T8549: Feedback on 2015 Redesign.

Advanced search is definitely supposed to open by default. Saved searches should be all that collapse.

Jun 15 2015, 7:33 PM · Design
epriestley added a comment to T8549: Feedback on 2015 Redesign.
  • I'm definitely missing advanced search defaulting open, especially on global search. My filter is set to "Open Tasks", which is what I want about 80% of the time, but the other 20% of the time I scroll up to edit the constraints. With the new behavior, I have to open the query interface to do this.
Jun 15 2015, 6:33 PM · Design
avivey added a comment to T8549: Feedback on 2015 Redesign.

The body text is a bit fuzzy (and annoying to read) on my computer (Desktop/Windows/Chrome 44):

Jun 15 2015, 5:23 PM · Design
chad added a comment to T8549: Feedback on 2015 Redesign.

I expect there are lots of incidental bugs from the last two merges, I didn't attend to them all yet, but if you want to get a feel for it for a day maybe? with prod data, that's cool with me.

Jun 15 2015, 4:16 PM · Design
epriestley added a comment to T8549: Feedback on 2015 Redesign.

Oh! Sorry -- I pushed it to this install and put a "give us feedback here" thing on the home page. I can pull it back for now if it's not ready for feedback quite yet, it just looked like most of the internal feedback had been sorted and master was in a pretty good state to merge over.

Jun 15 2015, 4:09 PM · Design
chad added a comment to T8549: Feedback on 2015 Redesign.

Is... this live for people? I only have email right now, no web. But it sounds like people are using it, haha.

Jun 15 2015, 4:00 PM · Design
epriestley added a comment to T8549: Feedback on 2015 Redesign.

Oh, hovercards have double status, too (note double "Open").

Jun 15 2015, 3:58 PM · Design
cburroughs added a comment to T8549: Feedback on 2015 Redesign.

https://secure.phabricator.com/book/phabflavor/article/writing_reviewable_code/ <-- Article button shows up twice now

Jun 15 2015, 3:54 PM · Design
epriestley added a comment to T8549: Feedback on 2015 Redesign.
  • Line height in Feed and Conpherence feels a little tighter than in comments / descriptions? Maybe I'm imagining this or it's just a size/font/rendering issue, but this feels a touch tighter (mostly vertically, I think?) than I expect:
Jun 15 2015, 3:43 PM · Design