We should be running the same code on both, so this might be a specific mail client's quoting conventions, as @chad suggests. There's no standard way for us to strip off quoted text or signatures from email so we kind of do a collection of things that usually work and just add more rules as we run into cases we don't handle correctly.

Ah, nice. Happy to accept a diff to stub out getCommitHookMode() for a few months if anyone still has a use case.

• Other, more useful applications (Maniphest, Differential) don't currently do this.
  • PhabricatorApplicationTransactionFeedStory doesn't really support doing this the right way.
    • Audit implements it OK.
    • Pholio and Ponder implement it but sort of show the wrong data (the description at view-time, not at create-time, which is misleading).

This is probably not meaningfully distinguishable from T8097, I'm just going to merge it into that.

We don't plan to implement this. Generally, we don't let any users remove data.

The most promising way to implement these capabilities is to more fully proxy the Git protocol, as we do to some degree for Mercurial and SVN, so I plan to evaluate that first.

The bug reporting guide suggests this as a "Common Fix":

Well, I guess an old version of PHUIObjectItemView.php, to be precise.

Specifically, APC cached an old version of PhabricatorSearchResultView.php, and restarting cleared the cache.

Restart Apache (if using apache) or fpm (if using nginx + php-fpm), and let me know if that fixes it?

I occasionally want this, too. I think giving the full-Conpherence interface a secondary "Preview -> Post" workflow might be reasonable, so you can either post directly or review a modal preview on your way.

As a goofy workaround you can probably write some dummy file

We don't currently decode base85 in diff form, so pasting a git diff --binary diff into Phabricator doesn't produce the exact same diff as running arc diff. Particularly, in base85 we just note "this binary file was added"; via arc diff we would show the actual file.

I'd expect it to work on relatively up-to-date Phabricator. You may still need to have some valid-ish ~/.arcrc file, which we might be reading and then ignoring. I'll check that and fix it if it's the case -- we shouldn't require a ~/.arcrc if you specify --conduit-token.

I think it would be reasonable to leave getCommitHookMode() around as a stub which just emits a deprecation warning and does return false; -- I believe none of the other changed APIs are likely to be used by third-party stuff which isn't materially affected by the changes.

We can definitely do what GitHub does (or some reasonable approximation, at least), I just don't want to spend a lot of time implementing it without understanding what problem we're trying to solve here. I thought I understood the problem, but I think that I don't actually have a good understanding of the use cases. I'd like to step back, discuss the problem more to understand exactly what you're after and why what we have isn't working well, and then move forward from there. Specifically, what I'm trying to do is:

Github actually has an algorithm for exactly this that's mostly good.
I've thought about this feature, and would be quite satisfied if I could mark things that I've requested as 'done'

Presuming this is resolved, but let me know if that's not the case.

I can't reproduce this at HEAD, so I think you're either out of date or this was fixed recently (although I don't recall fixing it).

Also, to summarize the recent changes:

(In that mock, imagine that all the "reply" inlines appear in a thread, even though there's technically only one on the mock.)

In T7447#110475, @scohen wrote:

I don't know @epriestley, I found it really confusing to have my comment on a different line entirely.

We have a user_transaction table but I don't think we expose it anywhere in the UI and I'm not sure how much stuff gets dumped into it. We should record important account-related events there (creation, username changes, admin/un-admin, etc).