Page MenuHomePhabricator
Feed Advanced Search

May 18 2015

joshuaspence added a revision to T7604: Remove "Arcanist Projects": Restricted Differential Revision.
May 18 2015, 1:39 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 18 2015, 1:26 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 18 2015, 1:24 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Restricted Differential Revision.
May 18 2015, 1:10 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 18 2015, 1:03 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 18 2015, 12:32 PM · Diffusion
joshuaspence added a comment to T8232: Automatically claim a task when a differential is submitted.

Another alternative is for this to be a Herald rule... I'm not sure which is more preferable

May 18 2015, 7:37 AM · Differential, Maniphest
joshuaspence added a comment to T7604: Remove "Arcanist Projects".

Ah nice.

May 18 2015, 12:03 AM · Diffusion
joshuaspence placed T7286: Re-evaluate whether passing GET data in the body is a good idea up for grabs.

I haven't actually done anything on this.

May 18 2015, 12:02 AM · libphutil
joshuaspence edited projects for T8165: Investigate high CPU usage, added: Performance; removed Infrastructure.
May 18 2015, 12:01 AM · Performance
joshuaspence added a parent task for T8042: PhutilUnitTestEngine can't execute a single test path: T7215: ArcanistXMLLinterTestCase test failure.
May 18 2015, 12:00 AM · Arcanist
joshuaspence added a subtask for T7215: ArcanistXMLLinterTestCase test failure: T8042: PhutilUnitTestEngine can't execute a single test path.
May 18 2015, 12:00 AM · Lint

May 17 2015

joshuaspence added a comment to T7215: ArcanistXMLLinterTestCase test failure.

This will be much easier to test after T8042.

May 17 2015, 11:59 PM · Lint
joshuaspence closed T8231: exception in arc which as Resolved by committing Restricted Diffusion Commit.
May 17 2015, 11:41 PM · Arcanist
joshuaspence closed T8215: Revert detection in Diffusion crosses repositories as Resolved by committing Restricted Diffusion Commit.
May 17 2015, 11:40 PM · Diffusion
joshuaspence added a member for Symbols: joshuaspence.
May 17 2015, 10:43 PM
joshuaspence closed T8207: Add linter rule to prevent exceptions from being thrown in a __toString method as Resolved by committing Restricted Diffusion Commit.
May 17 2015, 10:23 PM · Lint
joshuaspence created T8232: Automatically claim a task when a differential is submitted.
May 17 2015, 10:15 PM · Differential, Maniphest
joshuaspence added a revision to T8231: exception in arc which: Unknown Object (Differential Revision).
May 17 2015, 10:05 PM · Arcanist
joshuaspence updated subscribers of T7604: Remove "Arcanist Projects".

@epriestley, do you have any idea how Differential would work without Arcanist Projects? My only thought is that we could do some sort of Conduit call to determine the repository. Probably this should happen server-side I guess.

May 17 2015, 9:35 PM · Diffusion
• JamesRamm awarded T4558: Make Diviner useful for third-parties a Like token.
May 17 2015, 9:49 AM · Diviner
• JamesRamm awarded T4558: Make Diviner useful for third-parties a Pterodactyl token.
May 17 2015, 9:49 AM · Diviner

May 16 2015

joshuaspence added a revision to T8215: Revert detection in Diffusion crosses repositories: Unknown Object (Differential Revision).
May 16 2015, 7:13 AM · Diffusion
joshuaspence added a comment to T8215: Revert detection in Diffusion crosses repositories.

Out of curiosity, why do you have the same repository imported multiple times?

May 16 2015, 5:23 AM · Diffusion
joshuaspence claimed T8215: Revert detection in Diffusion crosses repositories.

Seems fair enough. I'll take a crack at this seeing as I implemented a lot of the revert stuff.

May 16 2015, 5:22 AM · Diffusion

May 15 2015

joshuaspence added a revision to T8207: Add linter rule to prevent exceptions from being thrown in a __toString method: Restricted Differential Revision.
May 15 2015, 6:19 AM · Lint
joshuaspence claimed T8207: Add linter rule to prevent exceptions from being thrown in a __toString method.
May 15 2015, 6:16 AM · Lint
joshuaspence added a revision to T8156: Linter failures don't provide relevant stacktraces: Unknown Object (Differential Revision).
May 15 2015, 2:23 AM · Arcanist, Lint
joshuaspence created T8207: Add linter rule to prevent exceptions from being thrown in a __toString method.
May 15 2015, 1:55 AM · Lint

May 14 2015

joshuaspence edited projects for T8201: Breaking UserConduitAPIMethod.php error , added: Conduit, People; removed Phabricator.
May 14 2015, 9:56 PM · People, Conduit
joshuaspence triaged T7074: `arc patch Dx` shouldn't ask for authentication if Dx is public as Normal priority.
May 14 2015, 8:57 AM · Arcanist
joshuaspence triaged T7053: Restart daemons automagically as Normal priority.
May 14 2015, 8:57 AM · Daemons
joshuaspence triaged T7462: Undeclared variable lint doesn't work at top-level scope as Normal priority.
May 14 2015, 8:56 AM · Lint

May 13 2015

joshuaspence added a revision to T7417: Write a linter rule for method modifier ordering: Unknown Object (Differential Revision).
May 13 2015, 9:38 PM · Lint
joshuaspence closed T7415: Write a linter rule to detect when a class name is used instead of self as Resolved.

See D12419.

May 13 2015, 9:38 PM · Lint
joshuaspence added a revision to T7415: Write a linter rule to detect when a class name is used instead of self: Unknown Object (Differential Revision).
May 13 2015, 9:38 PM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Unknown Object (Differential Revision).
May 13 2015, 9:05 PM · Lint
joshuaspence closed T7107: When destroying an object, destroy associated worker tasks and notifications as Resolved by committing Restricted Diffusion Commit.
May 13 2015, 8:49 PM · Notifications, Daemons
joshuaspence added a revision to T7453: Trigger notifications when a dependent differential is closed: Unknown Object (Differential Revision).
May 13 2015, 12:01 PM · Differential
joshuaspence added a revision to T7107: When destroying an object, destroy associated worker tasks and notifications: Unknown Object (Differential Revision).
May 13 2015, 11:42 AM · Notifications, Daemons
joshuaspence updated subscribers of T7674: Remove support for arc commit hooks.
May 13 2015, 11:02 AM · Lint, Arcanist
joshuaspence merged task T7071: PHPCS is broken into T7674: Remove support for arc commit hooks.
May 13 2015, 11:02 AM · Lint, Arcanist

May 12 2015

joshuaspence triaged T7453: Trigger notifications when a dependent differential is closed as Wishlist priority.
May 12 2015, 11:42 PM · Differential
joshuaspence triaged T7487: ArcanistWorkflow should extend from PhutilArgumentWorkflow as Low priority.
May 12 2015, 11:41 PM · Arcanist
joshuaspence triaged T7488: Add shell completion support to PhutilArgumentWorkflow as Low priority.
May 12 2015, 11:41 PM · Restricted Project, libphutil
joshuaspence triaged T7489: Move argument spelling correction to PhutilArgumentWorkflow as Low priority.
May 12 2015, 11:41 PM · libphutil
joshuaspence triaged T7603: Remove the deprecated "Repositories" application as Normal priority.
May 12 2015, 11:41 PM · Repositories, Diffusion
joshuaspence triaged T7604: Remove "Arcanist Projects" as Normal priority.
May 12 2015, 11:40 PM · Diffusion
joshuaspence triaged T8042: PhutilUnitTestEngine can't execute a single test path as Wishlist priority.
May 12 2015, 11:40 PM · Arcanist
joshuaspence triaged T8156: Linter failures don't provide relevant stacktraces as Low priority.
May 12 2015, 11:40 PM · Arcanist, Lint
joshuaspence added a project to T8156: Linter failures don't provide relevant stacktraces: Arcanist.
May 12 2015, 11:39 PM · Arcanist, Lint
joshuaspence added a comment to T8165: Investigate high CPU usage.

I don't know that the requests are slow, just that they are CPU intensive (or maybe there are a lot of them?)

May 12 2015, 9:45 PM · Performance
joshuaspence claimed T8165: Investigate high CPU usage.
May 12 2015, 9:35 AM · Performance
joshuaspence created T8165: Investigate high CPU usage.
May 12 2015, 8:02 AM · Performance
joshuaspence edited P1780 preamble.php.
May 12 2015, 8:01 AM

May 11 2015

joshuaspence added a revision to T8156: Linter failures don't provide relevant stacktraces: Unknown Object (Differential Revision).
May 11 2015, 9:36 PM · Arcanist, Lint
joshuaspence created T8156: Linter failures don't provide relevant stacktraces.
May 11 2015, 6:50 AM · Arcanist, Lint

May 10 2015

joshuaspence created T8149: Repository search alignment issue.
May 10 2015, 4:00 AM · Mobile, Diffusion

May 9 2015

joshuaspence added a project to T8139: Human readable results are not shown: Mobile.
May 9 2015, 2:00 AM · Mobile, Conduit
joshuaspence created T8139: Human readable results are not shown.
May 9 2015, 1:37 AM · Mobile, Conduit
joshuaspence created T8138: Creating Herald rule on mobile is difficult.
May 9 2015, 12:16 AM · Mobile, Herald

May 7 2015

joshuaspence closed T8068: Segfault on missing linter when running `arc unit` as Invalid.

Yeah, I originally thought that this might be an XHPAST thing but definitely seems to be XDebug.

May 7 2015, 10:01 PM · Arcanist

May 6 2015

joshuaspence added a revision to T7603: Remove the deprecated "Repositories" application: Unknown Object (Differential Revision).
May 6 2015, 12:47 PM · Repositories, Diffusion
joshuaspence added a comment to T7604: Remove "Arcanist Projects".

Things that still use Arcanist Projects:

May 6 2015, 12:29 PM · Diffusion
joshuaspence added a revision to T7604: Remove "Arcanist Projects": Unknown Object (Differential Revision).
May 6 2015, 11:58 AM · Diffusion
joshuaspence added a parent task for T7977: Associate Symbols with Repositories directly (Instead of arc projects): T7604: Remove "Arcanist Projects".
May 6 2015, 11:00 AM · Symbols
joshuaspence added a subtask for T7604: Remove "Arcanist Projects": T7977: Associate Symbols with Repositories directly (Instead of arc projects).
May 6 2015, 11:00 AM · Diffusion
joshuaspence added a subtask for T7603: Remove the deprecated "Repositories" application: T7604: Remove "Arcanist Projects".
May 6 2015, 11:00 AM · Repositories, Diffusion
joshuaspence added a parent task for T7604: Remove "Arcanist Projects": T7603: Remove the deprecated "Repositories" application.
May 6 2015, 11:00 AM · Diffusion

May 5 2015

joshuaspence created T8081: Emails don't link to monogram.
May 5 2015, 10:06 PM · Conpherence
joshuaspence created T8080: Differential shown as "Blocking Others".
May 5 2015, 9:58 PM · Differential
joshuaspence added a comment to T7977: Associate Symbols with Repositories directly (Instead of arc projects).

I can sorta understand symbol sources, but why do we need to manually mark symbol languages? Can't we just use whatever languages have been indexed?

May 5 2015, 9:44 PM · Symbols
joshuaspence added a comment to T7674: Remove support for arc commit hooks.

Yeah that sounds reasonable.

May 5 2015, 9:18 PM · Lint, Arcanist
joshuaspence added a comment to T8078: Style external links on Phriction.

After T5378, most links should be external (because internal links would be converted into Remarkup objects).

May 5 2015, 9:13 PM · Phriction
joshuaspence closed T7674: Remove support for arc commit hooks as Resolved by committing Restricted Diffusion Commit.
May 5 2015, 12:11 PM · Lint, Arcanist
joshuaspence added a revision to T7674: Remove support for arc commit hooks: Unknown Object (Differential Revision).
May 5 2015, 11:05 AM · Lint, Arcanist
joshuaspence added a revision to T7674: Remove support for arc commit hooks: Unknown Object (Differential Revision).
May 5 2015, 11:03 AM · Lint, Arcanist
joshuaspence added a comment to T7462: Undeclared variable lint doesn't work at top-level scope.

It seems that LINT_NAMING_CONVENTIONS doesn't work at the top level scope either.

May 5 2015, 9:10 AM · Lint
joshuaspence placed T8068: Segfault on missing linter when running `arc unit` up for grabs.

I didn't make any other progress here.

May 5 2015, 8:13 AM · Arcanist
joshuaspence added a comment to T8068: Segfault on missing linter when running `arc unit`.

From syslog:

May 5 2015, 8:09 AM · Arcanist
joshuaspence added a comment to T8068: Segfault on missing linter when running `arc unit`.
> php --version
PHP 5.6.4-4ubuntu6 (cli) (built: Apr 17 2015 15:47:51) 
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2014 Zend Technologies
    with Zend OPcache v7.0.4-dev, Copyright (c) 1999-2014, by Zend Technologies
    with Xdebug v2.3.2, Copyright (c) 2002-2015, by Derick Rethans
May 5 2015, 8:08 AM · Arcanist
joshuaspence claimed T8068: Segfault on missing linter when running `arc unit`.

I actually hit a similar issue recently when running unit tests in rPHU. I might poke around and see what comes up.

May 5 2015, 7:57 AM · Arcanist

May 4 2015

joshuaspence created T8067: Method to identify who created a user account.
May 4 2015, 11:57 PM · People
joshuaspence added a revision to T7215: ArcanistXMLLinterTestCase test failure: Unknown Object (Differential Revision).
May 4 2015, 9:30 PM · Lint
joshuaspence closed T8038: "Ref" syntax doesn't support "and" as Resolved by committing Restricted Diffusion Commit.
May 4 2015, 9:14 PM · Transactions
joshuaspence added a comment to T6859: It is difficult to keep track of used PhabricatorEdgeType IDs.

That sounds reasonable, although a CLI script could suffice I think. ./bin/phid types for example.

May 4 2015, 8:27 PM · Infrastructure
joshuaspence created T8058: Unit tests failing at HEAD.
May 4 2015, 3:03 PM · Celerity
joshuaspence added a revision to T7674: Remove support for arc commit hooks: Unknown Object (Differential Revision).
May 4 2015, 3:01 PM · Lint, Arcanist
joshuaspence added a revision to T7674: Remove support for arc commit hooks: Unknown Object (Differential Revision).
May 4 2015, 2:51 PM · Lint, Arcanist
joshuaspence added a revision to T7674: Remove support for arc commit hooks: Unknown Object (Differential Revision).
May 4 2015, 2:45 PM · Lint, Arcanist
joshuaspence added a comment to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).

I have a basic implementation of this in D12691 and D12692. It's really hacky, but seems to work... I'd like to iterate on this after hopefully receiving some initial feedback. I'm not exactly sure how I should proceed.

May 4 2015, 11:28 AM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Wikimedia, Remarkup
joshuaspence added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Unknown Object (Differential Revision).
May 4 2015, 11:25 AM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Wikimedia, Remarkup
joshuaspence added a revision to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Unknown Object (Differential Revision).
May 4 2015, 11:24 AM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Wikimedia, Remarkup
joshuaspence added a revision to T7674: Remove support for arc commit hooks: Unknown Object (Differential Revision).
May 4 2015, 11:05 AM · Lint, Arcanist
joshuaspence updated subscribers of T7453: Trigger notifications when a dependent differential is closed.

@epriestley, any advice on how to tackle this?

May 4 2015, 10:39 AM · Differential
joshuaspence added a revision to T8042: PhutilUnitTestEngine can't execute a single test path: Unknown Object (Differential Revision).
May 4 2015, 10:38 AM · Arcanist
joshuaspence claimed T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
May 4 2015, 8:20 AM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Wikimedia, Remarkup
joshuaspence claimed T7487: ArcanistWorkflow should extend from PhutilArgumentWorkflow.
May 4 2015, 8:11 AM · Arcanist
joshuaspence claimed T7488: Add shell completion support to PhutilArgumentWorkflow.
May 4 2015, 8:10 AM · Restricted Project, libphutil
joshuaspence claimed T7489: Move argument spelling correction to PhutilArgumentWorkflow.
May 4 2015, 8:10 AM · libphutil