Page MenuHomePhabricator
Create Task
Maniphest T7489

Move argument spelling correction to PhutilArgumentWorkflow
Closed, ResolvedPublic
Actions

Description

Move ArcanistConfiguration::correctArgumentSpelling to PhutilArgumentWorkflow.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit
Restricted Differential RevisionRestricted Diffusion Commit

Related Objects
Search...

Event Timeline

joshuaspence created this task.Mar 7 2015, 1:57 AM
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: libphutil.
joshuaspence added a parent task: T7487: ArcanistWorkflow should extend from PhutilArgumentWorkflow.
joshuaspence added a subscriber: joshuaspence.
joshuaspence claimed this task.May 4 2015, 8:10 AM
joshuaspence triaged this task as Low priority.May 12 2015, 11:41 PM
epriestley mentioned this in T10329: Implement internal workflows / a build engine in Arcanist.Jul 24 2016, 12:46 PM
epriestley added a revision: Restricted Differential Revision.Jul 27 2016, 12:29 PM
epriestley added a revision: Restricted Differential Revision.Jul 27 2016, 12:41 PM
epriestley claimed this task.Jul 27 2016, 12:44 PM

After D16333 there's still a tiny amount of unique spelling correction code in Arcanist, but it's just calling into libphutil and part of code duplication which would be better resolved elsewhere (like T7487).

epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jul 27 2016, 4:35 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a commit: Restricted Diffusion Commit.
Phabricator · Built by Phacility