Actually yes, it seems to be consistent... At least on /maniphest/.

Actually it may not be happening as consistently as I originally thought. Let me poke around when I get a chance.

Perhaps it would be reasonable to develop some additional lexers that could be used for syntax highlighting without invoking pygmentize. We should be able to create a JSON lexer fairly easily (based off of PhutilJSONParser). Not so sure about other syntaxes (CSS, HTML, JS would likely be the big ones for us)

Thanks @epriestley. I'm on a fairly recent phone (Nexus 5), but having viewed T603 again just now and it seems much better... Could've been a network issue on my part (I'm international at the moment).

Closed by commit rARC3de9e4aaea61.

Yeah that sounds reasonable. Maybe we could also update the help text for the commands to include this stuff (although it could be too complex to easily represent... I'm not sure). Basically, detect the VCS and say "This command will do X, Y, Z"

Hmm yeah, point taken.

I had a bit of a look at this and I think that the unit testing code is in need of some attention anyway.

I have a suspicion that the ArcanistConfigurationDrivenLintEngine does a much better job of this than the ArcanistComprehensiveLintEngine, for example. I say this because I looked at fixing this a while ago and gave up, whereas {D9843} is quite a simple fix AFAICT.

Probably the ArcanistPhutilLibraryLinter should have a lower priority than ArcanistXHPASTLinter (and maybe also ArcanistPhutilXHPASTLinter).

But yes, this may not be the best place for this.

(You should be able to hover over the "Connection Error" text to get a more useful description)

I'm not familiar with the reasoning as to why it is slow (figured that you guys might), but I am more concerned with the performance on large diffs/commits (unfortunately we have a lot of these). For some reason, the performance issues seem worse on mobile.

◀ Merged tasks: T5174.

✘ Merged into T1139.

Yeah, that seems pretty reasonable.

Maybe something like this:

In T5541#7, @bluehawk wrote:

You sent an email to a bus? :P

@epriestley, I did try to create this maniphest by emailing bugs@phabricator.com, but no dice. Is this expected to still work?

After discussion with @epriestley, it's probably best to eventually provide a native S3 client, rather than relying on an external library. There already exists a PhutilAWSFuture class, which could probably be extended to support S3. My rough plan for this is as follows:

I think that the problem here is in DifferentialChangesetParser (see | DifferentialChangesetParser.php#716-732). If the changeset is empty, then $encoding will be left null.

Yeah, this has always bothered me.

Thanks, this was likely the issue.

This worked, thanks!

$console = PhutilConsole::getConsole();
$viewer = PhabricatorUser::getOmnipotentUser();
$engine = id(new PhabricatorDestructionEngine());

This seems to work in most cases, however I am getting the following error a bunch of times;

Closed by commit rARC5ab288b30c36.

◀ Merged tasks: T2782.

No, I haven't gotten around to these. Go ahead.

Closed by commit rARC4fd6c99a9331.