Page MenuHomePhabricator
Create Task
Maniphest T5503

Empty file has an unknown character encoding
Closed, ResolvedPublic
Actions

Description

An empty file is currently (incorrectly) being detected as having an "unknown character encoding". See D9678 for an example.

{F171294}

Revisions and Commits

rP Phabricator
D9780rPc1af499ed7ab Only show text encoding note in Differential if a change has hunks

Event Timeline

joshuaspence created this task.Jun 28 2014, 4:39 AM
joshuaspence assigned this task to epriestley.
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Differential.
joshuaspence added a subscriber: joshuaspence.
joshuaspence added a comment.Jun 28 2014, 4:42 AM

I think that the problem here is in DifferentialChangesetParser (see | DifferentialChangesetParser.php#716-732). If the changeset is empty, then $encoding will be left null.

m_hamlet added a subscriber: m_hamlet.Jun 28 2014, 6:46 AM
epriestley edited this Maniphest Task.Jun 29 2014, 5:24 PM
epriestley edited this Maniphest Task.Jun 29 2014, 7:43 PM
epriestley closed this task as Resolved.Jun 29 2014, 7:43 PM

Closed by commit rPc1af499ed7ab.

Phabricator · Built by Phacility