Page MenuHomePhabricator
Feed Advanced Search

Jul 6 2017

chad added a comment to T12899: Use socket to connect to database.

It's not something we'll support given the cost and lack of interest. You can either fork and provide the feature for your local install or use a supported method of connection. To be honest, this is the first request I've seen in 5 years.

Jul 6 2017, 8:09 AM · Bug Report

Jul 5 2017

epriestley added a comment to T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors.

You must be able to view a post's blog to view the post, so the rule is effectively "view and edit".

Jul 5 2017, 10:09 PM · Phame, Policy, Bug Report
avivey added a comment to T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors.

Don't most places consider "Can Edit" to be weaker than "Can View"?

Jul 5 2017, 10:04 PM · Phame, Policy, Bug Report
epriestley added a project to T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors: Phame.
Jul 5 2017, 4:59 PM · Phame, Policy, Bug Report
epriestley renamed T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors from Phame blog draft posts are visible to all to Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors.
Jul 5 2017, 4:59 PM · Phame, Policy, Bug Report
epriestley added a revision to T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors: Restricted Differential Revision.
Jul 5 2017, 4:55 PM · Phame, Policy, Bug Report
epriestley added a comment to T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors.

Historically, Phame originally used the claimed rule ("only the author"), introduced in or around D3694.

Jul 5 2017, 4:47 PM · Phame, Policy, Bug Report
epriestley added a comment to T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors.

The rule we implement seems to work properly, but the UI tells you a different rule.

Jul 5 2017, 4:32 PM · Phame, Policy, Bug Report
epriestley claimed T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors.

The language here is inconsistent with the rule we attempt to implement. Let me make sure the rule we attempt to implement actually works and that this is just a language issue.

Jul 5 2017, 4:27 PM · Phame, Policy, Bug Report
chad added a comment to T11362: Arcanist tries to land onto identical remote branch instead of 'master'.

If other workflows means pushing to the remote, T5000 is the plan. Functionally we don't feel " just push whatever" to the remote scales once you hit enterprise scale. The remote becomes polluted with junk branches.

Jul 5 2017, 4:26 PM · Arcanist, Bug Report
stevex updated the task description for T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors.
Jul 5 2017, 3:49 PM · Phame, Policy, Bug Report
stevex updated the task description for T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors.
Jul 5 2017, 3:48 PM · Phame, Policy, Bug Report
stevex updated the task description for T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors.
Jul 5 2017, 3:48 PM · Phame, Policy, Bug Report
stevex created T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors.
Jul 5 2017, 3:48 PM · Phame, Policy, Bug Report
phabmicha updated subscribers of T12899: Use socket to connect to database.

@chad Do you have any hint for me how to configure a socket database connection

Jul 5 2017, 3:11 PM · Bug Report
mruuska added a comment to T11362: Arcanist tries to land onto identical remote branch instead of 'master'.

Thanks for the link. That's rather conceptual though. And things like overriding upstream landing is a thing that breaks compatibility with underlying SCM by assuming you use arc-feature. A tool specific explanation of the workflow would be great, for understanding the point of why things work the way they do. Though I'd rather the Official Workflow did not prevent other workflows. But I guess I have the power to remove that feature.

Jul 5 2017, 3:09 PM · Arcanist, Bug Report
chad closed T12899: Use socket to connect to database as Invalid.
Jul 5 2017, 2:59 PM · Bug Report
chad added a comment to T11362: Arcanist tries to land onto identical remote branch instead of 'master'.

Alternately, follow T5000 for a non arcanist workflow.

Jul 5 2017, 2:47 PM · Arcanist, Bug Report
phabmicha created T12899: Use socket to connect to database.
Jul 5 2017, 1:42 PM · Bug Report
mruuska added a comment to T11362: Arcanist tries to land onto identical remote branch instead of 'master'.

@chad: arc-patch requires a diff and pushing a branch is much simpler than creating a diff. Since we seem to be pushed into the direction of an official Phabricator workflow, is that documented somewhere? Phabricator makes assumptions about code structure, versioning and many kinds of things, but are they stated somewhere?

Jul 5 2017, 1:40 PM · Arcanist, Bug Report
chad added a comment to T11362: Arcanist tries to land onto identical remote branch instead of 'master'.

It's abnormal in Phabricator. I use arc patch to work from multiple machines.

Jul 5 2017, 1:16 PM · Arcanist, Bug Report
mruuska added a comment to T11362: Arcanist tries to land onto identical remote branch instead of 'master'.

This is a problem for us too. People push branches to work on it on another machine.

Jul 5 2017, 12:50 PM · Arcanist, Bug Report
chad closed T12898: Option to remove changes under a Diff ID from a Differential revision as Invalid.
Jul 5 2017, 6:29 AM · Bug Report
chad closed T12892: arc diff --update Created a new Differential revision not Update existing revision as Resolved.
Jul 5 2017, 6:24 AM · Bug Report
jbhateja updated the task description for T12898: Option to remove changes under a Diff ID from a Differential revision.
Jul 5 2017, 5:15 AM · Bug Report
jbhateja updated the task description for T12898: Option to remove changes under a Diff ID from a Differential revision.
Jul 5 2017, 5:14 AM · Bug Report
jbhateja created T12898: Option to remove changes under a Diff ID from a Differential revision.
Jul 5 2017, 5:14 AM · Bug Report
avivey closed T12897: Ambiguous URL rejection broke commit importing as Invalid.
Jul 5 2017, 3:16 AM · Bug Report
jbeck added a comment to T12897: Ambiguous URL rejection broke commit importing.

Sorry I hadn't updated my worker hosts, you can close this as invalid.

Jul 5 2017, 3:16 AM · Bug Report
jbeck updated the task description for T12897: Ambiguous URL rejection broke commit importing.
Jul 5 2017, 3:15 AM · Bug Report
avivey added a comment to T12897: Ambiguous URL rejection broke commit importing.

Is that a bad url that's contained in the commit message? Is the commit message literally Change the recognised url from showcase://?ITEM_ID to showcase://item/ITEM_ID where ITEMID is the ID of the showcase item?

Jul 5 2017, 3:14 AM · Bug Report
mnxheng added a comment to T12892: arc diff --update Created a new Differential revision not Update existing revision.

Oh I see. That's the problem. I tried repositor in the diffusion, it works well.
My fault, thank you guys. This task could be close.

Jul 5 2017, 2:59 AM · Bug Report
mnxheng added a comment to T12892: arc diff --update Created a new Differential revision not Update existing revision.

I did't add my git repositor into Diffusion. Does that matter?

Jul 5 2017, 2:37 AM · Bug Report
jbeck created T12897: Ambiguous URL rejection broke commit importing.
Jul 5 2017, 2:06 AM · Bug Report

Jul 4 2017

hach-que added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

I can try checking if SSH compression is enabled later today (but I doubt it; I'm just using the defaults). Keep in mind the upload speed to Phacility is 8 MiB/s, it's just the download speed that's 100 KiB/s.

Jul 4 2017, 9:35 PM · Feature Request
chad closed T12895: Do not include hidden .php files (like editor backups) as extensions as Wontfix.
Jul 4 2017, 3:09 PM · Bug Report
AndiDog created T12895: Do not include hidden .php files (like editor backups) as extensions.
Jul 4 2017, 2:57 PM · Bug Report
johnny-bit added a comment to T12892: arc diff --update Created a new Differential revision not Update existing revision.

instead of git branch once could use arc feature which does (I think) basically the same, but gives hint about what mindset to use where.

Jul 4 2017, 10:07 AM · Bug Report
chad added a comment to T12892: arc diff --update Created a new Differential revision not Update existing revision.

The arc workflow is:

Jul 4 2017, 9:34 AM · Bug Report
asherkin added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

Have you tried changing SSH options on your end, such as disabling compression or using weaker encryption ciphers (such as arcfour, no encryption cant be done without agreement of the server)? This can make a significant difference with SSH transfer speeds, and may function as a decent workaround for now.

Jul 4 2017, 9:33 AM · Feature Request
mnxheng added a comment to T12892: arc diff --update Created a new Differential revision not Update existing revision.

And here is the --trace information

Jul 4 2017, 6:59 AM · Bug Report
mnxheng added a comment to T12892: arc diff --update Created a new Differential revision not Update existing revision.

I create a new empty project on my gitlab and clone it to local. And add .arcconfig file then commit it. After that I ran the arc diff command and it create a new revision on phabricator.
When I want to update the existing revision, I modify a README.md file and ran arc diff --update <Revision Number>. It's create a new revision every single time.
I'm using Mac, and it's the same on my mate's Windows computer. I don't know why.
Maybe I didn't configure currectly. So I want to know where was wrong. Here is my phabricator information.

Jul 4 2017, 6:40 AM · Bug Report
hach-que updated the task description for T12891: Phacility does not currently offer instances in the Sydney region.
Jul 4 2017, 4:33 AM · Feature Request
hach-que added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

That's the obvious solution, but I'm not sure it's practical given Phacility's infrastructure.

Jul 4 2017, 4:31 AM · Feature Request
avivey added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

So probably, the actionables here are "Allow HTTPS in Phacility"?

Jul 4 2017, 3:49 AM · Feature Request
hach-que added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

It is for SSH - but compared with GitHub HTTPS it's much slower.

Jul 4 2017, 3:01 AM · Feature Request
avivey added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

It looks like it's the same speed?

Jul 4 2017, 2:46 AM · Feature Request
hach-que added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

Final statistics are in after letting it clone overnight. Let me know if you need any more information to diagnose speed issues.

Jul 4 2017, 2:26 AM · Feature Request
hach-que updated the task description for T12891: Phacility does not currently offer instances in the Sydney region.
Jul 4 2017, 2:25 AM · Feature Request

Jul 3 2017

avivey updated the task description for T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs.
Jul 3 2017, 6:14 PM · Arcanist, Bug Report
epriestley closed T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first) as Resolved by committing Restricted Diffusion Commit.
Jul 3 2017, 4:28 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley renamed T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first) from Install reporting an "exact match" issue with global search typeahead to Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first).
Jul 3 2017, 3:02 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley added a revision to T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first): Restricted Differential Revision.
Jul 3 2017, 2:27 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley added a comment to T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first).

This is an issue specific to the repository names containing hyphens. The code is already calling calling the correct sort functions.

Jul 3 2017, 2:25 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley added a comment to T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first).

I created these repositories:

Jul 3 2017, 2:14 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley updated the task description for T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first).
Jul 3 2017, 1:21 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley created T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first).
Jul 3 2017, 1:21 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley added a comment to T12892: arc diff --update Created a new Differential revision not Update existing revision.

I am unable to reproduce this problem given the instructions provided:

Jul 3 2017, 12:17 PM · Bug Report
mnxheng created T12892: arc diff --update Created a new Differential revision not Update existing revision.
Jul 3 2017, 12:01 PM · Bug Report
epriestley added a parent task for T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
Jul 3 2017, 10:48 AM · Arcanist, Bug Report
epriestley renamed T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs from ArcanistDiffParser fails to parse filenames to Improve parsing of unusual "git diff --no-index --no-prefix" diffs.
Jul 3 2017, 10:48 AM · Arcanist, Bug Report
epriestley triaged T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs as Wishlist priority.

That change fixed a lot of bugs, so we aren't going to revert it: reverting it would break all the things it fixed and added test cases for. --no-index --no-prefix diffs have never been part of the test suite and it is just coincidence that it worked before that change.

Jul 3 2017, 10:47 AM · Arcanist, Bug Report
Pawka added a comment to T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs.

--no-index - diff is created outside of repository by comparing directories.
--no-prefix - I'm not sure about this - some historical reasons and code in the service which generates diffs. But as I understand this was supported since D3744 and until rARCd0957c344156356123048be2219fb95a54c89a85.

Jul 3 2017, 10:40 AM · Arcanist, Bug Report
hach-que renamed T12891: Phacility does not currently offer instances in the Sydney region from Slow cloning on Phacility to Slow cloning over Phacility SSH for large repository.
Jul 3 2017, 6:25 AM · Feature Request
hach-que updated the task description for T12891: Phacility does not currently offer instances in the Sydney region.
Jul 3 2017, 6:20 AM · Feature Request
hach-que updated the task description for T12891: Phacility does not currently offer instances in the Sydney region.
Jul 3 2017, 5:24 AM · Feature Request
hach-que updated the task description for T12891: Phacility does not currently offer instances in the Sydney region.
Jul 3 2017, 5:23 AM · Feature Request
hach-que created T12891: Phacility does not currently offer instances in the Sydney region.
Jul 3 2017, 5:22 AM · Feature Request

Jul 2 2017

avivey closed T12889: Phabricator Setup Error as Invalid.

We don't maintain that instance. Please contact llvm.org directly for it.

Jul 2 2017, 5:43 PM · Bug Report
jbhateja created T12889: Phabricator Setup Error.
Jul 2 2017, 5:38 PM · Bug Report
chad closed T12888: repository.query doc points to invalid API diffusion.repository.query as Resolved by committing Restricted Diffusion Commit.
Jul 2 2017, 2:25 PM · Bug Report
chad added a revision to T12888: repository.query doc points to invalid API diffusion.repository.query: Restricted Differential Revision.
Jul 2 2017, 2:12 PM · Bug Report
quark.zju renamed T12888: repository.query doc points to invalid API diffusion.repository.query from `repository.query` points to invalid API `diffusion.repository.query` to repository.query doc points to invalid API diffusion.repository.query.
Jul 2 2017, 1:00 AM · Bug Report
quark.zju created T12888: repository.query doc points to invalid API diffusion.repository.query.
Jul 2 2017, 1:00 AM · Bug Report

Jun 30 2017

epriestley closed T12887: Can't add members to "parent project" when all subprojects are archived as Invalid.

Yes, this is expected. The process of converting a project to become a parent project can not be undone:

Jun 30 2017, 7:31 PM · Bug Report
chad added a comment to T12887: Can't add members to "parent project" when all subprojects are archived.

This behavior sounds correct to me.

Jun 30 2017, 7:27 PM · Bug Report
xp500 created T12887: Can't add members to "parent project" when all subprojects are archived.
Jun 30 2017, 7:23 PM · Bug Report
mplough added a comment to T12883: Harbormaster build completion information displays build start time.

Glad I could help! Thanks for getting the fix in so quickly!

Jun 30 2017, 4:05 PM · Bug Report
epriestley added a comment to T12883: Harbormaster build completion information displays build start time.

I believe your analysis and proposed change are correct. D18177 brings that change upstream. It is now available in master, and should promote to stable later today (within about 12 hours).

Jun 30 2017, 2:13 PM · Bug Report
epriestley closed T12883: Harbormaster build completion information displays build start time as Resolved by committing Restricted Diffusion Commit.
Jun 30 2017, 2:11 PM · Bug Report
epriestley added a comment to T12884: Diffusion claims that remote repos' clone URIs are disabled.

This should now be fixed in HEAD of master and promote to stable later today (within about 12 hours). This change hasn't been deployed to secure.phabricator.com yet but will be deployed no later that tomorrow morning (about 24 hours from now), at which point the example link you provided should start working.

Jun 30 2017, 2:11 PM · Diffusion, Bug Report
epriestley closed T12884: Diffusion claims that remote repos' clone URIs are disabled as Resolved by committing Restricted Diffusion Commit.
Jun 30 2017, 2:09 PM · Diffusion, Bug Report
epriestley added a revision to T12883: Harbormaster build completion information displays build start time: Restricted Differential Revision.
Jun 30 2017, 2:03 PM · Bug Report
epriestley claimed T12884: Diffusion claims that remote repos' clone URIs are disabled.
Jun 30 2017, 2:01 PM · Diffusion, Bug Report
epriestley added a revision to T12884: Diffusion claims that remote repos' clone URIs are disabled: Restricted Differential Revision.
Jun 30 2017, 2:01 PM · Diffusion, Bug Report
chad renamed T12886: Cannot upload file from Firefox (Android) from Cannot upload file from Firefox mobile to Cannot upload file from Firefox (Android).
Jun 30 2017, 6:49 AM · Android, Firefox, Bug Report
chad added a comment to T12886: Cannot upload file from Firefox (Android).

Firefox iOS seems fine

Jun 30 2017, 6:49 AM · Android, Firefox, Bug Report
shuLhan added a comment to T12886: Cannot upload file from Firefox (Android).

Testing upload from Android with Chrome:

Tangkapan layar_20170630-113846.png (1×1 px, 131 KB)

Jun 30 2017, 6:17 AM · Android, Firefox, Bug Report
chad renamed T12886: Cannot upload file from Firefox (Android) from Cannot upload file from mobile to Cannot upload file from Firefox mobile.
Jun 30 2017, 6:09 AM · Android, Firefox, Bug Report
chad added a comment to T12886: Cannot upload file from Firefox (Android).

I don't believe we've ever supported Firefox on mobile. Do you have the ability to use a different browser? Or are all browsers on Android non-operative here.

Jun 30 2017, 6:03 AM · Android, Firefox, Bug Report
shuLhan created T12886: Cannot upload file from Firefox (Android).
Jun 30 2017, 4:45 AM · Android, Firefox, Bug Report

Jun 29 2017

ephemeris updated the task description for T12884: Diffusion claims that remote repos' clone URIs are disabled.
Jun 29 2017, 9:43 PM · Diffusion, Bug Report
ephemeris created T12884: Diffusion claims that remote repos' clone URIs are disabled.
Jun 29 2017, 9:42 PM · Diffusion, Bug Report
mplough created T12883: Harbormaster build completion information displays build start time.
Jun 29 2017, 2:31 PM · Bug Report
chad closed T12881: testing form configurations as Invalid.

Please don't test this server. We will disable your account.

Jun 29 2017, 7:18 AM · Bug Report
exp10r3r created T12881: testing form configurations.
Jun 29 2017, 7:12 AM · Bug Report
avivey closed T11539: Phabricator Mercurial Repo “too many files open” error as Resolved.

Probably resolved.

Jun 29 2017, 4:32 AM · Bug Report

Jun 28 2017

epriestley closed T12878: online vicinity alert as Invalid.
Jun 28 2017, 11:47 AM · Bug Report
• Suvidya created T12878: online vicinity alert.
Jun 28 2017, 11:23 AM · Bug Report

Jun 27 2017

epriestley added a comment to T12870: Configuration check for "maniphest.priorities" does not validate that keywords are unique across priorities.

At HEAD of master:

Jun 27 2017, 7:37 PM · Maniphest, Bug Report