Page MenuHomePhabricator
Feed Advanced Search

Sep 18 2016

hach-que added a comment to T10747: Import and export ICS from Calendar.

(comment posted twice for some reason)

Sep 18 2016, 10:46 PM · Restricted Project, Prioritized, Calendar
hach-que added a comment to T10747: Import and export ICS from Calendar.

I thought I'd throw our use case in here in case it helps:

Sep 18 2016, 10:46 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

More generally, here's how I'm planning to model imports, which seems largely consistent with other systems:

Sep 18 2016, 2:02 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

Yeah, I fiddled with that but didn't immediately have any luck. It's possible that there's some complex condition like non-self organizer + non-self sender or something. If it only requires non-organizer, it should already work today (e.g., on this install).

Sep 18 2016, 1:18 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T7944: Add Conduit support to Calendar.

Sort of. I'd like to have use cases (what are you trying to do?) first, and I'm not certain what the best representation of dates and times is for external consumption.

Sep 18 2016, 1:15 PM · Conduit, Calendar
20after4 added a comment to T7944: Add Conduit support to Calendar.

@epriestley: Are you open to patches that add more information to the calendar.event.search response? It currently does not even include the event time which is a pretty crucial detail to make the results useful.

Sep 18 2016, 4:00 AM · Conduit, Calendar

Sep 15 2016

hach-que added a comment to T10747: Import and export ICS from Calendar.

@epriestley in that post you linked there's a comment:

Sep 15 2016, 10:33 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Restricted Differential Revision.
Sep 15 2016, 2:01 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

I'm having trouble making GMail provide a reasonable pathway forward for getting .ics events onto Google Calendar. Ostensibly this just works:

Sep 15 2016, 1:58 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Restricted Differential Revision.
Sep 15 2016, 1:14 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Restricted Differential Revision.
Sep 15 2016, 12:59 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

ICS primarily identifies users (organizers and attendees) by email address. Phabricator does not normally disclose email addresses, and I don't want to let someone scrape every email address out of Phabricator by inviting every user to an event and downloading the .ics.

Sep 15 2016, 12:30 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Restricted Differential Revision.
Sep 15 2016, 12:19 AM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Restricted Differential Revision.
Sep 15 2016, 12:10 AM · Restricted Project, Prioritized, Calendar

Sep 14 2016

epriestley created T11638: "Create Event" from day view does not default to visible day.
Sep 14 2016, 11:59 PM · Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Restricted Differential Revision.
Sep 14 2016, 8:50 PM · Restricted Project, Prioritized, Calendar

Sep 13 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Restricted Differential Revision.
Sep 13 2016, 7:50 PM · Restricted Project, Prioritized, Calendar

Sep 8 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Restricted Differential Revision.
Sep 8 2016, 10:49 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Restricted Differential Revision.
Sep 8 2016, 8:49 PM · Restricted Project, Prioritized, Calendar
epriestley closed T11396: Calendar stub events do not respect recurring event end dates as Resolved by committing Restricted Diffusion Commit.
Sep 8 2016, 5:20 PM · Restricted Project, Calendar
epriestley added a revision to T11396: Calendar stub events do not respect recurring event end dates: Restricted Differential Revision.
Sep 8 2016, 4:16 PM · Restricted Project, Calendar

Sep 7 2016

20after4 added a comment to T11399: Add support for locations in calendar events.

IMO, Pokémon catching is an essential feature, please implement that first.

Sep 7 2016, 11:51 PM · Calendar, Feature Request

Sep 2 2016

epriestley closed T11576: Typo at calendar transaction as Resolved.

Resolved by D16488.

Sep 2 2016, 1:19 PM · Calendar, Bug Report
Luke081515.2 added a revision to T11576: Typo at calendar transaction: Unknown Object (Differential Revision).
Sep 2 2016, 1:12 PM · Calendar, Bug Report
Luke081515.2 created T11576: Typo at calendar transaction.
Sep 2 2016, 12:59 PM · Calendar, Bug Report

Aug 31 2016

epriestley added a revision to T7924: Unprototype Calendar (v1): Restricted Differential Revision.
Aug 31 2016, 10:13 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T7924: Unprototype Calendar (v1).

Well, "trivial" might be a little ambitious.

Aug 31 2016, 9:54 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T7924: Unprototype Calendar (v1).

Ah, thanks! That's a bug which we hadn't run into yet, but it's trivial to fix.

Aug 31 2016, 9:50 PM · Restricted Project, Prioritized, Calendar
polybuildr added a comment to T7924: Unprototype Calendar (v1).

When tasks are mentioned in calendar descriptions (afaik very common for meeting agendas), the usual "<user> mentioned this in <place>" does not show up on the task. Is this part of the unprototyping effort?

Aug 31 2016, 9:34 PM · Restricted Project, Prioritized, Calendar

Aug 16 2016

robertkraig added a comment to T2334: Implement Google Calendar v3 API into Calendar.

I'm super excited about this feature.

Aug 16 2016, 6:52 PM · Restricted Project, Prioritized, Calendar

Aug 6 2016

epriestley closed T7939: Support Herald rules for Calendar events as Resolved by committing Restricted Diffusion Commit.
Aug 6 2016, 9:37 PM · Herald, Calendar
epriestley closed T7939: Support Herald rules for Calendar events, a subtask of T7926: Modernize Calendar Infrastructure, as Resolved.
Aug 6 2016, 9:37 PM · Calendar

Aug 5 2016

eadler added a project to T7924: Unprototype Calendar (v1): Restricted Project.
Aug 5 2016, 5:23 PM · Restricted Project, Prioritized, Calendar
eadler added a project to T10747: Import and export ICS from Calendar: Restricted Project.
Aug 5 2016, 5:23 PM · Restricted Project, Prioritized, Calendar
eadler added a project to T11396: Calendar stub events do not respect recurring event end dates: Restricted Project.
Aug 5 2016, 5:23 PM · Restricted Project, Calendar

Aug 3 2016

epriestley added a revision to T7939: Support Herald rules for Calendar events: Restricted Differential Revision.
Aug 3 2016, 11:46 PM · Herald, Calendar
epriestley closed T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess, a subtask of T7939: Support Herald rules for Calendar events, as Resolved.
Aug 3 2016, 11:12 PM · Herald, Calendar

Aug 1 2016

epriestley merged T11408: Invitees for recurring event are listed in reverse order into T11326: Improve Calendar v1 Design/UI/UX.
Aug 1 2016, 10:17 AM · Design, Calendar
epriestley merged task T11408: Invitees for recurring event are listed in reverse order into T11326: Improve Calendar v1 Design/UI/UX.
Aug 1 2016, 10:17 AM · Calendar, Bug Report
ivo created T11408: Invitees for recurring event are listed in reverse order.
Aug 1 2016, 10:15 AM · Calendar, Bug Report

Jul 30 2016

epriestley moved T7939: Support Herald rules for Calendar events from Backlog to Next on the Herald board.
Jul 30 2016, 12:28 PM · Herald, Calendar
epriestley added a subtask for T7939: Support Herald rules for Calendar events: T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.
Jul 30 2016, 11:48 AM · Herald, Calendar
epriestley added a comment to T11399: Add support for locations in calendar events.

Calendar is currently prioritized, but the scope is focused on basic functionality (getting it out of the "prototype" stage, roughly described in T11326 with more recent activity in T11326) and API integrations (Google Calendar in T2334, ICS in T10747).

Jul 30 2016, 11:47 AM · Calendar, Feature Request
epriestley claimed T7931: Create Calendar triggers which notify users before meetings.
Jul 30 2016, 11:45 AM · Calendar
epriestley claimed T7939: Support Herald rules for Calendar events.
Jul 30 2016, 11:45 AM · Herald, Calendar
epriestley moved T7931: Create Calendar triggers which notify users before meetings from Future Work (v2+) to Unprototype (v1) on the Calendar board.
Jul 30 2016, 11:43 AM · Calendar
epriestley moved T11399: Add support for locations in calendar events from Backlog to Future Work (v2+) on the Calendar board.
Jul 30 2016, 11:34 AM · Calendar, Feature Request
epriestley added a comment to T11399: Add support for locations in calendar events.

I expect to do this eventually, but I'm hesitant to just put a freeform "Location" text field on events. If we do, we can't prevent double-booking physical meeting rooms, since users may spell physical space names differently and we can't know for sure that "Meeting 6", "Meeting Room 6", "Meting Rum Six", and "Meeting Room#6" are all the same.

Jul 30 2016, 11:33 AM · Calendar, Feature Request
helenhousandi updated the task description for T11399: Add support for locations in calendar events.
Jul 30 2016, 4:04 AM · Calendar, Feature Request
helenhousandi created T11399: Add support for locations in calendar events.
Jul 30 2016, 4:00 AM · Calendar, Feature Request

Jul 29 2016

epriestley created T11396: Calendar stub events do not respect recurring event end dates.
Jul 29 2016, 5:19 PM · Restricted Project, Calendar

Jul 28 2016

epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Jul 28 2016, 10:53 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Restricted Differential Revision.
Jul 28 2016, 2:55 PM · Design, Calendar

Jul 27 2016

eadler added a project to T2334: Implement Google Calendar v3 API into Calendar: Restricted Project.
Jul 27 2016, 6:49 PM · Restricted Project, Prioritized, Calendar
chad added a comment to T2334: Implement Google Calendar v3 API into Calendar.

See T7924 for current Calendar roadmap items.

Jul 27 2016, 6:34 PM · Restricted Project, Prioritized, Calendar
• carlos22 updated subscribers of T2334: Implement Google Calendar v3 API into Calendar.

So CalDAV support (for iCloud and others) is not planned? Google Calendar API is propritary while CalDAV is a standard. There is a really good php implementation of client/server and card parsers: https://github.com/fruux/sabre-dav
@devurandom yes that is true, and it is really simple using save/dav.

Jul 27 2016, 6:15 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T11326: Improve Calendar v1 Design/UI/UX.

I think you're free to fiddle -- there are some more adjustments and things, but nothing too significant. I think the only other really CSS-ish thing is that if you search for events in a specific range (July 5-7) on a calendar view, I'd like to make it clear which days your query covers.

Jul 27 2016, 5:52 PM · Design, Calendar
chad added a comment to T11326: Improve Calendar v1 Design/UI/UX.

land what you got and I can start fiddling? or did you have more?

Jul 27 2016, 5:33 PM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Jul 27 2016, 5:15 PM · Design, Calendar
epriestley closed T8361: Add a "click to see more" link to month view days with more than 15 events. as Resolved by committing Restricted Diffusion Commit.
Jul 27 2016, 4:44 PM · Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Restricted Differential Revision.
Jul 27 2016, 4:15 PM · Design, Calendar
epriestley added a revision to T8361: Add a "click to see more" link to month view days with more than 15 events.: Restricted Differential Revision.
Jul 27 2016, 3:25 PM · Calendar
epriestley claimed T8361: Add a "click to see more" link to month view days with more than 15 events..
Jul 27 2016, 3:15 PM · Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Jul 27 2016, 2:25 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Restricted Differential Revision.
Jul 27 2016, 2:25 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Restricted Differential Revision.
Jul 27 2016, 2:01 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Restricted Differential Revision.
Jul 27 2016, 1:50 PM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Jul 27 2016, 12:00 PM · Design, Calendar

Jul 26 2016

epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Restricted Differential Revision.
Jul 26 2016, 6:23 PM · Design, Calendar

Jul 22 2016

Luke081515.2 added a comment to T11339: Calendar: Inviting / uninviting transactions omit key information.

Thanks :).

Jul 22 2016, 11:55 PM · Calendar, Bug Report
avivey closed T11339: Calendar: Inviting / uninviting transactions omit key information as Resolved by committing Restricted Diffusion Commit.
Jul 22 2016, 6:03 PM · Calendar, Bug Report

Jul 18 2016

• qinliming added a watcher for Calendar: • qinliming.
Jul 18 2016, 11:10 AM

Jul 17 2016

avivey added a revision to T11339: Calendar: Inviting / uninviting transactions omit key information: Restricted Differential Revision.
Jul 17 2016, 7:50 PM · Calendar, Bug Report
avivey added a comment to T11339: Calendar: Inviting / uninviting transactions omit key information.

Maybe I shouldn't debug things before coffee. getChanges is fine, the problem is something else; I think the recorded information might be wrong.

Jul 17 2016, 7:19 PM · Calendar, Bug Report
avivey added a comment to T11339: Calendar: Inviting / uninviting transactions omit key information.

Not a rendering bug, it's a translation: https://secure.phabricator.com/diffusion/P/browse/master/src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php$1571

Jul 17 2016, 7:09 PM · Calendar, Bug Report
avivey added a comment to T11339: Calendar: Inviting / uninviting transactions omit key information.

Mostly, that's because getChanges in PhabricatorCalendarEventInviteTransaction is wrong - the phids in this transaction are in keys, not values.

Jul 17 2016, 6:55 PM · Calendar, Bug Report
avivey renamed T11339: Calendar: Inviting / uninviting transactions omit key information from Calendar: Inviting / uninviting throws strange messages to Calendar: Inviting / uninviting transactions omit key information.
Jul 17 2016, 6:34 PM · Calendar, Bug Report

Jul 16 2016

Luke081515.2 created T11339: Calendar: Inviting / uninviting transactions omit key information.
Jul 16 2016, 6:13 PM · Calendar, Bug Report

Jul 15 2016

epriestley closed T8208: Create a plan for consistent use of icons, colors and text style when rendering Calendar events as Resolved.

I think most of this is in reasonable shape now, at least for the moment.

Jul 15 2016, 9:23 PM · Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Restricted Differential Revision.
Jul 15 2016, 9:20 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Restricted Differential Revision.
Jul 15 2016, 9:04 PM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Jul 15 2016, 9:03 PM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Jul 15 2016, 7:26 PM · Design, Calendar
epriestley moved T11326: Improve Calendar v1 Design/UI/UX from Backlog to Unprototype (v1) on the Calendar board.
Jul 15 2016, 7:25 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Restricted Differential Revision.
Jul 15 2016, 7:10 PM · Design, Calendar
epriestley updated the task description for T11326: Improve Calendar v1 Design/UI/UX.
Jul 15 2016, 7:05 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Restricted Differential Revision.
Jul 15 2016, 5:30 PM · Design, Calendar
epriestley added a comment to T11326: Improve Calendar v1 Design/UI/UX.

I spent pretty much the whole afternoon yesterday getting "All Day" events working properly without getting a result I was happy with (some of this was untangling date controls, which will probably come upstream eventually).

Jul 15 2016, 3:29 PM · Design, Calendar

Jul 14 2016

epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Restricted Differential Revision.
Jul 14 2016, 8:06 PM · Design, Calendar
chad added a comment to T11326: Improve Calendar v1 Design/UI/UX.

I'll have my laptop with me next week, should be easy for me to clean up CSS stuff on the road.

Jul 14 2016, 8:05 PM · Design, Calendar
chad added a comment to T11326: Improve Calendar v1 Design/UI/UX.

Visually, I have a hard time picking out the current day/week.

Jul 14 2016, 8:04 PM · Design, Calendar
chad added a comment to T11326: Improve Calendar v1 Design/UI/UX.

Use of link color to convey state is weird?

Jul 14 2016, 8:04 PM · Design, Calendar
chad added a comment to T11326: Improve Calendar v1 Design/UI/UX.

I'll CSS in the event details later, but wanted this to go full width if possible.

Jul 14 2016, 7:36 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Restricted Differential Revision.
Jul 14 2016, 5:23 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Restricted Differential Revision.
Jul 14 2016, 5:09 PM · Design, Calendar
epriestley added a comment to T11326: Improve Calendar v1 Design/UI/UX.

My test data is pretty sketchy:

Jul 14 2016, 5:05 PM · Design, Calendar
chad added a comment to T11326: Improve Calendar v1 Design/UI/UX.

got a full screenshot?

Jul 14 2016, 5:04 PM · Design, Calendar
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Restricted Differential Revision.
Jul 14 2016, 4:59 PM · Design, Calendar
epriestley added a comment to T11326: Improve Calendar v1 Design/UI/UX.

I poked at it a little bit but only got this far:

Jul 14 2016, 4:45 PM · Design, Calendar
chad added a comment to T11326: Improve Calendar v1 Design/UI/UX.

I'll get you an update month view here this afternoon, I've been mulling it over.

Jul 14 2016, 4:27 PM · Design, Calendar