Page MenuHomePhabricator
Feed Advanced Search

Apr 12 2015

joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 12:01 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 12:00 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 11:59 AM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 11:49 AM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Unknown Object (Differential Revision).
Apr 12 2015, 11:35 AM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Unknown Object (Differential Revision).
Apr 12 2015, 11:24 AM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 10:21 AM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Unknown Object (Differential Revision).
Apr 12 2015, 10:05 AM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 12 2015, 8:52 AM · Lint

Apr 11 2015

joshuaspence closed T7801: XHPAST is behaving strangely as Resolved by committing Restricted Diffusion Commit.
Apr 11 2015, 11:50 PM · XHPAST

Apr 10 2015

jdloft awarded T5657: Ability to rename flags a Manufacturing Defect? token.
Apr 10 2015, 4:43 PM · Contributor Onboarding, Restricted Project, Flags
joshuaspence added a revision to T7801: XHPAST is behaving strangely: Unknown Object (Differential Revision).
Apr 10 2015, 1:58 PM · XHPAST
joshuaspence added a comment to T7801: XHPAST is behaving strangely.

Actually, nevermind... my development install was a bit old. I can replicate this on my development host.

Apr 10 2015, 1:28 PM · XHPAST
joshuaspence created T7801: XHPAST is behaving strangely.
Apr 10 2015, 1:25 PM · XHPAST

Apr 9 2015

argylelabcoat awarded T5031: Draft Comment Persists After Submission a Haypence token.
Apr 9 2015, 4:05 PM · Restricted Project, Support Impact, Mobile

Apr 8 2015

joshuaspence added a revision to T7409: Implement PHPCS lints: Unknown Object (Differential Revision).
Apr 8 2015, 1:57 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 8 2015, 1:56 PM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Unknown Object (Differential Revision).
Apr 8 2015, 1:42 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 8 2015, 1:41 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 8 2015, 1:28 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Apr 8 2015, 1:24 PM · Lint
joshuaspence created T7778: "Unknown Object (????)" in outbound email.
Apr 8 2015, 5:56 AM · Mail

Apr 7 2015

joshuaspence added a comment to T7611: Transaction type 'differential:action' is missing an internal apply implementation.

Nope, I haven't seen this issue since 18 March.

Apr 7 2015, 10:33 PM · Transactions, Differential
joshuaspence added a comment to T7600: Two-up inline row scaffold must have at most two inline views.

This doesn't seem to have too often, roughly twice per day.

Apr 7 2015, 10:31 PM · Differential
joshuaspence updated the task description for T7600: Two-up inline row scaffold must have at most two inline views.
Apr 7 2015, 10:30 PM · Differential
joshuaspence added a comment to T5694: AphrontWriteGuard was not properly disposed of.

FWIW, I'm seeing this roughly 60 times per day in our error logs.

Apr 7 2015, 10:29 PM · Aphront
joshuaspence updated the task description for T7483: Invalid argument supplied for foreach.
Apr 7 2015, 10:27 PM · Differential
joshuaspence added a comment to T7483: Invalid argument supplied for foreach.

FWIW, we see this around 15 times per day (just grepping our PHP error logs).

Apr 7 2015, 10:26 PM · Differential
joshuaspence added a comment to T7562: Invalid argument supplied for foreach().
Apr 7 2015, 10:26 PM · Arcanist
joshuaspence added a comment to T7611: Transaction type 'differential:action' is missing an internal apply implementation.

Let me dig through our error logs.

Apr 7 2015, 9:50 PM · Transactions, Differential

Apr 6 2015

joshuaspence edited P1753 preg_replace_callback(): Unknown modifier '\'.
Apr 6 2015, 10:56 PM
joshuaspence added a comment to T7768: Status codes seem incorrect.

Oh right. I would've expected a 302 to /auth/login/ or similar.

Apr 6 2015, 10:00 PM · Aphront
joshuaspence closed T7486: All responses use "OK" as the status text as Resolved by committing Restricted Diffusion Commit.
Apr 6 2015, 9:43 PM · Aphront
joshuaspence created T7768: Status codes seem incorrect.
Apr 6 2015, 9:32 PM · Aphront
joshuaspence closed T7464: jshint.jshintignore not working as Resolved by committing Restricted Diffusion Commit.
Apr 6 2015, 9:26 PM · Lint
joshuaspence closed T7502: Add doclink for Diviner as Resolved by committing Restricted Diffusion Commit.
Apr 6 2015, 9:24 PM · Diviner, Documentation
joshuaspence added a revision to T7486: All responses use "OK" as the status text: Unknown Object (Differential Revision).
Apr 6 2015, 12:53 PM · Aphront
joshuaspence added a revision to T7464: jshint.jshintignore not working: Unknown Object (Differential Revision).
Apr 6 2015, 12:36 PM · Lint
joshuaspence placed T7594: Having trouble with chunked uploads up for grabs.
Apr 6 2015, 12:18 PM · Files
joshuaspence placed T7483: Invalid argument supplied for foreach up for grabs.
Apr 6 2015, 12:16 PM · Differential
johnny-bit awarded T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings a Like token.
Apr 6 2015, 11:54 AM · Arcanist

Apr 5 2015

joshuaspence created T7764: Default monospaced font shows as blank.
Apr 5 2015, 2:29 AM · User Preferences
joshuaspence added a comment to T7762: Display Preferences text box is too wide on mobile.

The monospaced text also overflows:

Apr 5 2015, 2:26 AM · User Preferences, Mobile
joshuaspence added a comment to T7763: Hard to add files on mobile.

I thought that this might be closed as a duplicate... Although I think that adding "File" to the quick create menu might be a quick win here... Is there any specific objection to this?

Apr 5 2015, 2:23 AM · Mobile, Files
joshuaspence created T7763: Hard to add files on mobile.
Apr 5 2015, 1:53 AM · Mobile, Files
joshuaspence created T7762: Display Preferences text box is too wide on mobile.
Apr 5 2015, 1:50 AM · User Preferences, Mobile

Apr 2 2015

joshuaspence added a project to T7732: Convoluted flow when locked out of account with only one auth provider: Auth.
Apr 2 2015, 12:25 PM · Restricted Project, Auth

Mar 31 2015

joshuaspence added a comment to T1460: Add "Done" link to an inline comment.

(At the same time, I hesitate a bit because having the icons up there be totally different for every comment is also weird.)

New inline comments are really awesome overall, though.

Mar 31 2015, 12:55 AM · User Delight, Differential

Mar 30 2015

joshuaspence added a comment to T7701: Surface Code/File search better in Diffusion.

Yeah, I vaguely remember there being a task.

Mar 30 2015, 9:00 PM · Restricted Project, Design, Diffusion
joshuaspence added a comment to T7701: Surface Code/File search better in Diffusion.

On an unrelated note... Is there a reason why {Fxxx} doesn't show the image content in emails?

Mar 30 2015, 8:56 PM · Restricted Project, Design, Diffusion
joshuaspence added a comment to T7701: Surface Code/File search better in Diffusion.

Oh wow, I've never seen that before.

Mar 30 2015, 8:55 PM · Restricted Project, Design, Diffusion
joshuaspence created T7701: Surface Code/File search better in Diffusion.
Mar 30 2015, 8:51 PM · Restricted Project, Design, Diffusion
joshuaspence created T7687: Couldn't create GD Image Stream out of Data.
Mar 30 2015, 12:16 AM · Arcanist, Files

Mar 26 2015

nemobis awarded T2226: Include a setup test for gzip enabled on the server a Mountain of Wealth token.
Mar 26 2015, 1:09 PM · Setup
joshuaspence added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

OK, I've managed to reproduce this issue. It only happen in the "Sort by priority" view (not in the "Natural" view).

Mar 26 2015, 5:59 AM · Restricted Project, Workboards
joshuaspence created T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).
Mar 26 2015, 5:56 AM · Restricted Project, Workboards

Mar 23 2015

joshuaspence added a revision to T7409: Implement PHPCS lints: Unknown Object (Differential Revision).
Mar 23 2015, 8:23 PM · Lint
joshuaspence added a revision to T7409: Implement PHPCS lints: Unknown Object (Differential Revision).
Mar 23 2015, 1:13 PM · Lint
joshuaspence updated the task description for T7409: Implement PHPCS lints.
Mar 23 2015, 12:55 PM · Lint

Mar 21 2015

joshuaspence added a comment to T7611: Transaction type 'differential:action' is missing an internal apply implementation.

How would one do that exactly?

Mar 21 2015, 11:46 AM · Transactions, Differential

Mar 20 2015

joshuaspence added a comment to T7594: Having trouble with chunked uploads.

Damn, seems like an issue with the PHP build that I am using. https://bugs.launchpad.net/ubuntu/+source/php5/+bug/1006738

Mar 20 2015, 4:03 AM · Files

Mar 19 2015

joshuaspence added a comment to T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings.

Yeah, that seems reasonable.

Mar 19 2015, 8:15 AM · Arcanist
joshuaspence added a comment to T7594: Having trouble with chunked uploads.

Oh nice, I saw this in /var/log/syslog:

Mar 19 2015, 7:11 AM · Files
joshuaspence added a comment to T7594: Having trouble with chunked uploads.

OK interesting...

Mar 19 2015, 2:27 AM · Files

Mar 17 2015

joshuaspence added a comment to T7594: Having trouble with chunked uploads.

Nope, nothing in the error logs on the server.

Mar 17 2015, 9:21 PM · Files
joshuaspence created T7611: Transaction type 'differential:action' is missing an internal apply implementation.
Mar 17 2015, 9:08 PM · Transactions, Differential
joshuaspence reopened T7594: Having trouble with chunked uploads as "Open".

OK. I'm having some more issues...

Mar 17 2015, 9:07 PM · Files
joshuaspence added a revision to T6875: Merge Chatlog into Conpherence, or remove it: Unknown Object (Differential Revision).
Mar 17 2015, 1:21 PM · Chatlog, Conpherence
joshuaspence added a project to T7604: Remove "Arcanist Projects": Diffusion.
Mar 17 2015, 1:15 PM · Diffusion
joshuaspence created T7604: Remove "Arcanist Projects".
Mar 17 2015, 1:15 PM · Diffusion
joshuaspence created T7603: Remove the deprecated "Repositories" application.
Mar 17 2015, 1:13 PM · Repositories, Diffusion
joshuaspence closed T7594: Having trouble with chunked uploads as Resolved.
Mar 17 2015, 12:51 PM · Files
joshuaspence added a comment to T7594: Having trouble with chunked uploads.

OK, thanks for clarifying.

Mar 17 2015, 12:51 PM · Files
joshuaspence added a comment to T7601: Herald edit log bypasses policy checks.

I suppose that the Herald Transcripts have a similar issue.

Mar 17 2015, 12:45 PM · Herald
joshuaspence created T7602: Updating an abandoned diff should reclaim the revision.
Mar 17 2015, 12:43 PM · Differential
joshuaspence added a comment to T7594: Having trouble with chunked uploads.

So where does 32MB come from? If I set the filesize limit to 8MB, why do I need to set the nginx/PHP limits to 32MB?

Mar 17 2015, 12:42 PM · Files
joshuaspence created T7601: Herald edit log bypasses policy checks.
Mar 17 2015, 12:40 PM · Herald
joshuaspence added a comment to T7594: Having trouble with chunked uploads.

So, setting a filesize limit allows me to upload files with an unlimited size?

Mar 17 2015, 12:32 PM · Files
joshuaspence added a revision to T7483: Invalid argument supplied for foreach: Unknown Object (Differential Revision).
Mar 17 2015, 11:46 AM · Differential
joshuaspence added a revision to T7502: Add doclink for Diviner: Unknown Object (Differential Revision).
Mar 17 2015, 11:32 AM · Diviner, Documentation
joshuaspence added a comment to T7594: Having trouble with chunked uploads.

It seems that my custom PhabricatorFileStorageEngine class is being selected instead of PhabricatorChunkedFileStorageEngine. If I manually decrease the priority of PhabricatorChunkedFileStorageEngine to 0, I am able to perform a chunked upload.

Mar 17 2015, 10:47 AM · Files
joshuaspence created T7600: Two-up inline row scaffold must have at most two inline views.
Mar 17 2015, 10:35 AM · Differential
joshuaspence created T7599: Unable to find a place to insert object on column.
Mar 17 2015, 10:34 AM · Projects
joshuaspence created T7598: Expected a numeric scalar or null for %Ld conversion.
Mar 17 2015, 10:33 AM · Conduit
joshuaspence added a comment to T7594: Having trouble with chunked uploads.
My Phabricator Installation
> arc --conduit-uri=https://phabricator.example.com --trace upload large-file
libphutil loaded from '/home/joshua/dotfiles/modules/phabricator/libphutil/src'.
arcanist loaded from '/home/joshua/dotfiles/modules/phabricator/arcanist/src'.
Config: Reading user configuration file "/home/joshua/.arcrc"...
Config: Did not find system configuration at "/etc/arcconfig".
Working Copy: No candidate locations for .arcconfig from this working directory.
Working Copy: Path "/home/joshua" is not in any working copy.
>>> [0] <conduit> conduit.connect() <bytes = 586>
>>> [1] <http> https://phabricator.example.com/api/conduit.connect
<<< [1] <http> 3,184,008 us
<<< [0] <conduit> 3,184,671 us
Uploading 'large-file'...
>>> [2] <conduit> file.allocate() <bytes = 295>
>>> [3] <http> https://phabricator.example.com/api/file.allocate
<<< [3] <http> 614,302 us
<<< [2] <conduit> 614,989 us
>>> [4] <conduit> file.upload() <bytes = 209715421>
>>> [5] <http> https://phabricator.example.com/api/file.upload
<<< [5] <http> 1,327,965 us
<<< [4] <conduit> 1,328,623 us
Mar 17 2015, 9:51 AM · Files
joshuaspence added a comment to T7594: Having trouble with chunked uploads.

Ah. I did try testing it out on this install with a 100MB file. Perhaps I shall try with a larger file instead.

Mar 17 2015, 8:22 AM · Files
joshuaspence added a comment to T7594: Having trouble with chunked uploads.

I suspect this is an nginx thing.

Mar 17 2015, 4:33 AM · Files
joshuaspence updated subscribers of T7594: Having trouble with chunked uploads.
Mar 17 2015, 2:52 AM · Files
joshuaspence created T7594: Having trouble with chunked uploads.
Mar 17 2015, 2:51 AM · Files

Mar 15 2015

joshuaspence created T7562: Invalid argument supplied for foreach().
Mar 15 2015, 11:05 PM · Arcanist

Mar 11 2015

joshuaspence added a comment to T5843: Make storage backends extensible.

This might be fixed by D11224.

Mar 11 2015, 8:42 PM · Database

Mar 8 2015

joshuaspence added a comment to T7508: "Create New User" should be shown to all users.

It just seems inconsistent to sometimes hide the button and show a grayed-out button in other places.

Mar 8 2015, 9:05 AM · People
joshuaspence added a comment to T7508: "Create New User" should be shown to all users.

Specifically, PhabricatorPeopleListController has this code:

Mar 8 2015, 4:40 AM · People
joshuaspence created T7508: "Create New User" should be shown to all users.
Mar 8 2015, 4:38 AM · People
joshuaspence created T7507: Should return to previous page after clicking "OK".
Mar 8 2015, 4:33 AM · Policy
joshuaspence added a comment to T7176: Refreshing the page in Chrome no longer jumps to the correct position.

I have a similar issue which I believe is worth fixing. If I am reading through a list of search results and then click on one of the results, clicking the "Back" button returns to the top of the search results (previously, I believe the position on the page would be retained).

Mar 8 2015, 1:41 AM · PHUI
joshuaspence claimed T7478: Inbound email is wrapped when sent from Gmail.
Mar 8 2015, 1:27 AM · Mail
joshuaspence added a comment to T7480: Allow editing the name of a file.

I don't know if this way an explicit product decision, but I don't think there is any technical reason we don't allow this.

Mar 8 2015, 1:26 AM · Files
joshuaspence claimed T7483: Invalid argument supplied for foreach.
Mar 8 2015, 1:24 AM · Differential
joshuaspence claimed T7486: All responses use "OK" as the status text.

I might give this a go.

Mar 8 2015, 1:23 AM · Aphront