Page MenuHomePhabricator
Feed Advanced Search

Apr 2 2015

epriestley added a comment to T7730: Herald queries show object rules as global rules.

Sure, we'd be happy to accept a patch for this.

Apr 2 2015, 2:37 AM · Herald
epriestley added a comment to T7731: Make "Send me an email" force mail delivery through notification preferences.

The project/global version of this ("Send an email to...") probably should not override user preferences. The user version ("Send me an email") is always user-controlled.

Apr 2 2015, 2:24 AM · Herald
epriestley added a revision to T7521: `arc land` should work even when the repo has untracked files: Unknown Object (Differential Revision).
Apr 2 2015, 2:22 AM · Restricted Project, Arcanist
epriestley added a revision to T7712: Files via email (some) seem not to set author or to mirror "normal" task policy: Unknown Object (Differential Revision).
Apr 2 2015, 2:15 AM · Policy, Wikimedia, Maniphest
epriestley reopened T7484: Lock is not locked by this process as "Open".

I guess you could try this? Maybe?

Apr 2 2015, 2:08 AM · Restricted Project, Daemons
epriestley created T7731: Make "Send me an email" force mail delivery through notification preferences.
Apr 2 2015, 1:25 AM · Herald
epriestley added a comment to T7484: Lock is not locked by this process.

The order which we update repositories is deterministic enough that I'd expect things to usually end up locking in the same order, and they'll keep retrying regularly (every 15 seconds) after a failure, so it's not particularly surprising to me that the failures wouldn't be randomly distributed if the issue is a 64-character lock uniqueness limit, although I would expect us to see way more failures all the time since 64 characters ends before the callsign part and we haven't changed the lock name. Maybe the behavior is specific to your MySQL sub-version.

Apr 2 2015, 1:15 AM · Restricted Project, Daemons
epriestley added a comment to T7484: Lock is not locked by this process.

Does this patch also fix it?

Apr 2 2015, 1:11 AM · Restricted Project, Daemons
epriestley updated subscribers of T7521: `arc land` should work even when the repo has untracked files.

Context on this:

Apr 2 2015, 1:07 AM · Restricted Project, Arcanist
epriestley added a comment to T7484: Lock is not locked by this process.

Can you see if this fixes it (bringing lock name length under 64 characters):

Apr 2 2015, 12:47 AM · Restricted Project, Daemons
epriestley added a comment to T7484: Lock is not locked by this process.

It's also possible that this:

Apr 2 2015, 12:44 AM · Restricted Project, Daemons
epriestley added a comment to T7484: Lock is not locked by this process.

MySQL 5.7.5 and later enforces a maximum length on lock names of 64 characters. Previously, no limit was enforced.

Apr 2 2015, 12:43 AM · Restricted Project, Daemons
epriestley added a comment to T7484: Lock is not locked by this process.

Okay, that is the lock failing to acquire. Does this work?

Apr 2 2015, 12:40 AM · Restricted Project, Daemons
epriestley closed T7484: Lock is not locked by this process as Resolved by committing Restricted Diffusion Commit.
Apr 2 2015, 12:37 AM · Restricted Project, Daemons

Apr 1 2015

epriestley added a comment to T7484: Lock is not locked by this process.

Hrrm. Maybe wait for D12253 and see if that provides any clarity. It's possible it will give us a much better and more specific message, rather than just degrading into T6958.

Apr 1 2015, 11:47 PM · Restricted Project, Daemons
epriestley claimed T7712: Files via email (some) seem not to set author or to mirror "normal" task policy.
Apr 1 2015, 11:40 PM · Policy, Wikimedia, Maniphest
epriestley added a comment to T7484: Lock is not locked by this process.

Specifically, if that returns an integer, it's a connection ID.

Apr 1 2015, 11:35 PM · Restricted Project, Daemons
epriestley added a comment to T7484: Lock is not locked by this process.

Does this show anything?

Apr 1 2015, 11:33 PM · Restricted Project, Daemons
epriestley added a comment to T7728: Implement locale.default.

More just that we'd like to reduce the number of config values we have, and we could possibly get this "for free" if T4103 has "global defaults for all available settings/preferences".

Apr 1 2015, 11:28 PM · Localization
epriestley added a comment to T7484: Lock is not locked by this process.

D12253 "fixes" this in the sense that it likely reduces it to T6958.

Apr 1 2015, 11:24 PM · Restricted Project, Daemons
epriestley added a revision to T7484: Lock is not locked by this process: Unknown Object (Differential Revision).
Apr 1 2015, 11:23 PM · Restricted Project, Daemons
epriestley added a comment to T6958: Make cause/resolution for PhutilLockException during repository import more clear.

Never mind, I think that's someting else.

Apr 1 2015, 11:18 PM · Daemons
epriestley reopened T7484: Lock is not locked by this process as "Open".

Oh, this might not be quite related.

Apr 1 2015, 11:18 PM · Restricted Project, Daemons
epriestley merged task T7484: Lock is not locked by this process into T6958: Make cause/resolution for PhutilLockException during repository import more clear.
Apr 1 2015, 11:17 PM · Restricted Project, Daemons
epriestley updated subscribers of T6958: Make cause/resolution for PhutilLockException during repository import more clear.
Apr 1 2015, 11:17 PM · Daemons
epriestley added a comment to T7728: Implement locale.default.

It's vaguely possible that we won't need a separate setting for this after T4103, which is part of the reason I didn't implement it.

Apr 1 2015, 11:12 PM · Localization
epriestley added a comment to T7727: Allow push policies to be set by branch.

You can do this with Herald. Here's an example which prevents anyone but me from pushing to "master" across several repositories:

Apr 1 2015, 7:54 PM · Diffusion
epriestley added a comment to T7199: Expand the power of "!action" commands in email.

This is now live on this server. Notably, application help menus now show mail command help if the application supports mail commands:

Apr 1 2015, 7:13 PM · Mail
epriestley closed T7725: Test Bug Plz Ignore as Resolved.
Apr 1 2015, 7:11 PM · Mail
epriestley created T7725: Test Bug Plz Ignore.
Apr 1 2015, 7:11 PM · Mail
epriestley added a subtask for T7573: Ship Quicksand: T7724: Help menu does not update after Quicksand navigation.
Apr 1 2015, 7:09 PM · Quicksand, Conpherence
epriestley added a parent task for T7724: Help menu does not update after Quicksand navigation: T7573: Ship Quicksand.
Apr 1 2015, 7:09 PM · Quicksand
epriestley created T7724: Help menu does not update after Quicksand navigation.
Apr 1 2015, 7:09 PM · Quicksand
epriestley added a revision to T7689: Load handles just-in-time: Unknown Object (Differential Revision).
Apr 1 2015, 7:07 PM · Typeahead
jhurwitz awarded T7199: Expand the power of "!action" commands in email a Orange Medal token.
Apr 1 2015, 6:54 PM · Mail
epriestley closed T7199: Expand the power of "!action" commands in email as Resolved by committing Restricted Diffusion Commit.
Apr 1 2015, 6:52 PM · Mail
epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Apr 1 2015, 6:33 PM · Mail
epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Apr 1 2015, 5:13 PM · Mail
epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Apr 1 2015, 4:48 PM · Mail
epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Apr 1 2015, 4:41 PM · Mail
epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Apr 1 2015, 4:25 PM · Mail
epriestley added a comment to T7722: Footer cut on the left side on profile pages since project pane was introduced.

That said, I can't reproduce at HEAD either, even with a substantial footer.

Apr 1 2015, 3:29 PM · Badge Awarded
epriestley added a comment to T7722: Footer cut on the left side on profile pages since project pane was introduced.

(To reproduce, you may need to have a footer which is at least 300 pages long, like WMF's.)

Apr 1 2015, 3:27 PM · Badge Awarded
epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Apr 1 2015, 3:25 PM · Mail
epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Apr 1 2015, 2:39 PM · Mail
epriestley added a subtask for T7571: Conpherence v2 Errata: T7721: Unrecoverable Fatal Error when navigating to Conpherence application.
Apr 1 2015, 2:37 PM · Conpherence
epriestley added a parent task for T7721: Unrecoverable Fatal Error when navigating to Conpherence application: T7571: Conpherence v2 Errata.
Apr 1 2015, 2:37 PM
epriestley updated subscribers of T7721: Unrecoverable Fatal Error when navigating to Conpherence application.
Apr 1 2015, 2:36 PM
epriestley added a comment to T7720: Incorrect "Unsubmitted" state detection for Audit inline comments.

Oh, I just didn't read this correctly at all. Ignore me.

Apr 1 2015, 12:43 PM · Differential, Audit
epriestley placed T7558: Conpherence doesn't scroll to bottom in Durable Column regularly up for grabs.
Apr 1 2015, 12:39 PM · Conpherence (v4)
epriestley reopened T7558: Conpherence doesn't scroll to bottom in Durable Column regularly as "Open".

This is still frequently glitchy for me.

Apr 1 2015, 12:38 PM · Conpherence (v4)
epriestley reopened T7558: Conpherence doesn't scroll to bottom in Durable Column regularly, a subtask of T7572: Ship Durable Chat Column, as Open.
Apr 1 2015, 12:38 PM · Conpherence
epriestley created 2015-03 March.
Apr 1 2015, 12:37 PM
epriestley added a comment to T7720: Incorrect "Unsubmitted" state detection for Audit inline comments.

refers to the fact that you clicked the checkbox not being published yet

Apr 1 2015, 12:33 PM · Differential, Audit
epriestley added a comment to T7720: Incorrect "Unsubmitted" state detection for Audit inline comments.

In the second case, "Unsubmitted" refers to the fact that you clicked the checkbox not being published yet. So this behavior is intentional, but not necessarily as clear as it could be.

Apr 1 2015, 12:32 PM · Differential, Audit
epriestley updated subscribers of T7720: Incorrect "Unsubmitted" state detection for Audit inline comments.

Some possible evidence that this is confusing in practice rather than just in theory.

Apr 1 2015, 12:32 PM · Differential, Audit
epriestley placed T7645: Phabricator api not getting called from SVN pre-commit hook up for grabs.
Apr 1 2015, 11:19 AM · Subversion
epriestley merged task T7718: Phabricator api not getting called from SVN pre-commit hook into T7645: Phabricator api not getting called from SVN pre-commit hook.
Apr 1 2015, 11:18 AM
epriestley merged T7718: Phabricator api not getting called from SVN pre-commit hook into T7645: Phabricator api not getting called from SVN pre-commit hook.
Apr 1 2015, 11:18 AM · Subversion
epriestley added a comment to T7717: array_key_exists error in Conpherence thread.

These calls:

Apr 1 2015, 11:18 AM · Conpherence
epriestley added a parent task for T7717: array_key_exists error in Conpherence thread: T7571: Conpherence v2 Errata.
Apr 1 2015, 11:16 AM · Conpherence
epriestley added a subtask for T7571: Conpherence v2 Errata: T7717: array_key_exists error in Conpherence thread.
Apr 1 2015, 11:16 AM · Conpherence
epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Apr 1 2015, 3:08 AM · Mail
epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Apr 1 2015, 2:51 AM · Mail
hach-que awarded T7711: Formalize Paid Prioritization? a Love token.
Apr 1 2015, 2:44 AM
epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Apr 1 2015, 2:39 AM · Mail
epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Apr 1 2015, 2:08 AM · Mail
epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Apr 1 2015, 1:51 AM · Mail
epriestley updated subscribers of T7691: Relative wiki links.
Apr 1 2015, 1:46 AM · Remarkup, Phriction
epriestley merged task T7716: Support relative Wiki page references into T7691: Relative wiki links.
Apr 1 2015, 1:46 AM · Phriction
epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Apr 1 2015, 12:42 AM · Mail
epriestley added a revision to T7712: Files via email (some) seem not to set author or to mirror "normal" task policy: Unknown Object (Differential Revision).
Apr 1 2015, 12:42 AM · Policy, Wikimedia, Maniphest
epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Apr 1 2015, 12:17 AM · Mail
epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Apr 1 2015, 12:01 AM · Mail

Mar 31 2015

epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Mar 31 2015, 11:34 PM · Mail
epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Mar 31 2015, 11:15 PM · Mail
epriestley updated subscribers of T7199: Expand the power of "!action" commands in email.
Mar 31 2015, 11:08 PM · Mail
epriestley updated subscribers of T7199: Expand the power of "!action" commands in email.
Mar 31 2015, 11:03 PM · Mail
epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Mar 31 2015, 10:37 PM · Mail
epriestley closed T7714: `arc land` should update timestamp of the commit as Wontfix.

We haven't seen any reports to that effect, and it seems equally likely that teams would be confused about arc exhibiting behavior which was not faithful to the underlying VCS behavior.

Mar 31 2015, 10:34 PM · Restricted Project, Arcanist
epriestley added a comment to T7714: `arc land` should update timestamp of the commit.

Mercurial records only one date, but the story is basically the same: we don't pass any special flags, and you get the same result you'd get if you ran hg commands manually. In particular, hg commit --amend and hg rebase do not update commit dates for the amended or rebased commits. If you don't like this behavior, you could try raising it to the Mercurial upstream. But we're respecting the underlying VCS and using the semantics which are most consistent with its interpretation of dates.

Mar 31 2015, 10:16 PM · Restricted Project, Arcanist
epriestley added a revision to T7199: Expand the power of "!action" commands in email: Unknown Object (Differential Revision).
Mar 31 2015, 10:00 PM · Mail
epriestley closed T7714: `arc land` should update timestamp of the commit as Wontfix.

Git stores two dates, the "author date" and the "commit date". We update these in a way which is consistent with Git semantics (specifically, we do not use flags like --committer-date-is-author-date or --ignore-date to alter the semantics). The result is faithful to the result you'd get if you ran the same commands with git, and produces the values for "author date" and "commit date" which are most consistent with the internal meaning of these fields in Git. You can use "%cd", "--format=fuller", or similar settings to review commit dates.

Mar 31 2015, 9:56 PM · Restricted Project, Arcanist
epriestley claimed T7199: Expand the power of "!action" commands in email.
Mar 31 2015, 9:10 PM · Mail
epriestley closed T7713: device-tablet seems to no longer trigger as Resolved by committing Restricted Diffusion Commit.
Mar 31 2015, 8:45 PM · PHUI
epriestley added a comment to T7711: Formalize Paid Prioritization?.

I think we run the risk of running out of bandwidth pretty fast though. How do things work if / when that happens?

Mar 31 2015, 8:37 PM
epriestley added a comment to T7712: Files via email (some) seem not to set author or to mirror "normal" task policy.

Yeah, I think there are two main issues here:

Mar 31 2015, 8:34 PM · Policy, Wikimedia, Maniphest
epriestley claimed T7713: device-tablet seems to no longer trigger.
Mar 31 2015, 8:30 PM · PHUI
epriestley added a revision to T7689: Load handles just-in-time: Unknown Object (Differential Revision).
Mar 31 2015, 8:29 PM · Typeahead
epriestley added a revision to T7713: device-tablet seems to no longer trigger: Unknown Object (Differential Revision).
Mar 31 2015, 8:25 PM · PHUI
epriestley added a revision to T4100: Support query parameterization in typeaheads: Restricted Differential Revision.
Mar 31 2015, 8:20 PM · Typeahead, User Delight, Maniphest
epriestley added a revision to T7689: Load handles just-in-time: Restricted Differential Revision.
Mar 31 2015, 8:20 PM · Typeahead
epriestley added a comment to T7711: Formalize Paid Prioritization?.

Like hologram stickers fancy?

Mar 31 2015, 7:47 PM
epriestley edited P1746 Properly Configured 302.
Mar 31 2015, 5:47 PM
epriestley edited P1745 CloudFront 301.
Mar 31 2015, 5:46 PM
epriestley added a comment to T7711: Formalize Paid Prioritization?.

If we adopt this, I'd plan to make it a public doc, yes.

Mar 31 2015, 4:55 PM
epriestley added a comment to T7711: Formalize Paid Prioritization?.

I don't know if this would actually lower the barrier enough to meaningfully impact the kind of contract work we see, but it seems like it wouldn't cost us much to put this out there.

Mar 31 2015, 4:30 PM
epriestley created T7711: Formalize Paid Prioritization?.
Mar 31 2015, 4:26 PM
• helix awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Mar 31 2015, 3:10 PM · Workboards (v3), Restricted Project
epriestley added a comment to T3980: Support "Bind to External Thing" to define project membership.

Very roughly, this is about two weeks of work so the cost to prioritize it would be in the $10K-$20K range. If that sounds reasonable, shoot us an email at contact@phacility.com and we can move forward.

Mar 31 2015, 2:04 PM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects