Page MenuHomePhabricator
Create Task
Maniphest T7722

Footer cut on the left side on profile pages since project pane was introduced
Closed, InvalidPublic
Actions

Description

Footer was introduced in T6052: Legal links visible in all pages and its full width problems with full sidebars were fixed in T6168: Long footer is partially hidden by left column in the homepage.
This regressed when the new project pane on the left was introduced, see screenshot in downstream https://phabricator.wikimedia.org/T94580

Quick'n'dirty hack would be to edit phabricator-standard-page-footer by changing margin: 4px 16px; to margin: 4px 16px 4px 56px; or such in the file webroot/rsrc/css/application/base/standard-page-view.css.

Revisions and Commits

rP Phabricator
AbandonedD12242 Display full footer text on profile pages

Related Objects

Event Timeline

aklapper created this task.Apr 1 2015, 2:47 PM
aklapper raised the priority of this task from to Needs Triage.
aklapper updated the task description. (Show Details)
aklapper added a project: Badge Awarded.
aklapper added a subscriber: aklapper.
Herald added a subscriber: qgil. · View Herald TranscriptApr 1 2015, 2:47 PM
aklapper added a revision: D12242: Display full footer text on profile pages.Apr 1 2015, 2:58 PM
chad added a subscriber: chad.Apr 1 2015, 3:03 PM

I'm not able reproduce this at HEAD on my local install.

pasted_file (445×1 px, 98 KB)

chad added a comment.Apr 1 2015, 3:07 PM

Specifically, you should see this rule do the right thing:

.device-desktop div.phabricator-icon-nav + .phabricator-standard-page-footer {
  margin-left: 58px;
}
epriestley added a subscriber: epriestley.Apr 1 2015, 3:27 PM

(To reproduce, you may need to have a footer which is at least 300 pages long, like WMF's.)

epriestley added a comment.Apr 1 2015, 3:29 PM

That said, I can't reproduce at HEAD either, even with a substantial footer.

Screen_Shot_2015-04-01_at_8.28.57_AM.png (1×1 px, 208 KB)

chad added a comment.Apr 1 2015, 3:30 PM

I assume they are behind D11895

chad closed this task as Invalid.Apr 2 2015, 3:59 AM
chad claimed this task.

Closing, let us know if you still have an issue at HEAD.

aklapper added a comment.Apr 3 2015, 11:07 AM

Ahem, you were right. I'm sorry for the noise. :(

Phabricator · Built by Phacility