Page MenuHomePhabricator
Create Task
Maniphest T7730

Herald queries show object rules as global rules
Closed, ResolvedPublic
Actions

Description

/herald/query labels Object rules with the "Global Rule" text and the globe icon.

/diffusion/P/browse/master/src/applications/herald/query/HeraldRuleSearchEngine.php$183 contains the problem. There's no case for Object rules.

I can write a patch for this tomorrow, if you'd like.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

epkugelmass created this task.Apr 1 2015, 11:57 PM
epkugelmass raised the priority of this task from to Needs Triage.
epkugelmass updated the task description. (Show Details)
epkugelmass added a project: Herald.
epkugelmass added a subscriber: epkugelmass.
epriestley added a subscriber: epriestley.Apr 2 2015, 2:37 AM

Sure, we'd be happy to accept a patch for this.

epkugelmass claimed this task.Apr 2 2015, 2:58 AM
epkugelmass added a revision: Restricted Differential Revision.Apr 2 2015, 4:18 AM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Apr 2 2015, 12:00 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley added a comment.Apr 2 2015, 12:01 PM

Thanks for the report and patch!

Phabricator · Built by Phacility