Page MenuHomePhabricator

Herald queries show object rules as global rules
Closed, ResolvedPublic

Description

/herald/query labels Object rules with the "Global Rule" text and the globe icon.

/diffusion/P/browse/master/src/applications/herald/query/HeraldRuleSearchEngine.php$183 contains the problem. There's no case for Object rules.

I can write a patch for this tomorrow, if you'd like.

Event Timeline

epkugelmass raised the priority of this task from to Needs Triage.
epkugelmass updated the task description. (Show Details)
epkugelmass added a project: Herald.
epkugelmass added a subscriber: epkugelmass.

Sure, we'd be happy to accept a patch for this.

Thanks for the report and patch!