Maniphest T7730

Herald queries show object rules as global rules
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	epkugelmass
	Apr 1 2015, 11:57 PM

Tags

Referenced Files

None

Subscribers

Description

/herald/query labels Object rules with the "Global Rule" text and the globe icon.

/diffusion/P/browse/master/src/applications/herald/query/HeraldRuleSearchEngine.php$183 contains the problem. There's no case for Object rules.

I can write a patch for this tomorrow, if you'd like.

Revisions and Commits

rP Phabricator
	D12259	rP1ae1cdd7bac4 Herald queries correctly label Object Rules

Event Timeline

epkugelmass created this task.Apr 1 2015, 11:57 PM

epkugelmass raised the priority of this task from to Needs Triage.

epkugelmass updated the task description. (Show Details)

epkugelmass added a project: Herald.

epkugelmass added a subscriber: epkugelmass.

Sure, we'd be happy to accept a patch for this.

epkugelmass claimed this task.Apr 2 2015, 2:58 AM

epkugelmass added a revision: D12259: Herald queries correctly label Object Rules.Apr 2 2015, 4:18 AM

epriestley closed this task as Resolved by committing rP1ae1cdd7bac4: Herald queries correctly label Object Rules.Apr 2 2015, 12:00 PM

epriestley added a commit: rP1ae1cdd7bac4: Herald queries correctly label Object Rules.

Thanks for the report and patch!