name

Well I'm the designer of the group, so visually aids are highly appreciated. Thanks!

What I pasted is the 'raw' source of the message which I presume is what it needed to reproduce. In gui client land it looks something like

Sorry, I'm still not understanding the issue, a screenshot for future Phabricator archeologists would be most helpful. Can you attach an image of said mail client and how the email looks before sending it?

Is that true even if you make a new mock with new comments (i.e., everything created after the upgrade)? We fixed several file permissions issues in the relatively recent past, but they are partially state-based and older files may not have the correct state.

After upgrading to the latest version of code, I am still seeing the exact same behavior: when making an comment, the inline comment images are reloaded and are not cached:

I will update our local instance and see if the issue goes away. And FWIW, I'm not on dialup, but rather a 3G tether.

@epriestley that's from Chrome Devtools (Network pane). They are definitely network requests and not cache. There would be a (from cache) and color change on the line item if it was cached.

(I'm using Charles, FWIW.)

Also, I'm not sure what tool you're screenshotting, but are those definitely network requests (vs fills from local cache)? Are you visually seeing the images load, or just seeing these requests in a log and concerned about unnecessary bandwidth use?

And those are against M54, which has several images.

Hmm, I can't repro in Chrome either. Does it repro on this install?

My assumption is Pholio's inline comments contain large images, and Differentials mostly just contain text. We might get Differential for free with this task, I'm not up to speed on that code to know.

@epriestley perhaps it only reloads when there are multiple images on a mock? I was not able to reproduce with a mock that only has one image and no revisions. Commenting on a mock that has multiple images and multiple revisions resulted in this (using Chrome):

It's way simpler to just reload everything, and the amount of bandwidth in the comment text is trivial, so we're unlikely to change that. It would only be impactful if you had a dialup connection or something.

Okay, so T1895 is somewhat related, but not completely. I fail to see how this is strictly about Pholio though, as the exact same problematic behavior (refreshing inline comments) can be seen in Differential.

I have triaged this into two different tasks. First is T1895 which covers all preview fields in Phabricator. Then this task, to be more specific about Pholio and even if preview is on, not re-fetching the images/comments.

It's not just Philio, but also Differential.

There's currently no way to escape literal sequences of 3 backticks within a block. One workaround is to use a paste instead, and embed it with the {Pnnn} syntax:

Closed by commit rP13834f140617.

Closed by commit rPHUecf3526e557f.

Oh, T4036 actually has a good example of this that I didn't think of: when you quote a comment, we put the object name in the reply, which implicitly mentions it.

Closed by commit rPb09f8fa9b842.

• This should work after D10449 lands.
• Because this protocol is not common, I've left it out of the default set. You can use a command like phabricator/ $ ./bin/config set uri.allowed-protocols '{"http":true, "https":true, "mailto":true, "tel":true}' to add it.
• If you have existing links, run phabricator/ $ ./bin/cache purge --purge-remarkup to purge the caches.
• I'm only like 95% sure the implementation is correct since I don't have a convenient way to test it on a real device with telephony capabilities (iOS Simulator just fails when clicking a "tel:" link), yell if you're still seeing issues.

this is awesome, thx. just a reminder to update:
https://secure.phabricator.com/book/phabricator/article/remarkup/

Seems reasonable.

Closed by commit rP69b0ac724a7c.

Phabricator Home → Settings → Password → Set a Password...

Closed by commit rP2d69e2bdee0e.

This is completely silly, but it bothers me to no end every time I write them in docs so I'm going to do something here.

Oh, this is for search? My bad. There is nothing special about project searching, the hash is just ignored, isn't it?

I looked into this a little and IE9 is not the bestest for drag and drop. It seems like it is maybe possibly with some browser wizardy as some things do support it.

✘ Merged into T5894.

Maybe related: T5894: Thumbnails of uploaded files broken when not logged in, Although being logged in here does not help.

Closed by commit rPff51a1a451f1.

◀ Merged tasks: T5876.