Page MenuHomePhabricator

Remarkup monospaced text does not have "Monospaced Font" display setting applied
Closed, ResolvedPublic

Description

I discovered this while reviewing code in which I was unsure whether a character was a 0 or an O. I tried to compare it to the text in an inline comment but it didn't look like either one. Turns out this is because my Diffusion code was rendering in Menlo but my inline comment monospaced code was rendering in whatever Chrome uses when you put monospace in CSS.

Small issue, but it would be nice if that display rule got applied to all Remarkup monospaced code, for instance by adding a .PhabricatorMonospaced class to the tt elements that Remarkup generates or adding .remarkup-monospaced to the rule that applies the monospaced font display settings.

Repro steps:

  1. Set your monospaced font (in /settings/panel/display) to something crazy like 24px "Comic Sans" so you can see the difference.
  2. Look at the monospaced text in this bug report. It will not be in 24px Comic Sans.

Thanks for an awesome product!

Revisions and Commits

Restricted Differential Revision

Event Timeline

bkuhn raised the priority of this task from to Needs Triage.
bkuhn updated the task description. (Show Details)
bkuhn added a subscriber: bkuhn.
chad triaged this task as Normal priority.Sep 16 2014, 9:32 PM
chad added a project: Remarkup.
chad added a revision: Restricted Differential Revision.Nov 27 2014, 4:46 AM
chad added a commit: Restricted Diffusion Commit.

Closed by commit rP48e90ca7d561.