Page MenuHomePhabricator

Correct DOM node metadata to let inline comments work against block-based diffs
ClosedPublic

Authored by epriestley on Sep 25 2019, 7:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 7:04 PM
Unknown Object (File)
Fri, Nov 22, 12:43 PM
Unknown Object (File)
Fri, Nov 22, 2:02 AM
Unknown Object (File)
Wed, Nov 20, 4:25 AM
Unknown Object (File)
Sat, Nov 16, 2:00 PM
Unknown Object (File)
Mon, Nov 11, 4:56 PM
Unknown Object (File)
Sat, Nov 9, 3:48 PM
Unknown Object (File)
Thu, Nov 7, 7:50 PM
Subscribers
None

Details

Summary

Depends on D20833. Ref T13425. This look like it "just works"?

Test Plan

Left inline comments on a Juptyer notebook. Nothing seemed broken? Confusing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable