Page MenuHomePhabricator
Differential D20834

Correct DOM node metadata to let inline comments work against block-based diffs
ClosedPublic
Actions

Authored by epriestley on Sep 25 2019, 7:48 PM.
Tags
None
Referenced Files
F18985228: D20834.id49665.diff
Mon, Nov 17, 12:56 PM
F18856485: D20834.id.diff
Nov 1 2025, 10:00 AM
F18813752: D20834.diff
Oct 20 2025, 6:50 PM
F18734060: D20834.id.diff
Sep 30 2025, 10:47 PM
F18684214: D20834.diff
Sep 26 2025, 8:52 AM
F18645764: D20834.id49665.diff
Sep 19 2025, 8:29 AM
F18630075: D20834.diff
Sep 16 2025, 10:41 AM
F18618562: D20834.id.diff
Sep 15 2025, 12:27 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13425: Support diffs between abstract block lists in the UI
Commits
rPa09b298d85d7: Correct DOM node metadata to let inline comments work against block-based diffs
Summary

Depends on D20833. Ref T13425. This look like it "just works"?

Test Plan

Left inline comments on a Juptyer notebook. Nothing seemed broken? Confusing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
render/
12 lines

Diff 49675

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
Phabricator · Built by Phacility