Page MenuHomePhabricator
Differential D20834

Correct DOM node metadata to let inline comments work against block-based diffs
ClosedPublic
Actions

Authored by epriestley on Sep 25 2019, 7:48 PM.
Tags
None
Referenced Files
F15425099: D20834.id49675.diff
Sun, Mar 23, 2:28 AM
Unknown Object (File)
Sun, Mar 2, 3:36 AM
Unknown Object (File)
Feb 12 2025, 2:46 AM
Unknown Object (File)
Feb 9 2025, 8:12 AM
Unknown Object (File)
Feb 9 2025, 8:12 AM
Unknown Object (File)
Feb 9 2025, 8:12 AM
Unknown Object (File)
Feb 5 2025, 3:19 AM
Unknown Object (File)
Jan 25 2025, 5:52 AM
View All 84 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13425: Support diffs between abstract block lists in the UI
Commits
rPa09b298d85d7: Correct DOM node metadata to let inline comments work against block-based diffs
Summary

Depends on D20833. Ref T13425. This look like it "just works"?

Test Plan

Left inline comments on a Juptyer notebook. Nothing seemed broken? Confusing.

Diff Detail

Repository
rP Phabricator
Branch
jupyter5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23492
Build 32285: Run Core Tests
Build 32284: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
render/
12 lines

Diff 49665

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
Phabricator · Built by Phacility