Diffusion Phabricator a09b298d85d7

Correct DOM node metadata to let inline comments work against block-based diffs
a09b298d85d7
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

Correct DOM node metadata to let inline comments work against block-based diffs

Summary: Depends on D20833. Ref T13425. This look like it "just works"?

Test Plan: Left inline comments on a Juptyer notebook. Nothing seemed broken? Confusing.

Maniphest Tasks: T13425

Differential Revision: https://secure.phabricator.com/D20834

Details

Provenance

epriestley	Authored on Sep 25 2019, 7:40 PM
epriestley	Pushed on Sep 25 2019, 11:38 PM

Differential Revision

D20834: Correct DOM node metadata to let inline comments work against block-based diffs

Parents

rP1c4450d39f9b: Allow the Jupyter engine to elect to emit diffs, and emit Jupyter documents as…

Branches

Unknown

Tags

Unknown

Tasks

T13425: Support diffs between abstract block lists in the UI

Build Status

Buildable 23502
Build 32300: Run Core Tests

Event Timeline

epriestley committed rPa09b298d85d7: Correct DOM node metadata to let inline comments work against block-based diffs (authored by epriestley).Sep 25 2019, 11:38 PM

epriestley added a task: T13425: Support diffs between abstract block lists in the UI.

epriestley added an edge: D20834: Correct DOM node metadata to let inline comments work against block-based diffs.

Harbormaster completed building B23502: rPa09b298d85d7: Correct DOM node metadata to let inline comments work against block-based diffs.Sep 25 2019, 11:39 PM

Changes (1)

Path

Size

src/

applications/

differential/

render/

DifferentialChangesetTwoUpRenderer.php

rPa09b298d85d7

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...