Page MenuHomePhabricator

Improve behavior of inline comment highlight reticle for block diffs

Authored by epriestley on Sep 25 2019, 8:25 PM.



Depends on D20834. Ref T13425. After the change from "th" to "td" for accessibility, the algorithm picks which cells it should highlight slightly improperly (it picks too many cells since it can no longer find the line numbers).

Ideally, it would probably highlight only the source content, but there isn't an easy way to do this right now. Settle for an incremental improvement for the moment.

Test Plan

Hovered over line numbers, saw a more accurate highlight area.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 25 2019, 8:25 PM
epriestley requested review of this revision.Sep 25 2019, 8:27 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 25 2019, 11:39 PM
This revision was automatically updated to reflect the committed changes.