Page MenuHomePhabricator

Allow DocumentEngine to elect into diff construction
ClosedPublic

Authored by epriestley on Wed, Sep 25, 4:26 PM.

Details

Summary

Ref T13425. Allow DocumentEngines to claim they can produce diffs. If both sides of a change can be diffed by the same document engine and it can produce diffs, have it diff them.

This has no impact on runtime behavior because no upstream engine elects into diff generation yet.

Test Plan

Loaded some revisions, nothing broke.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Sep 25, 4:26 PM
epriestley requested review of this revision.Wed, Sep 25, 4:28 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Sep 25, 11:23 PM
This revision was automatically updated to reflect the committed changes.