Page MenuHomePhabricator

Render image diffs as abstract blocks diffs via DocumentEngine
ClosedPublic

Authored by epriestley on Wed, Sep 25, 5:14 PM.

Details

Summary

Depends on D20830. Ref T13425. Have the image engine elect into block rendering, then emit blocks.

This is rough (the blocks aren't actually diffed yet) but image diffs were already pretty rough so this is approximately a net improvement.

Test Plan

Viewed image diffs, saw nothing worse than before.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Sep 25, 5:14 PM
epriestley requested review of this revision.Wed, Sep 25, 5:16 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Sep 25, 11:25 PM
This revision was automatically updated to reflect the committed changes.