Page MenuHomePhabricator

In prose diffs, use hash-and-diff for coarse "level 0" diffing to scale better
ClosedPublic

Authored by epriestley on Wed, Sep 25, 10:12 PM.

Details

Summary

Depends on D20838. Fixes T13414. Instead of doing coarse diffing with "PhutilEditDistanceMatrix", use hash-and-diff with "DocumentEngine".

Test Plan
  • On a large document (~3K top level blocks), saw a more sensible diff, instead of the whole thing falling back to "everything changed" mode.
  • On a small document, still saw a sensible granular diff.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Sep 25, 10:12 PM
epriestley requested review of this revision.Wed, Sep 25, 10:14 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Sep 25, 11:50 PM
This revision was automatically updated to reflect the committed changes.