Page MenuHomePhabricator
Differential D20834

Correct DOM node metadata to let inline comments work against block-based diffs
ClosedPublic
Actions

Authored by epriestley on Sep 25 2019, 7:48 PM.
Tags
None
Referenced Files
F13049005: D20834.diff
Fri, Apr 19, 12:22 AM
Unknown Object (File)
Thu, Apr 11, 9:36 AM
Unknown Object (File)
Feb 3 2024, 11:15 PM
Unknown Object (File)
Jan 15 2024, 7:07 PM
Unknown Object (File)
Jan 6 2024, 8:25 PM
Unknown Object (File)
Nov 30 2023, 4:25 AM
Unknown Object (File)
Nov 17 2023, 7:52 AM
Unknown Object (File)
Oct 7 2023, 8:30 PM
View All 27 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13425: Support diffs between abstract block lists in the UI
Commits
rPa09b298d85d7: Correct DOM node metadata to let inline comments work against block-based diffs
Summary

Depends on D20833. Ref T13425. This look like it "just works"?

Test Plan

Left inline comments on a Juptyer notebook. Nothing seemed broken? Confusing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
render/
12 lines

Diff 49675

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
Phabricator · Built by Phacility