Page MenuHomePhabricator
Differential D20834

Correct DOM node metadata to let inline comments work against block-based diffs
ClosedPublic
Actions

Authored by epriestley on Sep 25 2019, 7:48 PM.
Tags
None
Referenced Files
F19757206: D20834.diff
Tue, Feb 17, 7:37 PM
F19698265: D20834.diff
Tue, Feb 10, 5:25 PM
F19554898: D20834.id49675.diff
Jan 30 2026, 4:54 AM
F19518139: D20834.id.diff
Jan 15 2026, 6:12 PM
F19515356: D20834.diff
Jan 14 2026, 10:38 AM
F19083081: D20834.id49675.diff
Dec 2 2025, 12:30 PM
F19080708: D20834.id49665.diff
Dec 2 2025, 2:10 AM
F19080671: D20834.id49675.diff
Dec 2 2025, 2:06 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13425: Support diffs between abstract block lists in the UI
Commits
rPa09b298d85d7: Correct DOM node metadata to let inline comments work against block-based diffs
Summary

Depends on D20833. Ref T13425. This look like it "just works"?

Test Plan

Left inline comments on a Juptyer notebook. Nothing seemed broken? Confusing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
render/
12 lines

Diff 49675

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
Phabricator · Built by Phacility