Page MenuHomePhabricator
Differential D20834

Correct DOM node metadata to let inline comments work against block-based diffs
ClosedPublic
Actions

Authored by epriestley on Sep 25 2019, 7:48 PM.
Tags
None
Referenced Files
F15504115: D20834.id49665.diff
Mon, Apr 14, 3:57 PM
F15494031: D20834.id49675.diff
Sat, Apr 12, 10:25 PM
F15485240: D20834.diff
Wed, Apr 9, 10:48 PM
F15483027: D20834.id49675.diff
Wed, Apr 9, 9:23 AM
F15478171: D20834.id49675.diff
Mon, Apr 7, 8:56 PM
F15478170: D20834.id49665.diff
Mon, Apr 7, 8:56 PM
F15478169: D20834.id.diff
Mon, Apr 7, 8:56 PM
F15472760: D20834.id.diff
Sat, Apr 5, 4:07 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13425: Support diffs between abstract block lists in the UI
Commits
rPa09b298d85d7: Correct DOM node metadata to let inline comments work against block-based diffs
Summary

Depends on D20833. Ref T13425. This look like it "just works"?

Test Plan

Left inline comments on a Juptyer notebook. Nothing seemed broken? Confusing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
render/
12 lines

Diff 49675

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
Phabricator · Built by Phacility