Page MenuHomePhabricator
Differential D20834

Correct DOM node metadata to let inline comments work against block-based diffs
ClosedPublic
Actions

Authored by epriestley on Sep 25 2019, 7:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 11 2025, 11:19 AM
Unknown Object (File)
Apr 28 2025, 1:55 AM
Unknown Object (File)
Apr 14 2025, 3:57 PM
Unknown Object (File)
Apr 12 2025, 10:25 PM
Unknown Object (File)
Apr 9 2025, 10:48 PM
Unknown Object (File)
Apr 9 2025, 9:23 AM
Unknown Object (File)
Apr 7 2025, 8:56 PM
Unknown Object (File)
Apr 7 2025, 8:56 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13425: Support diffs between abstract block lists in the UI
Commits
rPa09b298d85d7: Correct DOM node metadata to let inline comments work against block-based diffs
Summary

Depends on D20833. Ref T13425. This look like it "just works"?

Test Plan

Left inline comments on a Juptyer notebook. Nothing seemed broken? Confusing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
render/
12 lines

Diff 49675

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
Phabricator · Built by Phacility