Page MenuHomePhabricator

Correct DOM node metadata to let inline comments work against block-based diffs
ClosedPublic

Authored by epriestley on Sep 25 2019, 7:48 PM.

Details

Summary

Depends on D20833. Ref T13425. This look like it "just works"?

Test Plan

Left inline comments on a Juptyer notebook. Nothing seemed broken? Confusing.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sep 25 2019, 7:48 PM
epriestley requested review of this revision.Sep 25 2019, 7:49 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 25 2019, 11:38 PM
This revision was automatically updated to reflect the committed changes.