Page MenuHomePhabricator
Differential D20834

Correct DOM node metadata to let inline comments work against block-based diffs
ClosedPublic
Actions

Authored by epriestley on Sep 25 2019, 7:48 PM.
Tags
None
Referenced Files
F22732767: D20834.id.diff
Sun, Oct 4, 7:36 AM
Unknown Object (File)
Thu, Sep 10, 11:21 PM
Unknown Object (File)
Jun 22 2026, 8:07 PM
Unknown Object (File)
Mar 7 2026, 8:04 AM
Unknown Object (File)
Mar 5 2026, 1:10 AM
Unknown Object (File)
Feb 17 2026, 7:37 PM
Unknown Object (File)
Feb 10 2026, 5:25 PM
Unknown Object (File)
Jan 30 2026, 4:54 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13425: Support diffs between abstract block lists in the UI
Commits
rPa09b298d85d7: Correct DOM node metadata to let inline comments work against block-based diffs
Summary

Depends on D20833. Ref T13425. This look like it "just works"?

Test Plan

Left inline comments on a Juptyer notebook. Nothing seemed broken? Confusing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
render/
12 lines

Diff 49675

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
Phabricator · Built by Phacility