Page MenuHomePhabricator
Differential D20834

Correct DOM node metadata to let inline comments work against block-based diffs
ClosedPublic
Actions

Authored by epriestley on Sep 25 2019, 7:48 PM.
Tags
None
Referenced Files
F19083081: D20834.id49675.diff
Tue, Dec 2, 12:30 PM
F19080708: D20834.id49665.diff
Tue, Dec 2, 2:10 AM
F19080671: D20834.id49675.diff
Tue, Dec 2, 2:06 AM
F19080520: D20834.diff
Tue, Dec 2, 1:38 AM
F18985228: D20834.id49665.diff
Nov 17 2025, 12:56 PM
F18856485: D20834.id.diff
Nov 1 2025, 10:00 AM
F18813752: D20834.diff
Oct 20 2025, 6:50 PM
F18734060: D20834.id.diff
Sep 30 2025, 10:47 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13425: Support diffs between abstract block lists in the UI
Commits
rPa09b298d85d7: Correct DOM node metadata to let inline comments work against block-based diffs
Summary

Depends on D20833. Ref T13425. This look like it "just works"?

Test Plan

Left inline comments on a Juptyer notebook. Nothing seemed broken? Confusing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
render/
12 lines

Diff 49675

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
Phabricator · Built by Phacility