Differential D20834

Correct DOM node metadata to let inline comments work against block-based diffs
ClosedPublic
Actions

Authored by epriestley on Sep 25 2019, 7:48 PM.

Tags

None

Referenced Files

	F15460452: D20834.id49675.diff
	Mon, Mar 31, 11:06 PM

	F15460451: D20834.id49665.diff
	Mon, Mar 31, 11:06 PM

	F15460450: D20834.id.diff
	Mon, Mar 31, 11:06 PM

	F15457415: D20834.diff
	Sun, Mar 30, 4:16 PM

	F15432783: D20834.id49665.diff
	Mon, Mar 24, 7:38 PM

	F15425099: D20834.id49675.diff
	Sun, Mar 23, 2:28 AM

	Unknown Object (File)
	Mar 2 2025, 3:36 AM

	Unknown Object (File)
	Feb 12 2025, 2:46 AM

View All 89 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13425: Support diffs between abstract block lists in the UI
Commits: rPa09b298d85d7: Correct DOM node metadata to let inline comments work against block-based diffs

Summary

Depends on D20833. Ref T13425. This look like it "just works"?

Test Plan

Left inline comments on a Juptyer notebook. Nothing seemed broken? Confusing.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 25 2019, 7:48 PM

Harbormaster completed remote builds in B23492: Diff 49665.Sep 25 2019, 7:49 PM

epriestley requested review of this revision.Sep 25 2019, 7:49 PM

epriestley added a child revision: D20835: Improve behavior of inline comment highlight reticle for block diffs.Sep 25 2019, 8:25 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 25 2019, 11:38 PM

Closed by commit rPa09b298d85d7: Correct DOM node metadata to let inline comments work against block-based diffs (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa09b298d85d7: Correct DOM node metadata to let inline comments work against block-based diffs.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

render/

DifferentialChangesetTwoUpRenderer.php

12 lines

Diff 49675

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Correct DOM node metadata to let inline comments work against block-based diffsClosedPublicActions