Page MenuHomePhabricator
Differential D20834

Correct DOM node metadata to let inline comments work against block-based diffs
ClosedPublic
Actions

Authored by epriestley on Sep 25 2019, 7:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 12, 2:46 AM
Unknown Object (File)
Sun, Feb 9, 8:12 AM
Unknown Object (File)
Sun, Feb 9, 8:12 AM
Unknown Object (File)
Sun, Feb 9, 8:12 AM
Unknown Object (File)
Wed, Feb 5, 3:19 AM
Unknown Object (File)
Sat, Jan 25, 5:52 AM
Unknown Object (File)
Sat, Jan 25, 5:52 AM
Unknown Object (File)
Sat, Jan 25, 5:52 AM
View All 82 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13425: Support diffs between abstract block lists in the UI
Commits
rPa09b298d85d7: Correct DOM node metadata to let inline comments work against block-based diffs
Summary

Depends on D20833. Ref T13425. This look like it "just works"?

Test Plan

Left inline comments on a Juptyer notebook. Nothing seemed broken? Confusing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
render/
12 lines

Diff 49675

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
Phabricator · Built by Phacility