Differential D20834

Correct DOM node metadata to let inline comments work against block-based diffs
ClosedPublic
Actions

Authored by epriestley on Sep 25 2019, 7:48 PM.

Details

Reviewers: None
Maniphest Tasks: T13425: Support diffs between abstract block lists in the UI
Commits: rPa09b298d85d7: Correct DOM node metadata to let inline comments work against block-based diffs

Summary

Depends on D20833. Ref T13425. This look like it "just works"?

Test Plan

Left inline comments on a Juptyer notebook. Nothing seemed broken? Confusing.

Diff Detail

Repository

rP Phabricator

Branch

jupyter5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23492
Build 32285: Run Core Tests
Build 32284: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 25 2019, 7:48 PM

Harbormaster completed remote builds in B23492: Diff 49665.Sep 25 2019, 7:49 PM

epriestley requested review of this revision.Sep 25 2019, 7:49 PM

epriestley added a child revision: D20835: Improve behavior of inline comment highlight reticle for block diffs.Sep 25 2019, 8:25 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 25 2019, 11:38 PM

Closed by commit rPa09b298d85d7: Correct DOM node metadata to let inline comments work against block-based diffs (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa09b298d85d7: Correct DOM node metadata to let inline comments work against block-based diffs.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

render/

DifferentialChangesetTwoUpRenderer.php

12 lines

Diff 49665

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Correct DOM node metadata to let inline comments work against block-based diffsClosedPublicActions