Page MenuHomePhabricator
Differential D20635

Move workboard "Move Tasks to Column..." workflow to a separate controller
ClosedPublic
Actions

Authored by epriestley on Jul 2 2019, 2:43 PM.
Tags
None
Referenced Files
F15411976: D20635.id49234.diff
Wed, Mar 19, 10:38 AM
F15403894: D20635.id49220.diff
Tue, Mar 18, 5:21 AM
F15401687: D20635.id49220.diff
Mon, Mar 17, 6:50 PM
F15400883: D20635.id.diff
Mon, Mar 17, 2:29 PM
F15395882: D20635.diff
Sun, Mar 16, 10:24 AM
F15382445: D20635.diff
Fri, Mar 14, 12:25 PM
F15282536: D20635.id49234.diff
Tue, Mar 4, 12:19 AM
F15282535: D20635.id49220.diff
Tue, Mar 4, 12:19 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T4900: Workboards updating in real time
T13316: On Workboards, "Move Tasks to Column..." has high friction in the common use case (selecting a column on the same board)
Commits
rP24b466cd62d1: Move workboard "Move Tasks to Column..." workflow to a separate controller
Summary

Depends on D20634. Ref T4900. Ref T13316. I'm planning to do a bit of additional cleanup here in followups, but this separates the main workflow out of the common controller.

Test Plan
  • Used "Move Tasks to Column..." to move some tasks on a board.
  • Tried to move an empty column, hit an error.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 49234

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/project/application/PhabricatorProjectApplication.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php

Loading...
Phabricator · Built by Phacility