Differential D20635

Move workboard "Move Tasks to Column..." workflow to a separate controller
ClosedPublic
Actions

Authored by epriestley on Jul 2 2019, 2:43 PM.

Details

Reviewers

Maniphest Tasks

T4900: Workboards updating in real time
T13316: On Workboards, "Move Tasks to Column..." has high friction in the common use case (selecting a column on the same board)

Commits

rP24b466cd62d1: Move workboard "Move Tasks to Column..." workflow to a separate controller

Summary

Depends on D20634. Ref T4900. Ref T13316. I'm planning to do a bit of additional cleanup here in followups, but this separates the main workflow out of the common controller.

Test Plan

Used "Move Tasks to Column..." to move some tasks on a board.
Tried to move an empty column, hit an error.

Diff Detail

Repository

rP Phabricator

Branch

refresh8

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23089
Build 31700: Run Core Tests
Build 31699: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 2 2019, 2:43 PM

Harbormaster completed remote builds in B23089: Diff 49220.Jul 2 2019, 2:45 PM

epriestley requested review of this revision.Jul 2 2019, 2:45 PM

epriestley added a child revision: D20636: Differentiate between "Move Tasks to Column..." and "Move Tasks to Project..." in the workboard UI.Jul 2 2019, 3:32 PM

amckinley accepted this revision.Jul 2 2019, 9:57 PM

This revision is now accepted and ready to land.Jul 2 2019, 9:57 PM

Closed by commit rP24b466cd62d1: Move workboard "Move Tasks to Column..." workflow to a separate controller (authored by epriestley). · Explain WhyJul 2 2019, 10:16 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP24b466cd62d1: Move workboard "Move Tasks to Column..." workflow to a separate controller.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

project/

application/

PhabricatorProjectApplication.php

2 lines

controller/

PhabricatorProjectBoardViewController.php

209 lines

PhabricatorProjectColumnBulkMoveController.php

219 lines

Diff 49220

View Options

src/__phutil_library_map__.php

View Options

src/applications/project/application/PhabricatorProjectApplication.php

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

View Options

src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php

Move workboard "Move Tasks to Column..." workflow to a separate controllerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 49220

src/__phutil_library_map__.php

src/applications/project/application/PhabricatorProjectApplication.php

src/applications/project/controller/PhabricatorProjectBoardViewController.php

src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php

Move workboard "Move Tasks to Column..." workflow to a separate controller
ClosedPublic
Actions

Revision Contents
Changeset List