Page MenuHomePhabricator
Differential D20635

Move workboard "Move Tasks to Column..." workflow to a separate controller
ClosedPublic
Actions

Authored by epriestley on Jul 2 2019, 2:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 10, 4:30 AM
Unknown Object (File)
Mon, Feb 10, 4:30 AM
Unknown Object (File)
Mon, Feb 10, 4:30 AM
Unknown Object (File)
Wed, Feb 5, 10:22 PM
Unknown Object (File)
Sun, Feb 2, 4:06 AM
Unknown Object (File)
Mon, Jan 27, 3:20 PM
Unknown Object (File)
Sun, Jan 26, 7:02 PM
Unknown Object (File)
Tue, Jan 21, 3:28 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T4900: Workboards updating in real time
T13316: On Workboards, "Move Tasks to Column..." has high friction in the common use case (selecting a column on the same board)
Commits
rP24b466cd62d1: Move workboard "Move Tasks to Column..." workflow to a separate controller
Summary

Depends on D20634. Ref T4900. Ref T13316. I'm planning to do a bit of additional cleanup here in followups, but this separates the main workflow out of the common controller.

Test Plan
  • Used "Move Tasks to Column..." to move some tasks on a board.
  • Tried to move an empty column, hit an error.

Diff Detail

Repository
rP Phabricator
Branch
refresh8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23089
Build 31700: Run Core Tests
Build 31699: arc lint + arc unit

Revision Contents
Changeset List

Diff 49220

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/project/application/PhabricatorProjectApplication.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php

Loading...
Phabricator · Built by Phacility