Page MenuHomePhabricator

Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table
ClosedPublic

Authored by epriestley on Apr 22 2019, 7:34 PM.
Tags
None
Referenced Files
F15411963: D20459.id.diff
Wed, Mar 19, 10:32 AM
F15397686: D20459.id48834.diff
Sun, Mar 16, 9:45 PM
F15345506: D20459.diff
Mon, Mar 10, 11:13 AM
Unknown Object (File)
Fri, Feb 21, 9:53 AM
Unknown Object (File)
Fri, Feb 21, 3:44 AM
Unknown Object (File)
Feb 16 2025, 6:03 PM
Unknown Object (File)
Feb 15 2025, 1:21 AM
Unknown Object (File)
Feb 14 2025, 10:51 PM
Subscribers
None

Details

Summary

Depends on D20458. Ref T13276. Although I'm not thrilled about "needCommitPHIDs()", it has a few callers, including custom fields. Allow "need + attach + get" to survive for now since they're reasonably modern, at least.

However, use edges instead of "TABLE_COMMIT" and require need...() + get...(), removing the direct load...().

Also remove RevisionQuery->withCommitPHIDs(...), which has no callers.

Test Plan
  • Grepped for loadCommitPHIDs (only two hits, the private RevisionQuery method).
  • Called "differential.getrevision", got commits.
  • Viewed a revision, saw "Commits: ...".
  • Grepped for withCommitPHIDs(), no callers on RevisionQuery (some other query classes have methods with this name).
  • Called "differential.query", got commits.

Diff Detail

Repository
rP Phabricator
Branch
audit3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22685
Build 31090: Run Core Tests
Build 31089: arc lint + arc unit