Page MenuHomePhabricator

Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table
ClosedPublic

Authored by epriestley on Apr 22 2019, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 19, 3:18 PM
Unknown Object (File)
Tue, Mar 19, 3:17 PM
Unknown Object (File)
Feb 3 2024, 10:19 PM
Unknown Object (File)
Dec 22 2023, 6:21 PM
Unknown Object (File)
Dec 22 2023, 2:09 AM
Unknown Object (File)
Dec 22 2023, 12:07 AM
Unknown Object (File)
Dec 16 2023, 4:13 AM
Unknown Object (File)
Nov 30 2023, 12:41 AM
Subscribers
None

Details

Summary

Depends on D20458. Ref T13276. Although I'm not thrilled about "needCommitPHIDs()", it has a few callers, including custom fields. Allow "need + attach + get" to survive for now since they're reasonably modern, at least.

However, use edges instead of "TABLE_COMMIT" and require need...() + get...(), removing the direct load...().

Also remove RevisionQuery->withCommitPHIDs(...), which has no callers.

Test Plan
  • Grepped for loadCommitPHIDs (only two hits, the private RevisionQuery method).
  • Called "differential.getrevision", got commits.
  • Viewed a revision, saw "Commits: ...".
  • Grepped for withCommitPHIDs(), no callers on RevisionQuery (some other query classes have methods with this name).
  • Called "differential.query", got commits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable