Page MenuHomePhabricator
Differential D20414

Fix the "Add Query to Dashboard..." flow from "Use Results" on search result pages
ClosedPublic
Actions

Authored by epriestley on Apr 12 2019, 11:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 7:38 AM
Unknown Object (File)
Sun, Feb 9, 7:38 AM
Unknown Object (File)
Sun, Feb 9, 7:38 AM
Unknown Object (File)
Fri, Jan 31, 2:52 AM
Unknown Object (File)
Wed, Jan 29, 9:13 PM
Unknown Object (File)
Sat, Jan 25, 4:46 AM
Unknown Object (File)
Sat, Jan 25, 4:46 AM
Unknown Object (File)
Sat, Jan 25, 4:46 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13272: Remove the hard-coded homepage, and other Dashboards improvements
Commits
rPe99c1974b027: Fix the "Add Query to Dashboard..." flow from "Use Results" on search result…
Summary

Depends on D20413. Ref T13272. When you search for stuff, you can "Use Results > Add to Dashboard" to generate a query panel.

This needs some updating after the recent refactoring. All the changes are pretty straightforward. Swaps a giant <select /> for a tokenizer with a datasource.

Test Plan

Used the "Use Results > Add to Dashboard" flow to create a panel on a dashboard using a query.

Diff Detail

Repository
rP Phabricator
Branch
panel16
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22578
Build 30928: Run Core Tests
Build 30927: arc lint + arc unit

Revision Contents
Changeset List

Diff 48708

View Options

src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php

Loading...
View Options

src/applications/dashboard/layoutconfig/PhabricatorDashboardPanelRefList.php

Loading...
View Options

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

Loading...
View Options

src/applications/dashboard/xaction/panel/PhabricatorDashboardQueryPanelApplicationTransaction.php

Loading...
Phabricator · Built by Phacility