Page MenuHomePhabricator

Fix the "Add Query to Dashboard..." flow from "Use Results" on search result pages
ClosedPublic

Authored by epriestley on Apr 12 2019, 11:48 PM.

Details

Summary

Depends on D20413. Ref T13272. When you search for stuff, you can "Use Results > Add to Dashboard" to generate a query panel.

This needs some updating after the recent refactoring. All the changes are pretty straightforward. Swaps a giant <select /> for a tokenizer with a datasource.

Test Plan

Used the "Use Results > Add to Dashboard" flow to create a panel on a dashboard using a query.

Diff Detail

Repository
rP Phabricator
Branch
panel16
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 22578
Build 30928: Run Core Tests
Build 30927: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 12 2019, 11:48 PM
epriestley requested review of this revision.Apr 12 2019, 11:49 PM
amckinley accepted this revision.Apr 17 2019, 5:51 PM
This revision is now accepted and ready to land.Apr 17 2019, 5:51 PM
This revision was automatically updated to reflect the committed changes.