Differential D20414

Fix the "Add Query to Dashboard..." flow from "Use Results" on search result pages
ClosedPublic
Actions

Authored by epriestley on Apr 12 2019, 11:48 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rPe99c1974b027: Fix the "Add Query to Dashboard..." flow from "Use Results" on search result…

Summary

Depends on D20413. Ref T13272. When you search for stuff, you can "Use Results > Add to Dashboard" to generate a query panel.

This needs some updating after the recent refactoring. All the changes are pretty straightforward. Swaps a giant <select /> for a tokenizer with a datasource.

Test Plan

Used the "Use Results > Add to Dashboard" flow to create a panel on a dashboard using a query.

Diff Detail

Repository

rP Phabricator

Branch

panel16

Lint

Lint OK

Unit

Unit Tests OK

Build Status

Buildable 22578
Build 30928: Run Core Tests
Build 30927: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 12 2019, 11:48 PM

Harbormaster completed remote builds in B22578: Diff 48708.Apr 12 2019, 11:49 PM

epriestley requested review of this revision.Apr 12 2019, 11:49 PM

epriestley added a child revision: D20415: Reduce drag-and-drop jank on dashboards.Apr 13 2019, 12:20 AM

amckinley accepted this revision.Apr 17 2019, 5:51 PM

This revision is now accepted and ready to land.Apr 17 2019, 5:51 PM

Closed by commit rPe99c1974b027: Fix the "Add Query to Dashboard..." flow from "Use Results" on search result… (authored by epriestley). · Explain WhyApr 17 2019, 7:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php (226 lines)
M			src/applications/dashboard/layoutconfig/PhabricatorDashboardPanelRefList.php (9 lines)
M			src/applications/dashboard/storage/PhabricatorDashboardPanel.php (5 lines)
M			src/applications/dashboard/xaction/panel/PhabricatorDashboardQueryPanelApplicationTransaction.php (27 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	48708	60b0476		Apr 12 2019, 11:48 PM	★	★
Diff 2	48757	4b8a67c	rPe99c1974b027494e3d382e9be9701532e6fdd1aa	Apr 17 2019, 7:18 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
b7571ac70d86	58488f04192e	60b0476a8980	epriestley	WIP	Apr 12 2019, 11:46 PM

Status	Author	Revision
Closed	epriestley	D20415 Reduce drag-and-drop jank on dashboards
Closed	epriestley	D20414 Fix the "Add Query to Dashboard..." flow from "Use Results" on search result pages
Closed	epriestley	D20413 Index and show Owners packages affected by Herald rules
Closed	epriestley	D20412 Reindex dashboards and panels (allow migrations to queue a job to queue other indexing jobs)
Closed	epriestley	D20411 Update search indexes for Dashboards and Panels to Ferret, plus various minor fixes
Closed	epriestley	D20410 Remove legacy "DashboardInstall" table
Closed	epriestley	D20409 Make "Move Panel" on dashboards use the new storage and transactions
Closed	epriestley	D20408 Update "add panel" and "remove panel" Dashboard flows to the new panel storage format
Closed	epriestley	D20407 Convert dashboard read/display pathways to the new panel storage format
Closed	epriestley	D20406 Modularize dashboard layout modes (one column, two columns, etc)
Closed	epriestley	D20405 Convert dashboard panel storage to a format which can handle duplicates

Diff 48708

View Options

src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php

View Options

src/applications/dashboard/layoutconfig/PhabricatorDashboardPanelRefList.php

View Options

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

View Options

src/applications/dashboard/xaction/panel/PhabricatorDashboardQueryPanelApplicationTransaction.php

Fix the "Add Query to Dashboard..." flow from "Use Results" on search result pagesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48708

src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php

src/applications/dashboard/layoutconfig/PhabricatorDashboardPanelRefList.php

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

src/applications/dashboard/xaction/panel/PhabricatorDashboardQueryPanelApplicationTransaction.php

Fix the "Add Query to Dashboard..." flow from "Use Results" on search result pages
ClosedPublic
Actions

Revision Contents
Changeset List