Page MenuHomePhabricator

Make "Move Panel" on dashboards use the new storage and transactions
ClosedPublic

Authored by epriestley on Fri, Apr 12, 7:09 PM.

Details

Summary

Depends on D20408. Ref T13272. The actual JS is still a little bit iffy, but this makes the server side "move" operation work correctly by updating it to use the same code as everything else.

Test Plan

Moved panels around on single-column and multi-column dashboards, saw them move to reasonable places and stay there when I reloaded the page.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, Apr 12, 7:09 PM
epriestley requested review of this revision.Fri, Apr 12, 7:11 PM
amckinley accepted this revision.Fri, Apr 12, 8:41 PM
amckinley added inline comments.
webroot/rsrc/js/application/dashboard/behavior-dashboard-move-panels.js
45–46

Not sure if you'd consider this a whitespace-only change detection bug or not, since we're just moving the brace from line 70 up.

This revision is now accepted and ready to land.Fri, Apr 12, 8:41 PM
epriestley added inline comments.Fri, Apr 12, 9:32 PM
webroot/rsrc/js/application/dashboard/behavior-dashboard-move-panels.js
46

I think the rendering is reasonable -- this is the brace from line 70. The brace on line 47/45 moved in, arguably? How would you expect/prefer this be rendered?

amckinley added inline comments.Fri, Apr 12, 9:47 PM
webroot/rsrc/js/application/dashboard/behavior-dashboard-move-panels.js
46

Oh no, this is fine; I just called it out because I spent a minute scratching my head before I figured out what had happened.

This revision was automatically updated to reflect the committed changes.