Page MenuHomePhabricator

Make "Move Panel" on dashboards use the new storage and transactions
ClosedPublic

Authored by epriestley on Apr 12 2019, 7:09 PM.
Tags
None
Referenced Files
F13313883: D20409.id48716.diff
Tue, Jun 11, 1:23 PM
F13312718: D20409.diff
Tue, Jun 11, 6:59 AM
F13299055: D20409.diff
Fri, Jun 7, 7:34 AM
F13269980: D20409.diff
Wed, May 29, 8:31 AM
F13265973: D20409.id.diff
Tue, May 28, 7:39 AM
F13265876: D20409.id48700.diff
Tue, May 28, 6:52 AM
F13264822: D20409.id48716.diff
Mon, May 27, 10:30 PM
F13256105: D20409.diff
Sat, May 25, 9:37 AM
Subscribers
None

Details

Summary

Depends on D20408. Ref T13272. The actual JS is still a little bit iffy, but this makes the server side "move" operation work correctly by updating it to use the same code as everything else.

Test Plan

Moved panels around on single-column and multi-column dashboards, saw them move to reasonable places and stay there when I reloaded the page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
webroot/rsrc/js/application/dashboard/behavior-dashboard-move-panels.js
45–46

Not sure if you'd consider this a whitespace-only change detection bug or not, since we're just moving the brace from line 70 up.

This revision is now accepted and ready to land.Apr 12 2019, 8:41 PM
webroot/rsrc/js/application/dashboard/behavior-dashboard-move-panels.js
46

I think the rendering is reasonable -- this is the brace from line 70. The brace on line 47/45 moved in, arguably? How would you expect/prefer this be rendered?

webroot/rsrc/js/application/dashboard/behavior-dashboard-move-panels.js
46

Oh no, this is fine; I just called it out because I spent a minute scratching my head before I figured out what had happened.

This revision was automatically updated to reflect the committed changes.