Page MenuHomePhabricator

Update "add panel" and "remove panel" Dashboard flows to the new panel storage format
ClosedPublic

Authored by epriestley on Apr 12 2019, 6:29 PM.

Details

Summary

Depends on D20407. Ref T13272. This updates the "add panel" (which has two flavors: "add existing" and "create new") and "remove panel" flows to work with the new duplicate-friendly storage format.

  • We now modify panels by "panelKey", not by panel PHID, so one dashboard may have multiple copies of the same panel and we can still figure out what's going on.
  • We now work with "contextPHID", not "dashboardID", to make some flows with tab panels (or other nested panels in the future) easier.

The only major remaining flow is the Javascript "move panels around with drag-and-drop" flow.

Test Plan
  • Added panels to a dashboard with "Create New Panel".
  • Added panels to a dashboard with "Add Existing Panel".
  • Removed panels from a dashboard.
  • Added and removed duplicate panels, got a correctly-functioning dashboard that didn't care about duplicates.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 12 2019, 6:29 PM
epriestley requested review of this revision.Apr 12 2019, 6:30 PM
amckinley accepted this revision.Apr 12 2019, 8:30 PM
amckinley added inline comments.
src/applications/auth/engine/PhabricatorAuthSessionEngine.php
424

This revision is now accepted and ready to land.Apr 12 2019, 8:30 PM
This revision was automatically updated to reflect the committed changes.