Differential D20408

Update "add panel" and "remove panel" Dashboard flows to the new panel storage format
ClosedPublic
Actions

Authored by epriestley on Apr 12 2019, 6:29 PM.

Tags

None

Referenced Files

	F18805949: D20408.diff
	Sat, Oct 18, 5:06 PM

	F18749118: D20408.diff
	Sat, Oct 4, 2:25 AM

	F18654520: D20408.diff
	Sep 22 2025, 12:44 PM

	F18642566: D20408.id48715.diff
	Sep 19 2025, 12:06 AM

	F18635262: D20408.diff
	Sep 17 2025, 12:53 AM

	F18621475: D20408.id48715.diff
	Sep 15 2025, 8:29 AM

	F18617513: D20408.id48697.diff
	Sep 14 2025, 9:23 PM

	F18613403: D20408.id.diff
	Sep 14 2025, 11:09 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rP82c46f4b93bd: Update "add panel" and "remove panel" Dashboard flows to the new panel storage…

Summary

Depends on D20407. Ref T13272. This updates the "add panel" (which has two flavors: "add existing" and "create new") and "remove panel" flows to work with the new duplicate-friendly storage format.

We now modify panels by "panelKey", not by panel PHID, so one dashboard may have multiple copies of the same panel and we can still figure out what's going on.
We now work with "contextPHID", not "dashboardID", to make some flows with tab panels (or other nested panels in the future) easier.

The only major remaining flow is the Javascript "move panels around with drag-and-drop" flow.

Test Plan

Added panels to a dashboard with "Create New Panel".
Added panels to a dashboard with "Add Existing Panel".
Removed panels from a dashboard.
Added and removed duplicate panels, got a correctly-functioning dashboard that didn't care about duplicates.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 12 2019, 6:29 PM

Harbormaster completed remote builds in B22568: Diff 48697.Apr 12 2019, 6:30 PM

epriestley requested review of this revision.Apr 12 2019, 6:30 PM

epriestley added a child revision: D20409: Make "Move Panel" on dashboards use the new storage and transactions.Apr 12 2019, 7:09 PM

amckinley accepted this revision.Apr 12 2019, 8:30 PM

amckinley added inline comments.

src/applications/auth/engine/PhabricatorAuthSessionEngine.php
424

This revision is now accepted and ready to land.Apr 12 2019, 8:30 PM

Closed by commit rP82c46f4b93bd: Update "add panel" and "remove panel" Dashboard flows to the new panel storage… (authored by epriestley). · Explain WhyApr 14 2019, 5:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

src/

__phutil_library_map__.php

applications/

auth/

engine/

PhabricatorAuthSessionEngine.php

4 lines

dashboard/

application/

PhabricatorDashboardApplication.php

5 lines

controller/

PhabricatorDashboardAddPanelController.php

PhabricatorDashboardRemovePanelController.php

dashboard/

PhabricatorDashboardAdjustController.php

202 lines

panel/

PhabricatorDashboardPanelEditController.php

38 lines

PhabricatorDashboardPanelRenderController.php

19 lines

editor/

PhabricatorDashboardPanelEditEngine.php

70 lines

engine/

PhabricatorDashboardPanelRenderingEngine.php

49 lines

PhabricatorDashboardRenderingEngine.php

28 lines

layoutconfig/

PhabricatorDashboardLayoutConfig.php

PhabricatorDashboardPanelRef.php

8 lines

PhabricatorDashboardPanelRefList.php

43 lines

storage/

PhabricatorDashboard.php

31 lines

xaction/

dashboard/

PhabricatorDashboardPanelsTransaction.php

153 lines

webroot/

rsrc/

js/

application/

dashboard/

behavior-dashboard-async-panel.js

3 lines

Diff 48715

resources/celerity/map.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/auth/engine/PhabricatorAuthSessionEngine.php

Loading...

src/applications/dashboard/application/PhabricatorDashboardApplication.php

Loading...

src/applications/dashboard/controller/PhabricatorDashboardAddPanelController.php

Loading...

src/applications/dashboard/controller/PhabricatorDashboardRemovePanelController.php

Loading...

src/applications/dashboard/controller/dashboard/PhabricatorDashboardAdjustController.php

Loading...

src/applications/dashboard/controller/panel/PhabricatorDashboardPanelEditController.php

Loading...

src/applications/dashboard/controller/panel/PhabricatorDashboardPanelRenderController.php

Loading...

src/applications/dashboard/editor/PhabricatorDashboardPanelEditEngine.php

Loading...

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...

src/applications/dashboard/engine/PhabricatorDashboardRenderingEngine.php

Loading...

src/applications/dashboard/layoutconfig/PhabricatorDashboardLayoutConfig.php

Loading...

src/applications/dashboard/layoutconfig/PhabricatorDashboardPanelRef.php

Loading...

src/applications/dashboard/layoutconfig/PhabricatorDashboardPanelRefList.php

Loading...

src/applications/dashboard/storage/PhabricatorDashboard.php

Loading...

src/applications/dashboard/xaction/dashboard/PhabricatorDashboardPanelsTransaction.php

Loading...

webroot/rsrc/js/application/dashboard/behavior-dashboard-async-panel.js

Loading...