Page MenuHomePhabricator

Fix the "Add Query to Dashboard..." flow from "Use Results" on search result pages
ClosedPublic

Authored by epriestley on Apr 12 2019, 11:48 PM.
Tags
None
Referenced Files
F13317330: D20414.diff
Thu, Jun 13, 9:18 AM
F13303052: D20414.diff
Sat, Jun 8, 6:15 AM
F13292820: D20414.diff
Wed, Jun 5, 5:12 AM
F13285790: D20414.diff
Tue, Jun 4, 2:50 AM
F13274240: D20414.diff
Fri, May 31, 3:29 AM
F13264829: D20414.id48708.diff
Mon, May 27, 10:33 PM
F13264610: D20414.id48757.diff
Mon, May 27, 7:18 PM
F13263732: D20414.id.diff
Mon, May 27, 11:54 AM
Subscribers
None

Details

Summary

Depends on D20413. Ref T13272. When you search for stuff, you can "Use Results > Add to Dashboard" to generate a query panel.

This needs some updating after the recent refactoring. All the changes are pretty straightforward. Swaps a giant <select /> for a tokenizer with a datasource.

Test Plan

Used the "Use Results > Add to Dashboard" flow to create a panel on a dashboard using a query.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable