Fix the "Add Query to Dashboard..." flow from "Use Results" on search result pages
ClosedPublic
Actions

Authored by epriestley on Apr 12 2019, 11:48 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rPe99c1974b027: Fix the "Add Query to Dashboard..." flow from "Use Results" on search result…

Summary

Depends on D20413. Ref T13272. When you search for stuff, you can "Use Results > Add to Dashboard" to generate a query panel.

This needs some updating after the recent refactoring. All the changes are pretty straightforward. Swaps a giant <select /> for a tokenizer with a datasource.

Test Plan

Used the "Use Results > Add to Dashboard" flow to create a panel on a dashboard using a query.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 12 2019, 11:48 PM

Harbormaster completed remote builds in B22578: Diff 48708.Apr 12 2019, 11:49 PM

epriestley requested review of this revision.Apr 12 2019, 11:49 PM

epriestley added a child revision: D20415: Reduce drag-and-drop jank on dashboards.Apr 13 2019, 12:20 AM

amckinley accepted this revision.Apr 17 2019, 5:51 PM

This revision is now accepted and ready to land.Apr 17 2019, 5:51 PM

Closed by commit rPe99c1974b027: Fix the "Add Query to Dashboard..." flow from "Use Results" on search result… (authored by epriestley). · Explain WhyApr 17 2019, 7:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

controller/

PhabricatorDashboardQueryPanelInstallController.php

226 lines

layoutconfig/

PhabricatorDashboardPanelRefList.php

9 lines

storage/

PhabricatorDashboardPanel.php

5 lines

xaction/

panel/

PhabricatorDashboardQueryPanelApplicationTransaction.php

27 lines

Diff 48757

View Options

src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php

View Options

src/applications/dashboard/layoutconfig/PhabricatorDashboardPanelRefList.php

View Options

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

View Options

src/applications/dashboard/xaction/panel/PhabricatorDashboardQueryPanelApplicationTransaction.php

Fix the "Add Query to Dashboard..." flow from "Use Results" on search result pagesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48757

src/applications/dashboard/controller/PhabricatorDashboardQueryPanelInstallController.php

src/applications/dashboard/layoutconfig/PhabricatorDashboardPanelRefList.php

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

src/applications/dashboard/xaction/panel/PhabricatorDashboardQueryPanelApplicationTransaction.php

Fix the "Add Query to Dashboard..." flow from "Use Results" on search result pages
ClosedPublic
Actions

Revision Contents
Changeset List