Differential D20415

Reduce drag-and-drop jank on dashboards
ClosedPublic
Actions

Authored by epriestley on Apr 13 2019, 12:20 AM.

Tags

None

Referenced Files

	F14761018: D20415.id.diff
	Wed, Jan 22, 10:50 PM

	Unknown Object (File)
	Tue, Jan 21, 7:13 PM

	Unknown Object (File)
	Tue, Jan 21, 3:14 PM

	Unknown Object (File)
	Tue, Jan 21, 10:26 AM

	Unknown Object (File)
	Sat, Jan 18, 6:58 PM

	Unknown Object (File)
	Fri, Jan 17, 1:01 PM

	Unknown Object (File)
	Tue, Dec 31, 9:17 PM

	Unknown Object (File)
	Dec 11 2024, 8:58 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13272: Remove the hard-coded homepage, and other Dashboards improvements

Commits

rPb8551bb5f98c: Reduce drag-and-drop jank on dashboards

Summary

Depends on D20414. Ref T13272. Several minor things here:

Currently, you can drag panels underneath the invisible "there are no items in this column" div and the "Create Panel / Add Existing Panel" buttons. This is silly; stop it.
Currently, when viewing a tab panel on a dashboard, you can drag the panels inside it. This is extremely silly. Make "movable" off by default and pass it through the async flow only when we actually need it.
Make the whole "Add Tab..." virtual tab clickable to open the dropdown. This removes the rare exception/todo combo I added earlier. F
Add or remove some icons or something.

Test Plan

Moved panels around on dashboards. Tried to drag panels inside tab panels. Added tab. Things were less obviously broken.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 13 2019, 12:20 AM

Harbormaster completed remote builds in B22579: Diff 48709.Apr 13 2019, 12:22 AM

epriestley requested review of this revision.Apr 13 2019, 12:22 AM

epriestley retitled this revision from Reduce drag-and-drop jank on workboards to Reduce drag-and-drop jank on dashboards.Apr 13 2019, 12:26 AM

amckinley accepted this revision.Apr 17 2019, 5:53 PM

This revision is now accepted and ready to land.Apr 17 2019, 5:53 PM

Closed by commit rPb8551bb5f98c: Reduce drag-and-drop jank on dashboards (authored by epriestley). · Explain WhyApr 17 2019, 7:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

src/

applications/

dashboard/

controller/

panel/

PhabricatorDashboardPanelRenderController.php

1 line

PhabricatorDashboardPanelViewController.php

1 line

engine/

PhabricatorDashboardPanelRenderingEngine.php

3 lines

PhabricatorDashboardRenderingEngine.php

27 lines

paneltype/

PhabricatorDashboardTabsPanelType.php

7 lines

view/

phui/

PHUIListItemView.php

20 lines

webroot/

rsrc/

css/

phui/

phui-action-list.css

5 lines

js/

application/

dashboard/

behavior-dashboard-async-panel.js

1 line

behavior-dashboard-move-panels.js

2 lines

Diff 48758

resources/celerity/map.php

Loading...

src/applications/dashboard/controller/panel/PhabricatorDashboardPanelRenderController.php

Loading...

src/applications/dashboard/controller/panel/PhabricatorDashboardPanelViewController.php

Loading...

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...

src/applications/dashboard/engine/PhabricatorDashboardRenderingEngine.php

Loading...

src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php

Loading...

src/view/phui/PHUIListItemView.php

Loading...

webroot/rsrc/css/phui/phui-action-list.css

Loading...

webroot/rsrc/js/application/dashboard/behavior-dashboard-async-panel.js

Loading...

webroot/rsrc/js/application/dashboard/behavior-dashboard-move-panels.js

Loading...