Page MenuHomePhabricator

Reduce drag-and-drop jank on dashboards

Authored by epriestley on Apr 13 2019, 12:20 AM.
Referenced Files
F13319767: D20415.diff
Thu, Jun 13, 2:18 PM
F13319738: D20415.diff
Thu, Jun 13, 2:07 PM
F13283572: D20415.diff
Sun, Jun 2, 3:57 PM
F13265333: D20415.id48709.diff
Tue, May 28, 3:18 AM
Tue, May 28, 2:37 AM
F13264525: D20415.id48758.diff
Mon, May 27, 6:22 PM
F13257101: D20415.id48758.diff
Sat, May 25, 8:12 PM
F13256337: D20415.diff
Sat, May 25, 11:14 AM



Depends on D20414. Ref T13272. Several minor things here:

  • Currently, you can drag panels underneath the invisible "there are no items in this column" div and the "Create Panel / Add Existing Panel" buttons. This is silly; stop it.
  • Currently, when viewing a tab panel on a dashboard, you can drag the panels inside it. This is extremely silly. Make "movable" off by default and pass it through the async flow only when we actually need it.
  • Make the whole "Add Tab..." virtual tab clickable to open the dropdown. This removes the rare exception/todo combo I added earlier. F
  • Add or remove some icons or something.
Test Plan

Moved panels around on dashboards. Tried to drag panels inside tab panels. Added tab. Things were less obviously broken.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from Reduce drag-and-drop jank on workboards to Reduce drag-and-drop jank on dashboards.Apr 13 2019, 12:26 AM
This revision is now accepted and ready to land.Apr 17 2019, 5:53 PM
This revision was automatically updated to reflect the committed changes.