Page MenuHomePhabricator

Update search indexes for Dashboards and Panels to Ferret, plus various minor fixes
ClosedPublic

Authored by epriestley on Fri, Apr 12, 8:06 PM.

Details

Summary

Depends on D20410. Ref T13272. Dashboards/Panels currently use older "ngram" indexing, which is a less-powerful precursor to Ferret. Throw away the ngram index and provide a Ferret index instead. Also:

  • Remove the NUX state, which links to the wrong place now and doesn't seem terribly important.
  • Add project tags to the search result list.
  • Make the "No Tags" tag a little less conspicious.
Test Plan
  • Indexed dashboards and panels.
  • Searched for dashboards and panels via SearchEngine using Ferret "query" field.
  • Searched for panels via "Add Existing Panel" datasource typeahead.
  • Searched for dashboards via "Add Menu Item > Dashboard" on a ProfileMenu via typeahead.
  • Viewed dashboard NUX state (no special state, but no more bad link to "/create/").
  • Viewed dashboard list, saw project tags.
  • Viewed dashboards with no project tags ("No Tags" is now displayed but less visible).

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Fri, Apr 12, 8:06 PM
Owners added a subscriber: Restricted Owners Package.Fri, Apr 12, 8:06 PM
epriestley requested review of this revision.Fri, Apr 12, 8:08 PM

This (and other changes in this series) require a reindex, but I'm planning to probably let migrations run a bin/search index --type ... via the Worker queue so this happens automatically a little later on, since all the stuff we need to reindex (panels, herald rules, dashboards, portals) should only take a minute or two to reindex.

amckinley accepted this revision.Fri, Apr 12, 9:56 PM
This revision is now accepted and ready to land.Fri, Apr 12, 9:56 PM
This revision was automatically updated to reflect the committed changes.