Page MenuHomePhabricator

Update search indexes for Dashboards and Panels to Ferret, plus various minor fixes
ClosedPublic

Authored by epriestley on Apr 12 2019, 8:06 PM.
Tags
None
Referenced Files
F13320999: D20411.diff
Fri, Jun 14, 6:14 AM
F13316097: D20411.id48718.diff
Wed, Jun 12, 11:11 PM
F13310099: D20411.diff
Mon, Jun 10, 10:57 AM
F13265320: D20411.id48703.diff
Tue, May 28, 3:05 AM
F13264601: D20411.id.diff
Mon, May 27, 7:13 PM
F13263294: D20411.id48703.diff
Mon, May 27, 8:22 AM
F13262712: D20411.id48718.diff
Mon, May 27, 2:50 AM
F13256444: D20411.diff
Sat, May 25, 12:14 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D20410. Ref T13272. Dashboards/Panels currently use older "ngram" indexing, which is a less-powerful precursor to Ferret. Throw away the ngram index and provide a Ferret index instead. Also:

  • Remove the NUX state, which links to the wrong place now and doesn't seem terribly important.
  • Add project tags to the search result list.
  • Make the "No Tags" tag a little less conspicious.
Test Plan
  • Indexed dashboards and panels.
  • Searched for dashboards and panels via SearchEngine using Ferret "query" field.
  • Searched for panels via "Add Existing Panel" datasource typeahead.
  • Searched for dashboards via "Add Menu Item > Dashboard" on a ProfileMenu via typeahead.
  • Viewed dashboard NUX state (no special state, but no more bad link to "/create/").
  • Viewed dashboard list, saw project tags.
  • Viewed dashboards with no project tags ("No Tags" is now displayed but less visible).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Apr 12 2019, 8:06 PM

This (and other changes in this series) require a reindex, but I'm planning to probably let migrations run a bin/search index --type ... via the Worker queue so this happens automatically a little later on, since all the stuff we need to reindex (panels, herald rules, dashboards, portals) should only take a minute or two to reindex.

This revision is now accepted and ready to land.Apr 12 2019, 9:56 PM
This revision was automatically updated to reflect the committed changes.